{"id":25909,"url":"https://patchwork.libcamera.org/api/patches/25909/?format=json","web_url":"https://patchwork.libcamera.org/patch/25909/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260121173737.376113-3-kieran.bingham@ideasonboard.com>","date":"2026-01-21T17:37:21","name":"[v6,02/16] test: libipa: Add tests for Quantized types","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"80188c01a03527ff96e964a70781422c550e0209","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25909/mbox/","series":[{"id":5730,"url":"https://patchwork.libcamera.org/api/series/5730/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5730","date":"2026-01-21T17:37:19","name":"libipa: Introduce a Quantized type","version":6,"mbox":"https://patchwork.libcamera.org/series/5730/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25909/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25909/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01443BDCBF\n\tfor ;\n\tWed, 21 Jan 2026 17:37:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5FCE61FBF;\n\tWed, 21 Jan 2026 18:37:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83C4261F9F\n\tfor ;\n\tWed, 21 Jan 2026 18:37:42 +0100 (CET)","from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71F9CF52;\n\tWed, 21 Jan 2026 18:37:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ot6kHoqY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769017030;\n\tbh=U7bzLk7p/FlBtj8Or9UQwMszh+M73bEBy581fzdsOp4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ot6kHoqYT5qGYzu4rcpccsbexd8XhMpNq4bSdrM2JAbsJOywPt4LEixjS/Q/vpjuX\n\to4fTjNX65CNZJtazdGtrn8UP/tM5rfqjSnG/rgGJJxefg85BcQtBEiI8xOdugQe8QR\n\tdCl6gzlrvN6Y7MbeumOwtcceT7IJODmZo+qC/UJU=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ,\n\tIsaac Scott ","Subject":"[PATCH v6 02/16] test: libipa: Add tests for Quantized types","Date":"Wed, 21 Jan 2026 17:37:21 +0000","Message-ID":"<20260121173737.376113-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>","References":"<20260121173737.376113-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide use case tests for the Quantized types to ensure construction\nand usages are consistent and work as expected.\n\nReviewed-by: Isaac Scott \nSigned-off-by: Kieran Bingham \n\n---\nv3:\n- Rename quantized_type to QuantizedType\n\nv5:\n- use static asserts for constructible failure tests\n- Remove constexpr from lround users (only possible in C++23)\n- Remove move tests\n- Fix up inequality test\n\nv6:\n- Remove static casts on fromFloat conversions\n- Use int8_t(64) instead of (int8_t)64\n- Add new test from different floats to the same quantized value\n\nSigned-off-by: Kieran Bingham \n---\n test/ipa/libipa/meson.build | 1 +\n test/ipa/libipa/quantized.cpp | 148 ++++++++++++++++++++++++++++++++++\n 2 files changed, 149 insertions(+)\n create mode 100644 test/ipa/libipa/quantized.cpp","diff":"diff --git a/test/ipa/libipa/meson.build b/test/ipa/libipa/meson.build\nindex 2070bed70222..c3e255871f4f 100644\n--- a/test/ipa/libipa/meson.build\n+++ b/test/ipa/libipa/meson.build\n@@ -5,6 +5,7 @@ libipa_test = [\n {'name': 'histogram', 'sources': ['histogram.cpp']},\n {'name': 'interpolator', 'sources': ['interpolator.cpp']},\n {'name': 'pwl', 'sources': ['pwl.cpp'] },\n+ {'name': 'quantized', 'sources': ['quantized.cpp']},\n ]\n \n foreach test : libipa_test\ndiff --git a/test/ipa/libipa/quantized.cpp b/test/ipa/libipa/quantized.cpp\nnew file mode 100644\nindex 000000000000..860d54d2dd18\n--- /dev/null\n+++ b/test/ipa/libipa/quantized.cpp\n@@ -0,0 +1,148 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2025, Ideas on Board\n+ *\n+ * Dual Type and Quantizer tests\n+ */\n+\n+#include \"../src/ipa/libipa/quantized.h\"\n+\n+#include \n+#include \n+#include \n+#include \n+#include \n+\n+#include \"test.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+using namespace ipa;\n+\n+struct BrightnessHueTraits {\n+\tusing QuantizedType = int8_t;\n+\tstatic QuantizedType fromFloat(float v)\n+\t{\n+\t\tint quantized = std::lround(v * 128.0f);\n+\t\treturn std::clamp(quantized, -128, 127);\n+\t}\n+\tstatic float toFloat(QuantizedType v)\n+\t{\n+\t\treturn static_cast(v) / 128.0f;\n+\t}\n+};\n+\n+using BrightnessHueQuantizer = Quantized;\n+\n+struct ContrastSaturationTraits {\n+\tusing QuantizedType = uint8_t;\n+\tstatic QuantizedType fromFloat(float v)\n+\t{\n+\t\tint quantized = std::lround(v * 128.0f);\n+\t\treturn std::clamp(quantized, 0, 255);\n+\t}\n+\tstatic float toFloat(QuantizedType v)\n+\t{\n+\t\treturn static_cast(v) / 128.0f;\n+\t}\n+};\n+\n+using ContrastSaturationQuantizer = Quantized;\n+\n+using BrightnessQ = BrightnessHueQuantizer;\n+using HueQ = BrightnessHueQuantizer;\n+using ContrastQ = ContrastSaturationQuantizer;\n+using SaturationQ = ContrastSaturationQuantizer;\n+\n+class QuantizedTest : public Test\n+{\n+protected:\n+\tint run()\n+\t{\n+\t\t/* Test construction from float */\n+\t\t{\n+\t\t\tBrightnessQ b(0.5f);\n+\t\t\tif (b.quantized() != 64 || std::abs(b.value() - 0.5f) > 0.01f)\n+\t\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test construction from T */\n+\t\t{\n+\t\t\tContrastQ c(uint8_t(128));\n+\t\t\tif (c.quantized() != 128 || std::abs(c.value() - 1.0f) > 0.01f)\n+\t\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/*\n+\t\t * Only construction from the exact storage type or a float\n+\t\t * is permitted.\n+\t\t */\n+\t\tstatic_assert(!std::is_constructible_v);\n+\t\tstatic_assert(!std::is_constructible_v);\n+\t\tstatic_assert(!std::is_constructible_v);\n+\t\tstatic_assert(!std::is_constructible_v);\n+\t\tstatic_assert(!std::is_constructible_v);\n+\t\tstatic_assert(!std::is_constructible_v);\n+\n+\t\t/* Test equality */\n+\t\t{\n+\t\t\tBrightnessQ b1(0.5f), b2(int8_t(64));\n+\t\t\tif (!(b1 == b2))\n+\t\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test inequality */\n+\t\t{\n+\t\t\tBrightnessQ b1(0.5f), b2(-0.5f);\n+\t\t\tif (!(b1 != b2))\n+\t\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test copying */\n+\t\t{\n+\t\t\tBrightnessQ b1(0.25f);\n+\t\t\tBrightnessQ b2 = b1;\n+\t\t\tif (!(b1 == b2))\n+\t\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test assignment */\n+\t\t{\n+\t\t\tContrastQ c1(1.5f);\n+\t\t\tContrastQ c2(0.0f);\n+\t\t\tc2 = c1;\n+\t\t\tif (!(c1 == c2))\n+\t\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/*\n+\t\t * Test construction from different floats mapping to same\n+\t\t * quantized value\n+\t\t */\n+\t\t{\n+\t\t\t/* Two floats that have the same quantized value. */\n+\t\t\tconst float f1 = 1.007f;\n+\t\t\tconst float f2 = 1.008f;\n+\n+\t\t\tContrastQ c1(f1);\n+\t\t\tContrastQ c2(f2);\n+\n+\t\t\t/* Quantized values must match */\n+\t\t\tif (!(c1.quantized() == c2.quantized()))\n+\t\t\t\treturn TestFail;\n+\n+\t\t\t/* Float values must now match */\n+\t\t\tif (!(c1.value() == c2.value()))\n+\t\t\t\treturn TestFail;\n+\n+\t\t\tif (!(c1 == c2))\n+\t\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tstd::cout << \"Quantised tests passed successfully.\" << std::endl;\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+TEST_REGISTER(QuantizedTest)\n","prefixes":["v6","02/16"]}