[{"id":37785,"web_url":"https://patchwork.libcamera.org/comment/37785/","msgid":"<20260121101804.GB382676@killaraus>","date":"2026-01-21T10:18:04","subject":"Re: [PATCH v4 2/3] egl: Add workaround for Mesa <= 22.2","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jan 21, 2026 at 10:08:53AM +0100, Robert Mader wrote:\n> Older Mesa versions with EGL headers missing the change from\n> https://github.com/KhronosGroup/EGL-Registry/pull/130\n> pull in Xlib headers, causing build issues.\n> \n> This notably happens on the Debian 11 CI image, which until now does not\n> build the shared EGL code due to missing GBM dependencies. That will\n> change in the following commit, thus include a workaround.\n> \n> Suggested-by: Barnabás Pőcze \n> Signed-off-by: Robert Mader \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> \n> Changes in v4:\n> - Pulled this change into a dedicated commit\n> - Fixed comment style\n> - Fixed Mesa version in comment\n> ---\n> include/libcamera/internal/egl.h | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index 630345ea7..8a2d96d7a 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -16,6 +16,12 @@\n> #include \n> #include \n> \n> +/*\n> + * Workaround for build issues on Mesa <= 22.2, see\n> + * https://github.com/KhronosGroup/EGL-Registry/pull/130\n> + */\n> +#define EGL_NO_X11\n> +\n> #define EGL_EGLEXT_PROTOTYPES\n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 216A3C3220\n\tfor ;\n\tWed, 21 Jan 2026 10:18:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70397615B2;\n\tWed, 21 Jan 2026 11:18:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17E99615B2\n\tfor ;\n\tWed, 21 Jan 2026 11:18:07 +0100 (CET)","from pendragon.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0C994741;\n\tWed, 21 Jan 2026 11:17:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oh/b3TIF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768990655;\n\tbh=GIfqmUopkMVC3Xz+xAoTajAh9n8gfk31hXs09HsF9n8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oh/b3TIFMpj1k9Ubj++1HkYMSivJoyjYyMhSHVNYbmArBOZ2tk3k5eKHKxUHO4KT7\n\tTu4jjD1abP/7POmkzf2znn0WKtIHXHHj7tWnHRsqUn9X+63a45o/g4Kg0cTNwIPRwu\n\tad0NiApAdTw5EPYN2YQwlbNsb3AnmbNdIyEhSxF4=","Date":"Wed, 21 Jan 2026 12:18:04 +0200","From":"Laurent Pinchart ","To":"Robert Mader ","Cc":"libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ","Subject":"Re: [PATCH v4 2/3] egl: Add workaround for Mesa <= 22.2","Message-ID":"<20260121101804.GB382676@killaraus>","References":"<20260121090854.27483-1-robert.mader@collabora.com>\n\t<20260121090854.27483-2-robert.mader@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260121090854.27483-2-robert.mader@collabora.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37797,"web_url":"https://patchwork.libcamera.org/comment/37797/","msgid":"<176900766010.1693075.17545155469766064458@ping.linuxembedded.co.uk>","date":"2026-01-21T15:01:00","subject":"Re: [PATCH v4 2/3] egl: Add workaround for Mesa <= 22.2","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader (2026-01-21 09:08:53)\n> Older Mesa versions with EGL headers missing the change from\n> https://github.com/KhronosGroup/EGL-Registry/pull/130\n> pull in Xlib headers, causing build issues.\n> \n> This notably happens on the Debian 11 CI image, which until now does not\n> build the shared EGL code due to missing GBM dependencies. That will\n> change in the following commit, thus include a workaround.\n> \n> Suggested-by: Barnabás Pőcze \n> Signed-off-by: Robert Mader \n> \n> ---\n> \n> Changes in v4:\n> - Pulled this change into a dedicated commit\n> - Fixed comment style\n> - Fixed Mesa version in comment\n> ---\n> include/libcamera/internal/egl.h | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index 630345ea7..8a2d96d7a 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -16,6 +16,12 @@\n> #include \n> #include \n> \n> +/*\n> + * Workaround for build issues on Mesa <= 22.2, see\n> + * https://github.com/KhronosGroup/EGL-Registry/pull/130\n> + */\n> +#define EGL_NO_X11\n> +\n\nReviewed-by: Kieran Bingham \n\n> #define EGL_EGLEXT_PROTOTYPES\n> #include \n> #include \n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F3CAC3220\n\tfor ;\n\tWed, 21 Jan 2026 15:01:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3336961FC4;\n\tWed, 21 Jan 2026 16:01:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 10F5F61F9F\n\tfor ;\n\tWed, 21 Jan 2026 16:01:03 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 08F61593;\n\tWed, 21 Jan 2026 16:00:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JgNu3eV3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769007631;\n\tbh=3viWIv/16ZnM7PZYJKjdtkL7250eATjBOJsSbGJbJnc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=JgNu3eV3eZVVz/IjgHZdbrKHmMi8h8TmYl4DiMap0MWVUkDI1GFcA8fZNQ1YwZiVo\n\tPlnMIJ88xocIEeOoW5DpOXSlTrAK4BJ9OmXpt2IvQl1/GOSDWCBYWYPcZs4DPdkTfB\n\tUYG/JT+DetGXXhM6pzDOOFQBdkqX3cUcXASTZhBM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260121090854.27483-2-robert.mader@collabora.com>","References":"<20260121090854.27483-1-robert.mader@collabora.com>\n\t<20260121090854.27483-2-robert.mader@collabora.com>","Subject":"Re: [PATCH v4 2/3] egl: Add workaround for Mesa <= 22.2","From":"Kieran Bingham ","Cc":"Robert Mader , =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= ","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 21 Jan 2026 15:01:00 +0000","Message-ID":"<176900766010.1693075.17545155469766064458@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]