{"id":25902,"url":"https://patchwork.libcamera.org/api/patches/25902/?format=json","web_url":"https://patchwork.libcamera.org/patch/25902/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260121090705.274081-4-uajain@igalia.com>","date":"2026-01-21T09:07:05","name":"[3/3] pipeline: virtual: Rectify validation of colorspace","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8c994d1f8cac8d02b45115369806354c8eebc2e7","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25902/mbox/","series":[{"id":5727,"url":"https://patchwork.libcamera.org/api/series/5727/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5727","date":"2026-01-21T09:07:02","name":"virtual: colorspace validation fix","version":1,"mbox":"https://patchwork.libcamera.org/series/5727/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25902/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25902/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88F1EBDCBF\n\tfor ;\n\tWed, 21 Jan 2026 09:06:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4887C61FD3;\n\tWed, 21 Jan 2026 10:06:30 +0100 (CET)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BB2B61FCF\n\tfor ;\n\tWed, 21 Jan 2026 10:06:26 +0100 (CET)","from [49.36.125.126] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1viUAT-007xDQ-0A; Wed, 21 Jan 2026 10:06:25 +0100"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"QKOm0lZI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=rqYmOETbgScdIWiBErDSx0hw8farFh8j8WEQ0XQEQLc=;\n\tb=QKOm0lZI5diqCRbxAdO62oWTMr\n\tFPrzR6eeOaBD572VQpL3Ewts4THU6mo7GjNTz1nb5wcCGAsbGxatHtkMAkjf6ShyItjEmJNxIG2xx\n\tVApreIMvXauRvMz5PTGH1UW/jWIZTr46/PBm2oH8vvfATTzS9SFjd9ZWtWBI10XdQJcMEbxTHp0+A\n\tkr7BfCrfm/okkR8AGeac/Eng8wJWOQJpuwZbKbHjsRtEqH1b+2eqtRW/v66PpFeEmqq19EjVai3+G\n\t78a0EvtB2Y0gu1TwxJEu8r2gbPAmJjCM/bdv/ZiY9srepAyjFVbxpMkpeMZ9HYfmrRV2MAFkXrVtv\n\tTDSHl1NQ==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Umang Jain ","Subject":"[PATCH 3/3] pipeline: virtual: Rectify validation of colorspace","Date":"Wed, 21 Jan 2026 14:37:05 +0530","Message-ID":"<20260121090705.274081-4-uajain@igalia.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260121090705.274081-1-uajain@igalia.com>","References":"<20260121090705.274081-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that each frame generator class supports the colorspace\ninformation using the colorspace() getter, use that to validate\n(or set) the colorspace of a particular stream configuration instead\nof a incorrect hard-coded one.\n\nFixes: 5d2d005306ad (\"pipeline: virtual: Provide and validate colorspace\")\nSigned-off-by: Umang Jain \n---\n src/libcamera/pipeline/virtual/virtual.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex 40c35264..3d205a6c 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -185,7 +185,7 @@ CameraConfiguration::Status VirtualCameraConfiguration::validate()\n \t\tstatus = Adjusted;\n \t}\n \n-\tfor (StreamConfiguration &cfg : config_) {\n+\tfor (auto [i, cfg] : utils::enumerate(config_)) {\n \t\tbool adjusted = false;\n \t\tbool found = false;\n \t\tfor (const auto &resolution : data_->config_.resolutions) {\n@@ -214,8 +214,9 @@ CameraConfiguration::Status VirtualCameraConfiguration::validate()\n \t\t\tadjusted = true;\n \t\t}\n \n-\t\tif (cfg.colorSpace != ColorSpace::Rec709) {\n-\t\t\tcfg.colorSpace = ColorSpace::Rec709;\n+\t\tconst ColorSpace colorspace = data_->streamConfigs_[i].frameGenerator->colorspace();\n+\t\tif (cfg.colorSpace != colorspace) {\n+\t\t\tcfg.colorSpace = colorspace;\n \t\t\tstatus = Adjusted;\n \t\t\tadjusted = true;\n \t\t}\n@@ -289,7 +290,6 @@ PipelineHandlerVirtual::generateConfiguration(Camera *camera,\n \t\tcfg.pixelFormat = pixelFormat;\n \t\tcfg.size = data->config_.maxResolutionSize;\n \t\tcfg.bufferCount = VirtualCameraConfiguration::kBufferCount;\n-\t\tcfg.colorSpace = ColorSpace::Rec709;\n \n \t\tconfig->addConfiguration(cfg);\n \t}\n","prefixes":["3/3"]}