[{"id":37763,"web_url":"https://patchwork.libcamera.org/comment/37763/","msgid":"<20260120151805.GB143894@killaraus>","date":"2026-01-20T15:18:05","subject":"Re: [PATCH v1] libcamera: pipeline: virtual: Don't use span iterator\n\tas pointer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 20, 2026 at 03:44:20PM +0100, Barnabás Pőcze wrote:\n> Pointer to the contiguous data of a container is to be retrieved\n> using the `data()` member function. Using `begin()` in contexts\n> that require pointers is not correct as the iterator may be\n> something entirely different. So use `data()` where applicable.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/virtual/image_frame_generator.cpp | 5 +++--\n> src/libcamera/pipeline/virtual/test_pattern_generator.cpp | 4 ++--\n> 2 files changed, 5 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/virtual/image_frame_generator.cpp b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n> index d1545b5d9..5ba76507a 100644\n> --- a/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n> +++ b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n> @@ -136,8 +136,9 @@ int ImageFrameGenerator::generateFrame(const Size &size, const FrameBuffer *buff\n> \n> \t/* Write the scaledY and scaledUV to the mapped frame buffer */\n> \tlibyuv::NV12Copy(scaledFrameDatas_[frameIndex_].Y.get(), size.width,\n> -\t\t\t scaledFrameDatas_[frameIndex_].UV.get(), size.width, planes[0].begin(),\n> -\t\t\t size.width, planes[1].begin(), size.width,\n> +\t\t\t scaledFrameDatas_[frameIndex_].UV.get(), size.width,\n> +\t\t\t planes[0].data(), size.width,\n> +\t\t\t planes[1].data(), size.width,\n> \t\t\t size.width, size.height);\n> \n> \t/* Proceed to the next image every 4 frames */\n> diff --git a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n> index 745be83b9..12cce9f7e 100644\n> --- a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n> +++ b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n> @@ -53,8 +53,8 @@ int TestPatternGenerator::generateFrame(const Size &size,\n> \n> \t/* Convert the template_ to the frame buffer */\n> \tint ret = libyuv::ARGBToNV12(template_.get(), size.width * kARGBSize,\n> -\t\t\t\t planes[0].begin(), size.width,\n> -\t\t\t\t planes[1].begin(), size.width,\n> +\t\t\t\t planes[0].data(), size.width,\n> +\t\t\t\t planes[1].data(), size.width,\n> \t\t\t\t size.width, size.height);\n> \tif (ret != 0)\n> \t\tLOG(Virtual, Error) << \"ARGBToNV12() failed with \" << ret;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D89EABDCBF\n\tfor ;\n\tTue, 20 Jan 2026 15:18:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C80761FC5;\n\tTue, 20 Jan 2026 16:18:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4833961A35\n\tfor ;\n\tTue, 20 Jan 2026 16:18:07 +0100 (CET)","from pendragon.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0B8972147; \n\tTue, 20 Jan 2026 16:17:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jkEDQu8E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768922256;\n\tbh=t6JOdFPj5YOrFhwgTlZIrWe6fYORChtl8uiHOwWOV7g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jkEDQu8EPrZ3OZXdYy6uWUhDKKcdkMsJ2vAEsH1JBvDgd2vz3WB/A4+46pRODN/RS\n\tiuFMqL5C1NeX7RJ7QrV4MrJNeJn+nUOrcgn6Pa/ofOJoBn3o606JYqwNvDzCASoGI+\n\tfGgf5nB3kIeJwocniCmFxT/3n4I+H335U6RkvIuE=","Date":"Tue, 20 Jan 2026 17:18:05 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: pipeline: virtual: Don't use span iterator\n\tas pointer","Message-ID":"<20260120151805.GB143894@killaraus>","References":"<20260120144420.264358-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260120144420.264358-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37922,"web_url":"https://patchwork.libcamera.org/comment/37922/","msgid":"<176918279407.2663600.5067605272190354572@isaac-ThinkPad-T16-Gen-2>","date":"2026-01-23T15:39:54","subject":"Re: [PATCH v1] libcamera: pipeline: virtual: Don't use span iterator\n\tas pointer","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Barnabás,\n\nQuoting Barnabás Pőcze (2026-01-20 14:44:20)\n> Pointer to the contiguous data of a container is to be retrieved\n> using the `data()` member function. Using `begin()` in contexts\n> that require pointers is not correct as the iterator may be\n> something entirely different. So use `data()` where applicable.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/pipeline/virtual/image_frame_generator.cpp | 5 +++--\n> src/libcamera/pipeline/virtual/test_pattern_generator.cpp | 4 ++--\n> 2 files changed, 5 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/virtual/image_frame_generator.cpp b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n> index d1545b5d9..5ba76507a 100644\n> --- a/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n> +++ b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n> @@ -136,8 +136,9 @@ int ImageFrameGenerator::generateFrame(const Size &size, const FrameBuffer *buff\n> \n> /* Write the scaledY and scaledUV to the mapped frame buffer */\n> libyuv::NV12Copy(scaledFrameDatas_[frameIndex_].Y.get(), size.width,\n> - scaledFrameDatas_[frameIndex_].UV.get(), size.width, planes[0].begin(),\n> - size.width, planes[1].begin(), size.width,\n> + scaledFrameDatas_[frameIndex_].UV.get(), size.width,\n> + planes[0].data(), size.width,\n> + planes[1].data(), size.width,\n> size.width, size.height);\n> \n> /* Proceed to the next image every 4 frames */\n> diff --git a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n> index 745be83b9..12cce9f7e 100644\n> --- a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n> +++ b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n> @@ -53,8 +53,8 @@ int TestPatternGenerator::generateFrame(const Size &size,\n> \n> /* Convert the template_ to the frame buffer */\n> int ret = libyuv::ARGBToNV12(template_.get(), size.width * kARGBSize,\n> - planes[0].begin(), size.width,\n> - planes[1].begin(), size.width,\n> + planes[0].data(), size.width,\n> + planes[1].data(), size.width,\n\nReviewed-by: Isaac Scott \n\n> size.width, size.height);\n> if (ret != 0)\n> LOG(Virtual, Error) << \"ARGBToNV12() failed with \" << ret;\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD52CBDCBF\n\tfor ;\n\tFri, 23 Jan 2026 15:39:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11D5B61FC9;\n\tFri, 23 Jan 2026 16:39:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BA0C615B2\n\tfor ;\n\tFri, 23 Jan 2026 16:39:57 +0100 (CET)","from thinkpad.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC4DF9CE;\n\tFri, 23 Jan 2026 16:39:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j3lG3qEz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769182763;\n\tbh=A2kmuWXovKq2///bxrcchz2t4VZ6BmavOMKRBNqA/uk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=j3lG3qEzHVXF9K5zG32AFaIowhGWfZqn/bnu0+gMHzkZgMnIl6dLpgnhATsynTsgS\n\tu60FCc92GbBILviSKRMUGkxoIlVJMM64qiFMmVZu65EiTXpwczbJ67Z72qFd1bL/fy\n\tznilVxIK+eBjTZiSlMf2GDqENw8SH+2Ln3ChL7q4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260120144420.264358-1-barnabas.pocze@ideasonboard.com>","References":"<20260120144420.264358-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1] libcamera: pipeline: virtual: Don't use span iterator\n\tas pointer","From":"Isaac Scott ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 23 Jan 2026 15:39:54 +0000","Message-ID":"<176918279407.2663600.5067605272190354572@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]