{"id":25888,"url":"https://patchwork.libcamera.org/api/patches/25888/?format=json","web_url":"https://patchwork.libcamera.org/patch/25888/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260120144420.264358-1-barnabas.pocze@ideasonboard.com>","date":"2026-01-20T14:44:20","name":"[v1] libcamera: pipeline: virtual: Don't use span iterator as pointer","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"25be473a3bc55fc1fe096f30662a46cd6f7fa0fd","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25888/mbox/","series":[{"id":5723,"url":"https://patchwork.libcamera.org/api/series/5723/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5723","date":"2026-01-20T14:44:20","name":"[v1] libcamera: pipeline: virtual: Don't use span iterator as pointer","version":1,"mbox":"https://patchwork.libcamera.org/series/5723/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25888/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25888/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C132C3220\n\tfor ;\n\tTue, 20 Jan 2026 14:44:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A38761FC9;\n\tTue, 20 Jan 2026 15:44:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CEC061A35\n\tfor ;\n\tTue, 20 Jan 2026 15:44:24 +0100 (CET)","from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED23C177D\n\tfor ;\n\tTue, 20 Jan 2026 15:43:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tl8X3Csb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768920233;\n\tbh=DyyZRCCFGIafOOWR1pFK5lPr66T8OmgWPYIxZ2cuVqM=;\n\th=From:To:Subject:Date:From;\n\tb=tl8X3CsbUZDZm9yACMXruyTcHbV98fxdsRmkVDyqC5LxuKz6dD7vqrXEzugZgr2hf\n\twB56b1D1uYvTjGlDAGZdwy7ZYTbbBUuo5AUA+/CookNagPekOHWlXhzamKA4TKkaWy\n\tm4zas0HzvmeJ8sBp91IShcLIETbsCZHB8FKW4w2w=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: pipeline: virtual: Don't use span iterator as\n\tpointer","Date":"Tue, 20 Jan 2026 15:44:20 +0100","Message-ID":"<20260120144420.264358-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Pointer to the contiguous data of a container is to be retrieved\nusing the `data()` member function. Using `begin()` in contexts\nthat require pointers is not correct as the iterator may be\nsomething entirely different. So use `data()` where applicable.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/pipeline/virtual/image_frame_generator.cpp | 5 +++--\n src/libcamera/pipeline/virtual/test_pattern_generator.cpp | 4 ++--\n 2 files changed, 5 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/virtual/image_frame_generator.cpp b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\nindex d1545b5d9..5ba76507a 100644\n--- a/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n+++ b/src/libcamera/pipeline/virtual/image_frame_generator.cpp\n@@ -136,8 +136,9 @@ int ImageFrameGenerator::generateFrame(const Size &size, const FrameBuffer *buff\n \n \t/* Write the scaledY and scaledUV to the mapped frame buffer */\n \tlibyuv::NV12Copy(scaledFrameDatas_[frameIndex_].Y.get(), size.width,\n-\t\t\t scaledFrameDatas_[frameIndex_].UV.get(), size.width, planes[0].begin(),\n-\t\t\t size.width, planes[1].begin(), size.width,\n+\t\t\t scaledFrameDatas_[frameIndex_].UV.get(), size.width,\n+\t\t\t planes[0].data(), size.width,\n+\t\t\t planes[1].data(), size.width,\n \t\t\t size.width, size.height);\n \n \t/* Proceed to the next image every 4 frames */\ndiff --git a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\nindex 745be83b9..12cce9f7e 100644\n--- a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n+++ b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n@@ -53,8 +53,8 @@ int TestPatternGenerator::generateFrame(const Size &size,\n \n \t/* Convert the template_ to the frame buffer */\n \tint ret = libyuv::ARGBToNV12(template_.get(), size.width * kARGBSize,\n-\t\t\t\t planes[0].begin(), size.width,\n-\t\t\t\t planes[1].begin(), size.width,\n+\t\t\t\t planes[0].data(), size.width,\n+\t\t\t\t planes[1].data(), size.width,\n \t\t\t\t size.width, size.height);\n \tif (ret != 0)\n \t\tLOG(Virtual, Error) << \"ARGBToNV12() failed with \" << ret;\n","prefixes":["v1"]}