[{"id":37984,"web_url":"https://patchwork.libcamera.org/comment/37984/","msgid":"<20260128110645.GB2558360@killaraus>","date":"2026-01-28T11:06:45","subject":"Re: [PATCH v5 04/15] ipa: rkisp1: lsc: Rename res to positions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 20, 2026 at 01:26:09PM +0100, Stefan Klug wrote:\n> Rename the res variable to positions which better describes the intent.\n> This was commented in review after being merged.\n> \n> While at it, improve the documentation a bit.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Barnabás Pőcze \n> Reviewed-by: Rui Wang \n> \n> ---\n> \n> Changes in v2:\n> - Collected tags\n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 18 ++++++++++--------\n> 1 file changed, 10 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index c581e6441853d18618284b51bfa25c25e1fc8083..bb58386ae646ad6089322ba63d2a9e89664884d2 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -132,9 +132,11 @@ public:\n> \n> private:\n> \t/*\n> -\t * The lsc grid has custom spacing defined on half the range (see\n> -\t * parseSizes() for details). For easier handling this function converts\n> -\t * the spaces vector to positions and mirrors them. E.g.:\n> +\t * The rkisp1 LSC grid spacing is defined by the cell sizes on the first\n> +\t * half of the grid. This is then mirrored in hardware to the other\n> +\t * half. See parseSizes() for further details. For easier handling, this\n\nThis makes it sound like the grid is split in two, while it's split in\nfour. I would use quadrant instead of half:\n\n\t * The rkisp1 LSC grid spacing is defined by the cell sizes on the\n\t * top-left quadrant of the grid. This is then mirrored in hardware to\n\t * the other quadrants. See parseSizes() for further details.\n\nUp to you.\n\nReviewed-by: Laurent Pinchart \n\n> +\t * function converts the cell sizes of half the grid to a list of\n> +\t * position of the whole grid (on one axis). Example:\n> \t *\n> \t * input: | 0.2 | 0.3 |\n> \t * output: 0.0 0.2 0.5 0.8 1.0\n> @@ -142,17 +144,17 @@ private:\n> \tstd::vector sizesListToPositions(const std::vector &sizes)\n> \t{\n> \t\tconst int half = sizes.size();\n> -\t\tstd::vector res(half * 2 + 1);\n> +\t\tstd::vector positions(half * 2 + 1);\n> \t\tdouble x = 0.0;\n> \n> -\t\tres[half] = 0.5;\n> +\t\tpositions[half] = 0.5;\n> \t\tfor (int i = 1; i <= half; i++) {\n> \t\t\tx += sizes[half - i];\n> -\t\t\tres[half - i] = 0.5 - x;\n> -\t\t\tres[half + i] = 0.5 + x;\n> +\t\t\tpositions[half - i] = 0.5 - x;\n> +\t\t\tpositions[half + i] = 0.5 + x;\n> \t\t}\n> \n> -\t\treturn res;\n> +\t\treturn positions;\n> \t}\n> \n> \tstd::vector samplePolynomial(const LscPolynomial &poly)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8679CC3200\n\tfor ;\n\tWed, 28 Jan 2026 11:06:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 422AE61FD0;\n\tWed, 28 Jan 2026 12:06:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D15861FC4\n\tfor ;\n\tWed, 28 Jan 2026 12:06:47 +0100 (CET)","from pendragon.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4633CC6F;\n\tWed, 28 Jan 2026 12:06:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jCTJQu0Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769598370;\n\tbh=9s1zDXtG7wqI2JDPwJyOK2vtLgCuOTwOaHB8ZhI7uV4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jCTJQu0Q0a1lHW+pU7YffMz6GbXrFekQrs8M1regEk6mE5JEI7eGhs5ZVUj0k+Te5\n\tWHoeBg5aG3SLGQkrZQz0z1j8XAJ35qKzsZ6H5BHFyZW36xC58sQyyvVfo7eYnOqGMy\n\tyUDp/hQJ61LBmINZfE+UrTdlkDNZ30cyeUXXjNx4=","Date":"Wed, 28 Jan 2026 13:06:45 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= ,\n\tRui Wang ","Subject":"Re: [PATCH v5 04/15] ipa: rkisp1: lsc: Rename res to positions","Message-ID":"<20260128110645.GB2558360@killaraus>","References":"<20260120-sklug-lsc-resampling-v2-dev-v5-0-ef5cec7b299f@ideasonboard.com>\n\t<20260120-sklug-lsc-resampling-v2-dev-v5-4-ef5cec7b299f@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260120-sklug-lsc-resampling-v2-dev-v5-4-ef5cec7b299f@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]