[{"id":37760,"web_url":"https://patchwork.libcamera.org/comment/37760/","msgid":"<176891552693.1693075.17431236625659587934@ping.linuxembedded.co.uk>","date":"2026-01-20T13:25:26","subject":"Re: [PATCH v2] libcamera: simple: Enable SoftISP for imx7-csi","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader (2026-01-19 13:13:27)\n> Since commit \"libcamera: simple: Make raw streams working\" apps that rely\n> on raw streams - such as Millipixels - can work with the SoftISP being\n> enabled. Thus let's enable the later by default.\n> \n> Tested on a Librem5.\n\nAs I understand it - this is a helpful thing to add now ... perhaps even\nsoon we'll not need the variable here at all... but that can be later.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Robert Mader \n> ---\n> Documentation/isp-feature-matrix.rst | 1 +\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/Documentation/isp-feature-matrix.rst b/Documentation/isp-feature-matrix.rst\n> index 3b101eb2f..b56f1e56e 100644\n> --- a/Documentation/isp-feature-matrix.rst\n> +++ b/Documentation/isp-feature-matrix.rst\n> @@ -67,6 +67,7 @@ different platforms in libcamera.\n> \n> * Intel 11th-14th Gen (IPU6)\n> * Intel 15th Gen (IPU7)\n> + * NXP i.MX7 and i.MX8 series (imx7-csi)\n> * Texas Instruments J7x/AM6x\n> * Qualcomm Snapdragon (CamSS)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index b30b0a122..4a0b9f58d 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -257,7 +257,7 @@ namespace {\n> \n> static const SimplePipelineInfo supportedDevices[] = {\n> { \"dcmipp\", {}, false },\n> - { \"imx7-csi\", { { \"pxp\", 1 } }, false },\n> + { \"imx7-csi\", { { \"pxp\", 1 } }, true },\n> { \"intel-ipu6\", {}, true },\n> { \"intel-ipu7\", {}, true },\n> { \"j721e-csi2rx\", {}, true },\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 109B4C3220\n\tfor ;\n\tTue, 20 Jan 2026 13:25:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBE5561FC4;\n\tTue, 20 Jan 2026 14:25:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B04AB61A35\n\tfor ;\n\tTue, 20 Jan 2026 14:25:29 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6A7822147;\n\tTue, 20 Jan 2026 14:24:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OA8141kV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768915498;\n\tbh=CEGsKOVXUMFg3ywW7/hwj54EQyrXgUMu5F4FRFnv3kQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=OA8141kVm1/j3DoCEs/8kX/nNe0niJYQseTIW7OZzKE/YBCMCmGHhifL5fMJtEfdh\n\tTuRDiSQs1up4hXdv6BCQgJ2yIivqZUU2a38FopVMEeuyB+c7gVnJvJOtjGavOmIZg4\n\tu6MQBPLjWlTifZR8dhjOoCi1qytRapL+cJzO4tBo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260119131327.47372-1-robert.mader@collabora.com>","References":"<20260119131327.47372-1-robert.mader@collabora.com>","Subject":"Re: [PATCH v2] libcamera: simple: Enable SoftISP for imx7-csi","From":"Kieran Bingham ","Cc":"Robert Mader ","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 20 Jan 2026 13:25:26 +0000","Message-ID":"<176891552693.1693075.17431236625659587934@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37766,"web_url":"https://patchwork.libcamera.org/comment/37766/","msgid":"<6149302.GXAFRqVoOG@pliszka>","date":"2026-01-20T15:32:30","subject":"Re: [PATCH v2] libcamera: simple: Enable SoftISP for imx7-csi","submitter":{"id":256,"url":"https://patchwork.libcamera.org/api/people/256/","name":"Sebastian Krzyszkowiak","email":"sebastian.krzyszkowiak@puri.sm"},"content":"On poniedziałek, 19 stycznia 2026 14:13:27 czas środkowoeuropejski standardowy \nRobert Mader wrote:\n> Since commit \"libcamera: simple: Make raw streams working\" apps that rely\n> on raw streams - such as Millipixels - can work with the SoftISP being\n> enabled. Thus let's enable the later by default.\n> \n> Tested on a Librem5.\n\nThanks, glad to see this all coming together.\n\nAcked-by: Sebastian Krzyszkowiak \n\n> Signed-off-by: Robert Mader \n> Reviewed-by: Kieran Bingham \n> ---\n> Documentation/isp-feature-matrix.rst | 1 +\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/Documentation/isp-feature-matrix.rst\n> b/Documentation/isp-feature-matrix.rst index 3b101eb2f..b56f1e56e 100644\n> --- a/Documentation/isp-feature-matrix.rst\n> +++ b/Documentation/isp-feature-matrix.rst\n> @@ -67,6 +67,7 @@ different platforms in libcamera.\n> \n> * Intel 11th-14th Gen (IPU6)\n> * Intel 15th Gen (IPU7)\n> + * NXP i.MX7 and i.MX8 series (imx7-csi)\n> * Texas Instruments J7x/AM6x\n> * Qualcomm Snapdragon (CamSS)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp\n> b/src/libcamera/pipeline/simple/simple.cpp index b30b0a122..4a0b9f58d\n> 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -257,7 +257,7 @@ namespace {\n> \n> static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"dcmipp\", {}, false },\n> -\t{ \"imx7-csi\", { { \"pxp\", 1 } }, false },\n> +\t{ \"imx7-csi\", { { \"pxp\", 1 } }, true },\n> \t{ \"intel-ipu6\", {}, true },\n> \t{ \"intel-ipu7\", {}, true },\n> \t{ \"j721e-csi2rx\", {}, true },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2564C3220\n\tfor ;\n\tTue, 20 Jan 2026 15:55:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE5DF61FBF;\n\tTue, 20 Jan 2026 16:55:02 +0100 (CET)","from ms.puri.sm (ms.puri.sm [IPv6:2a01:4f9:c012:9260::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2308461A35\n\tfor ;\n\tTue, 20 Jan 2026 16:32:33 +0100 (CET)","from pliszka.localnet (79.184.64.12.ipv4.supernova.orange.pl\n\t[79.184.64.12]) by ms.puri.sm (Postfix) with ESMTPSA id 39FE91FA58;\n\tTue, 20 Jan 2026 07:32:32 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=puri.sm header.i=@puri.sm header.b=\"i2PJkfsF\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=smtp2;\n\tt=1768923152; bh=04BZ9VYIIPIZ+MMKeCDC9o3k9+F6iAo31nwuEgZOTMM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=i2PJkfsFgy7wQPVmTola5t4IMV+PKWhdn6TKMHqQJniFeUK2+DwwI2hx9DZVnRRMW\n\t5beNS/WhOKi3RxIycV251K1BjvBgk0goVjSrbwXNSslIYuBGwAulTrt1zdJu13buIX\n\tuQwLmeR80A5C7I4AxaOfbFscn24kFf4JxS+M76t3RgV8n3qbbXo+Nc1tbX7jFS+Oxs\n\txdEKmlSsASef0kL5ubG6cl/GrLGv3H2kZ1qDQexkQ0GcHkV29zzB7eCSDcFeVNfiXS\n\thHH1JUOXvNql/OzM3vfmd95O95YXZnkPEBmPlc3iMQAUYzIWbbw0CjVxRm3y7wx8gl\n\tAEaLkM80UObNA==","From":"Sebastian Krzyszkowiak ","To":"libcamera-devel@lists.libcamera.org","Cc":"Robert Mader ","Subject":"Re: [PATCH v2] libcamera: simple: Enable SoftISP for imx7-csi","Date":"Tue, 20 Jan 2026 16:32:30 +0100","Message-ID":"<6149302.GXAFRqVoOG@pliszka>","In-Reply-To":"<20260119131327.47372-1-robert.mader@collabora.com>","References":"<20260119131327.47372-1-robert.mader@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"utf-8\"","X-Mailman-Approved-At":"Tue, 20 Jan 2026 16:55:01 +0100","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37781,"web_url":"https://patchwork.libcamera.org/comment/37781/","msgid":"<176898267339.9154.15112611591099387619@freya>","date":"2026-01-21T08:04:33","subject":"Re: [PATCH v2] libcamera: simple: Enable SoftISP for imx7-csi","submitter":{"id":223,"url":"https://patchwork.libcamera.org/api/people/223/","name":"Jai Luthra","email":"jai.luthra@ideasonboard.com"},"content":"Quoting Robert Mader (2026-01-19 18:43:27)\n> Since commit \"libcamera: simple: Make raw streams working\" apps that rely\n> on raw streams - such as Millipixels - can work with the SoftISP being\n> enabled. Thus let's enable the later by default.\n> \n> Tested on a Librem5.\n> \n> Signed-off-by: Robert Mader \n\nThanks for updating the documentation as well!\n\nReviewed-by: Jai Luthra \n\n> ---\n> Documentation/isp-feature-matrix.rst | 1 +\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/Documentation/isp-feature-matrix.rst b/Documentation/isp-feature-matrix.rst\n> index 3b101eb2f..b56f1e56e 100644\n> --- a/Documentation/isp-feature-matrix.rst\n> +++ b/Documentation/isp-feature-matrix.rst\n> @@ -67,6 +67,7 @@ different platforms in libcamera.\n> \n> * Intel 11th-14th Gen (IPU6)\n> * Intel 15th Gen (IPU7)\n> + * NXP i.MX7 and i.MX8 series (imx7-csi)\n> * Texas Instruments J7x/AM6x\n> * Qualcomm Snapdragon (CamSS)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index b30b0a122..4a0b9f58d 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -257,7 +257,7 @@ namespace {\n> \n> static const SimplePipelineInfo supportedDevices[] = {\n> { \"dcmipp\", {}, false },\n> - { \"imx7-csi\", { { \"pxp\", 1 } }, false },\n> + { \"imx7-csi\", { { \"pxp\", 1 } }, true },\n> { \"intel-ipu6\", {}, true },\n> { \"intel-ipu7\", {}, true },\n> { \"j721e-csi2rx\", {}, true },\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CCA61C3220\n\tfor ;\n\tWed, 21 Jan 2026 08:04:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 008B661FC4;\n\tWed, 21 Jan 2026 09:04:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3143615B2\n\tfor ;\n\tWed, 21 Jan 2026 09:04:48 +0100 (CET)","from mail.ideasonboard.com (unknown [223.190.87.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9DB6E741;\n\tWed, 21 Jan 2026 09:04:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tHRH4Q5Z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768982657;\n\tbh=Ci6aQT2JfDVI4suelaVGEAp3jn7IxtlQkOsWMSBfGOI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tHRH4Q5Z5v0Aw0/GmTRwgSl6DEmkfE4jve1Fk+Q4530YLO59hrP0LrbgC9cIuAK/Z\n\tgy54/TFZfpS9C6aP+eYIDhR/ihG5zimNiMuyNR1KDUiCgjrpSRolhj160OPfgKht2V\n\trODAhzqOPLeVYvi/U/Zdlb/7knxfC31UPG2krMzc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260119131327.47372-1-robert.mader@collabora.com>","References":"<20260119131327.47372-1-robert.mader@collabora.com>","Subject":"Re: [PATCH v2] libcamera: simple: Enable SoftISP for imx7-csi","From":"Jai Luthra ","Cc":"Robert Mader ","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 21 Jan 2026 13:34:33 +0530","Message-ID":"<176898267339.9154.15112611591099387619@freya>","User-Agent":"alot/0.12.dev62+gb9d6144a6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]