[{"id":37734,"web_url":"https://patchwork.libcamera.org/comment/37734/","msgid":"<176882716511.3486172.16569166465013002974@ping.linuxembedded.co.uk>","date":"2026-01-19T12:52:45","subject":"Re: [PATCH v2 4/5] libcamera: base: log: Remove `LogInvalid` check","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-01-19 11:31:02)\n> A `LogMessage` instance cannot be moved or copied, so a severity of\n> `LogInvalid` is only possible if the message was constructed with that\n> log level explicitly. However, being a completely internal type, this\n> does not occur. So remove the check. And even if it does, it's probably\n> still better to print the message than to drop it silently.\n> \n> Signed-off-by: Barnabás Pőcze \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/base/log.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index da45b0d65..7d308afae 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -857,10 +857,6 @@ LogMessage::LogMessage(const char *fileName, unsigned int line,\n> \n> LogMessage::~LogMessage()\n> {\n> - /* Don't print anything if we have been moved to another LogMessage. */\n> - if (severity_ == LogInvalid)\n> - return;\n> -\n> Logger *logger = Logger::instance();\n> if (!logger)\n> return;\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55035BDCBF\n\tfor ;\n\tMon, 19 Jan 2026 12:52:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 023A961FC8;\n\tMon, 19 Jan 2026 13:52:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28102606D5\n\tfor ;\n\tMon, 19 Jan 2026 13:52:48 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6D1FB3;\n\tMon, 19 Jan 2026 13:52:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nYlmhtdT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768827137;\n\tbh=ke7XHbBZvvG8bSEm+juH+f4Li91e9Q7nrqiqR8Eb4c8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=nYlmhtdTl5xsfc9dGSoRre/2LtJgLnaY4kBtvzoZdTrKYLrIuZ2zBXacoKvo4K1wQ\n\tX6IyTIxPN2Lzg+cqZC5puXS/NGDJoPT/Z3011YtpYcDuaOVwBjJZbhFVmkfoiNS/qY\n\t5hiB8lq2fruZTT6bRve3GkmbKrFlAyj6UGuHY6Ac=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260119113104.3560802-5-barnabas.pocze@ideasonboard.com>","References":"<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>\n\t<20260119113104.3560802-5-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 4/5] libcamera: base: log: Remove `LogInvalid` check","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 19 Jan 2026 12:52:45 +0000","Message-ID":"<176882716511.3486172.16569166465013002974@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37748,"web_url":"https://patchwork.libcamera.org/comment/37748/","msgid":"<20260119174139.GG26642@pendragon.ideasonboard.com>","date":"2026-01-19T17:41:39","subject":"Re: [PATCH v2 4/5] libcamera: base: log: Remove `LogInvalid` check","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 19, 2026 at 12:31:02PM +0100, Barnabás Pőcze wrote:\n> A `LogMessage` instance cannot be moved or copied, so a severity of\n> `LogInvalid` is only possible if the message was constructed with that\n> log level explicitly. However, being a completely internal type, this\n> does not occur. So remove the check. And even if it does, it's probably\n> still better to print the message than to drop it silently.\n\nGood points.\n\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/base/log.cpp | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index da45b0d65..7d308afae 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -857,10 +857,6 @@ LogMessage::LogMessage(const char *fileName, unsigned int line,\n> \n> LogMessage::~LogMessage()\n> {\n> -\t/* Don't print anything if we have been moved to another LogMessage. */\n> -\tif (severity_ == LogInvalid)\n> -\t\treturn;\n> -\n> \tLogger *logger = Logger::instance();\n> \tif (!logger)\n> \t\treturn;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8244BC3220\n\tfor ;\n\tMon, 19 Jan 2026 17:42:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4ABD961FC6;\n\tMon, 19 Jan 2026 18:42:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CCAD606D5\n\tfor ;\n\tMon, 19 Jan 2026 18:42:02 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8903BC1;\n\tMon, 19 Jan 2026 18:41:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r5lOVsNZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768844491;\n\tbh=BhEYXBLyYio44CFoY+hDb9a7kHMQImO5OLPpsIH4Wi0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r5lOVsNZ0U9xnzcA3GPW7KunCCX4kcHLieleJND55SPUmvY+RfjbrJ4XF1eDwbNIw\n\txk09Eb8/2ywW5BiveFUVsiq4eZR0xElUAS/Kl4E+etgFAaz9fckBAe228e+adOqXnm\n\tjYWAxbCxreEd6fyuXJFPHG5UC/vhVPnxyfNZkGfg=","Date":"Mon, 19 Jan 2026 19:41:39 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 4/5] libcamera: base: log: Remove `LogInvalid` check","Message-ID":"<20260119174139.GG26642@pendragon.ideasonboard.com>","References":"<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>\n\t<20260119113104.3560802-5-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260119113104.3560802-5-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]