[{"id":37733,"web_url":"https://patchwork.libcamera.org/comment/37733/","msgid":"<176882713779.3486172.17136243494737654290@ping.linuxembedded.co.uk>","date":"2026-01-19T12:52:17","subject":"Re: [PATCH v2 3/5] libcamera: base: log: Do not check severity\n\tbefore printing","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-01-19 11:31:01)\n> Now that the severity of the log message and the category is compared in\n> the expansion of the `LOG()` macro, there is no need to do it again in the\n> destructor.\n> \n> Signed-off-by: Barnabás Pőcze \nReviewed-by: Kieran Bingham \n> ---\n> src/libcamera/base/log.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index 6e6d2887c..da45b0d65 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -867,8 +867,7 @@ LogMessage::~LogMessage()\n> \n> msgStream_ << std::endl;\n> \n> - if (severity_ >= category_.severity())\n> - logger->write(*this);\n> + logger->write(*this);\n> \n> if (severity_ == LogSeverity::LogFatal) {\n> logger->backtrace();\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8070EBDCBF\n\tfor ;\n\tMon, 19 Jan 2026 12:52:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4149E61FBC;\n\tMon, 19 Jan 2026 13:52:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C71B5606D5\n\tfor ;\n\tMon, 19 Jan 2026 13:52:20 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7045DBE1;\n\tMon, 19 Jan 2026 13:51:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iglJcuFi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768827110;\n\tbh=pYRdqJo3uaH+CxRDrHOmgn9xFHZUcxcDIvat/Hg30oY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=iglJcuFiZTqQ5gZZTJYOY0WYVhEbdRCRpPM403hpzlelptT4ESr5ForYGijg6Jn/i\n\tT9BExoSiLdPxOGYASz4BxVwIl+A6FmVXyPa+D9yUk2GCCE3tKeFLaI1q6HcpmJFBif\n\trYEc6bOldAlNvsdYsAKGefRYDkAu4qcFkGf645pQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260119113104.3560802-4-barnabas.pocze@ideasonboard.com>","References":"<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>\n\t<20260119113104.3560802-4-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v2 3/5] libcamera: base: log: Do not check severity\n\tbefore printing","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 19 Jan 2026 12:52:17 +0000","Message-ID":"<176882713779.3486172.17136243494737654290@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37747,"web_url":"https://patchwork.libcamera.org/comment/37747/","msgid":"<20260119174039.GF26642@pendragon.ideasonboard.com>","date":"2026-01-19T17:40:39","subject":"Re: [PATCH v2 3/5] libcamera: base: log: Do not check severity\n\tbefore printing","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jan 19, 2026 at 12:31:01PM +0100, Barnabás Pőcze wrote:\n> Now that the severity of the log message and the category is compared in\n> the expansion of the `LOG()` macro, there is no need to do it again in the\n> destructor.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/base/log.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index 6e6d2887c..da45b0d65 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -867,8 +867,7 @@ LogMessage::~LogMessage()\n> \n> \tmsgStream_ << std::endl;\n> \n> -\tif (severity_ >= category_.severity())\n> -\t\tlogger->write(*this);\n> +\tlogger->write(*this);\n> \n> \tif (severity_ == LogSeverity::LogFatal) {\n> \t\tlogger->backtrace();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E73E8C3220\n\tfor ;\n\tMon, 19 Jan 2026 17:41:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95BFC61FC8;\n\tMon, 19 Jan 2026 18:41:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B4F0761FB9\n\tfor ;\n\tMon, 19 Jan 2026 18:41:01 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 1D6A2C1;\n\tMon, 19 Jan 2026 18:40:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eyVpgW1l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768844431;\n\tbh=TZohEw8ZXPLfbcCO4GGwQyZkEnwljqrfo5iZ4w+uw/o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eyVpgW1lmz+L8KnHDHDY61IBRH/Xi7iTWoc4fN4FrP5yNbT9YeqiVXCeqHM6ZJSgJ\n\tkj/WmMU6LExdB2dS5UaNTomjDE8mUkp4x8le1Q+mkCPzesDZT4mjoqjJMskAJqVA/a\n\twnCcyAxX3gJjMALyLJPhRpW8Iw6lPGZ90G79m9u0=","Date":"Mon, 19 Jan 2026 19:40:39 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 3/5] libcamera: base: log: Do not check severity\n\tbefore printing","Message-ID":"<20260119174039.GF26642@pendragon.ideasonboard.com>","References":"<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>\n\t<20260119113104.3560802-4-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260119113104.3560802-4-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]