{"id":25848,"url":"https://patchwork.libcamera.org/api/patches/25848/?format=json","web_url":"https://patchwork.libcamera.org/patch/25848/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260119113104.3560802-4-barnabas.pocze@ideasonboard.com>","date":"2026-01-19T11:31:01","name":"[v2,3/5] libcamera: base: log: Do not check severity before printing","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"47d6b3cc76b4417c7aff7e5ba936fd4364ec8b02","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25848/mbox/","series":[{"id":5716,"url":"https://patchwork.libcamera.org/api/series/5716/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5716","date":"2026-01-19T11:30:58","name":"libcamera: base: log: Do not instantiate disabled `LogMessage`s","version":2,"mbox":"https://patchwork.libcamera.org/series/5716/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25848/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25848/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AC47BDCBF\n\tfor ;\n\tMon, 19 Jan 2026 11:31:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 117D261FD0;\n\tMon, 19 Jan 2026 12:31:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EBFC61FBC\n\tfor ;\n\tMon, 19 Jan 2026 12:31:08 +0100 (CET)","from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3DF52D9\n\tfor ;\n\tMon, 19 Jan 2026 12:30:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LhgDa2Rl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768822238;\n\tbh=dz+PKmSwfBLDv660zSPoeRZk0ATInnynAE8KmASQLBs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=LhgDa2RlNzVnI2ZDcYn4BBDpnYvDFguxA2JI71L1WHWFu5RVUIMvnGnZGb5IH1fZP\n\t9qiGN42qPjAFg86z8/vL5E5TJRrpEzUIIb73VxO+pbjl8SjXBG/0mynML3rhwYawui\n\th/YnQc1xWWYNgsr+yH3PPP9NS1Nnjol3D2pK2iMo=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v2 3/5] libcamera: base: log: Do not check severity before\n\tprinting","Date":"Mon, 19 Jan 2026 12:31:01 +0100","Message-ID":"<20260119113104.3560802-4-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>","References":"<20260119113104.3560802-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that the severity of the log message and the category is compared in\nthe expansion of the `LOG()` macro, there is no need to do it again in the\ndestructor.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/base/log.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 6e6d2887c..da45b0d65 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -867,8 +867,7 @@ LogMessage::~LogMessage()\n \n \tmsgStream_ << std::endl;\n \n-\tif (severity_ >= category_.severity())\n-\t\tlogger->write(*this);\n+\tlogger->write(*this);\n \n \tif (severity_ == LogSeverity::LogFatal) {\n \t\tlogger->backtrace();\n","prefixes":["v2","3/5"]}