[{"id":37689,"web_url":"https://patchwork.libcamera.org/comment/37689/","msgid":"<176856269215.3486172.3145900970613662643@ping.linuxembedded.co.uk>","date":"2026-01-16T11:24:52","subject":"Re: [PATCH v1 1/3] libcamera: base: utils: Simplify `operator<<` for\n\t`Duration`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-01-15 11:16:28)\n> There is no real need for a function template. It is not defined in a\n> header file, so it has limited availability, and there exists only a\n> single instantion.\n> \n> So convert it to use `std::ostream` directly, like most `operator<<`\n> in the code base.\n> \n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/base/utils.h | 4 +---\n> src/libcamera/base/utils.cpp | 11 ++---------\n> 2 files changed, 3 insertions(+), 12 deletions(-)\n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 0b7407f77..6ce1ace43 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -426,9 +426,7 @@ scope_exit(EF) -> scope_exit;\n> } /* namespace utils */\n> \n> #ifndef __DOXYGEN__\n> -template\n> -std::basic_ostream &operator<<(std::basic_ostream &os,\n> - const utils::Duration &d);\n> +std::ostream &operator<<(std::ostream &os, const utils::Duration &d);\n> #endif\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\n> index 65d9181c9..2c3f2b7e6 100644\n> --- a/src/libcamera/base/utils.cpp\n> +++ b/src/libcamera/base/utils.cpp\n> @@ -658,11 +658,9 @@ void ScopeExitActions::release()\n> } /* namespace utils */\n> \n> #ifndef __DOXYGEN__\n> -template\n> -std::basic_ostream &operator<<(std::basic_ostream &os,\n> - const utils::Duration &d)\n> +std::ostream &operator<<(std::ostream &os, const utils::Duration &d)\n> {\n> - std::basic_ostringstream s;\n> + std::ostringstream s;\n> \n> s.flags(os.flags());\n> s.imbue(os.getloc());\n> @@ -671,11 +669,6 @@ std::basic_ostream &operator<<(std::basic_ostream\n> s << d.get() << \"us\";\n> return os << s.str();\n> }\n> -\n> -template\n> -std::basic_ostream> &\n> -operator<< >(std::basic_ostream> &os,\n> - const utils::Duration &d);\n> #endif\n> \n> } /* namespace libcamera */\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8064EC3226\n\tfor ;\n\tFri, 16 Jan 2026 11:24:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C73FC61FA3;\n\tFri, 16 Jan 2026 12:24:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC6D2615B2\n\tfor ;\n\tFri, 16 Jan 2026 12:24:55 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C8723D7;\n\tFri, 16 Jan 2026 12:24:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KvEVCKKP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768562667;\n\tbh=xucMtGVRlc+a1htw0CWPRJbRe8GE2nawDC07awvTSyo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=KvEVCKKPF3dvO5sKGSUUPxJVC2PKVuOsJtPvg1HZvcANCG4lpwqAZaKzeHpgqLC0y\n\tbx0KxAmkOZpobYZSrhW5eO6ZlMDDPQa5qRKEq4G73yQGpz7MMvzBwSh3XBVXbZ7NN1\n\tKTSb9WxB+vNpRt912ZC/MKCpqycDj9dSdmrkuIsI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260115111630.1892890-1-barnabas.pocze@ideasonboard.com>","References":"<20260115111630.1892890-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [PATCH v1 1/3] libcamera: base: utils: Simplify `operator<<` for\n\t`Duration`","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 16 Jan 2026 11:24:52 +0000","Message-ID":"<176856269215.3486172.3145900970613662643@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37830,"web_url":"https://patchwork.libcamera.org/comment/37830/","msgid":"<20260122003459.GI21091@killaraus>","date":"2026-01-22T00:34:59","subject":"Re: [PATCH v1 1/3] libcamera: base: utils: Simplify `operator<<` for\n\t`Duration`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jan 15, 2026 at 12:16:28PM +0100, Barnabás Pőcze wrote:\n> There is no real need for a function template. It is not defined in a\n> header file, so it has limited availability, and there exists only a\n> single instantion.\n\nAgreed. It's an internal function, not part of the public API, so the\nlikelihood of needing to support something else that std::ostream is\npretty much null.\n\nReviewed-by: Laurent Pinchart \n\n> So convert it to use `std::ostream` directly, like most `operator<<`\n> in the code base.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/base/utils.h | 4 +---\n> src/libcamera/base/utils.cpp | 11 ++---------\n> 2 files changed, 3 insertions(+), 12 deletions(-)\n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 0b7407f77..6ce1ace43 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -426,9 +426,7 @@ scope_exit(EF) -> scope_exit;\n> } /* namespace utils */\n> \n> #ifndef __DOXYGEN__\n> -template\n> -std::basic_ostream &operator<<(std::basic_ostream &os,\n> -\t\t\t\t\t const utils::Duration &d);\n> +std::ostream &operator<<(std::ostream &os, const utils::Duration &d);\n> #endif\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\n> index 65d9181c9..2c3f2b7e6 100644\n> --- a/src/libcamera/base/utils.cpp\n> +++ b/src/libcamera/base/utils.cpp\n> @@ -658,11 +658,9 @@ void ScopeExitActions::release()\n> } /* namespace utils */\n> \n> #ifndef __DOXYGEN__\n> -template\n> -std::basic_ostream &operator<<(std::basic_ostream &os,\n> -\t\t\t\t\t const utils::Duration &d)\n> +std::ostream &operator<<(std::ostream &os, const utils::Duration &d)\n> {\n> -\tstd::basic_ostringstream s;\n> +\tstd::ostringstream s;\n> \n> \ts.flags(os.flags());\n> \ts.imbue(os.getloc());\n> @@ -671,11 +669,6 @@ std::basic_ostream &operator<<(std::basic_ostream\n> \ts << d.get() << \"us\";\n> \treturn os << s.str();\n> }\n> -\n> -template\n> -std::basic_ostream> &\n> -operator<< >(std::basic_ostream> &os,\n> -\t\t\t\t\t const utils::Duration &d);\n> #endif\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87A23C3220\n\tfor ;\n\tThu, 22 Jan 2026 00:35:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9ADD861FC4;\n\tThu, 22 Jan 2026 01:35:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CF1261A35\n\tfor ;\n\tThu, 22 Jan 2026 01:35:01 +0100 (CET)","from pendragon.ideasonboard.com\n\t(2001-14ba-703d-e500--ff4.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::ff4])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BA3F4324;\n\tThu, 22 Jan 2026 01:34:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nyHuq266\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769042068;\n\tbh=4xo6NOHMuzMAx/1uTZ7nHrPCTuRfsJ7q9PG9tdoeTlA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nyHuq266aMxX9P0oilfGaRyQw0W7skXvxNWOE1s5x70HEeN+a4J+ei3xe7tswHdKr\n\tUT3Yv0qpkNzL/LOeeM94wUoKg0Xsf3vLU11YJjma8MNIWmMS1YESX/nrVPpisqW7Ad\n\tZ8bVu0Q2PvYi7OsJYzdV/gaA78Nqb2EO9gMYK4CM=","Date":"Thu, 22 Jan 2026 02:34:59 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/3] libcamera: base: utils: Simplify `operator<<` for\n\t`Duration`","Message-ID":"<20260122003459.GI21091@killaraus>","References":"<20260115111630.1892890-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260115111630.1892890-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]