{"id":25813,"url":"https://patchwork.libcamera.org/api/patches/25813/?format=json","web_url":"https://patchwork.libcamera.org/patch/25813/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260115111630.1892890-1-barnabas.pocze@ideasonboard.com>","date":"2026-01-15T11:16:28","name":"[v1,1/3] libcamera: base: utils: Simplify `operator<<` for `Duration`","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"629192538205dc3b5cad049b500a7d8211c18684","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25813/mbox/","series":[{"id":5709,"url":"https://patchwork.libcamera.org/api/series/5709/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5709","date":"2026-01-15T11:16:28","name":"[v1,1/3] libcamera: base: utils: Simplify `operator<<` for `Duration`","version":1,"mbox":"https://patchwork.libcamera.org/series/5709/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25813/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25813/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 037BABDCBF\n\tfor ;\n\tThu, 15 Jan 2026 11:16:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7B3C61FC7;\n\tThu, 15 Jan 2026 12:16:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCEDF61F84\n\tfor ;\n\tThu, 15 Jan 2026 12:16:32 +0100 (CET)","from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 754B84D3\n\tfor ;\n\tThu, 15 Jan 2026 12:16:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v27YSQ6k\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768475765;\n\tbh=aFssBQ4ulwikszOYeI0WUH0iFsVXXcpXGOTy9DPams8=;\n\th=From:To:Subject:Date:From;\n\tb=v27YSQ6kBXzp0VFdCcC2S21ElcZIkBT2yDxkwYhaFG9IQ0QLpI1qR4Dlndv+kFA9O\n\tgIU8I+cnhYG9P/N4hGGEcZgmE+Hwl5ITy6t0KjiS5ZyUEZHMt3ws8ZHf/XDh4TAm1Q\n\tAEZGR2fQs3A3D/BckOe3RjxSANf0LsQviNMwWI+o=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1 1/3] libcamera: base: utils: Simplify `operator<<` for\n\t`Duration`","Date":"Thu, 15 Jan 2026 12:16:28 +0100","Message-ID":"<20260115111630.1892890-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no real need for a function template. It is not defined in a\nheader file, so it has limited availability, and there exists only a\nsingle instantion.\n\nSo convert it to use `std::ostream` directly, like most `operator<<`\nin the code base.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/base/utils.h | 4 +---\n src/libcamera/base/utils.cpp | 11 ++---------\n 2 files changed, 3 insertions(+), 12 deletions(-)","diff":"diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\nindex 0b7407f77..6ce1ace43 100644\n--- a/include/libcamera/base/utils.h\n+++ b/include/libcamera/base/utils.h\n@@ -426,9 +426,7 @@ scope_exit(EF) -> scope_exit;\n } /* namespace utils */\n \n #ifndef __DOXYGEN__\n-template\n-std::basic_ostream &operator<<(std::basic_ostream &os,\n-\t\t\t\t\t const utils::Duration &d);\n+std::ostream &operator<<(std::ostream &os, const utils::Duration &d);\n #endif\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\nindex 65d9181c9..2c3f2b7e6 100644\n--- a/src/libcamera/base/utils.cpp\n+++ b/src/libcamera/base/utils.cpp\n@@ -658,11 +658,9 @@ void ScopeExitActions::release()\n } /* namespace utils */\n \n #ifndef __DOXYGEN__\n-template\n-std::basic_ostream &operator<<(std::basic_ostream &os,\n-\t\t\t\t\t const utils::Duration &d)\n+std::ostream &operator<<(std::ostream &os, const utils::Duration &d)\n {\n-\tstd::basic_ostringstream s;\n+\tstd::ostringstream s;\n \n \ts.flags(os.flags());\n \ts.imbue(os.getloc());\n@@ -671,11 +669,6 @@ std::basic_ostream &operator<<(std::basic_ostream\n \ts << d.get() << \"us\";\n \treturn os << s.str();\n }\n-\n-template\n-std::basic_ostream> &\n-operator<< >(std::basic_ostream> &os,\n-\t\t\t\t\t const utils::Duration &d);\n #endif\n \n } /* namespace libcamera */\n","prefixes":["v1","1/3"]}