{"id":25807,"url":"https://patchwork.libcamera.org/api/patches/25807/?format=json","web_url":"https://patchwork.libcamera.org/patch/25807/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260114173918.1744023-12-kieran.bingham@ideasonboard.com>","date":"2026-01-14T17:39:11","name":"[v5,11/16] ipa: mali-c55: Reduce AWB calculations to float precision","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"dad72009d7a127545c0a6b7ff4f2c8dab5dcac4f","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25807/mbox/","series":[{"id":5708,"url":"https://patchwork.libcamera.org/api/series/5708/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5708","date":"2026-01-14T17:39:00","name":"libipa: Introduce a Quantized type","version":5,"mbox":"https://patchwork.libcamera.org/series/5708/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25807/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25807/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80337C3274\n\tfor ;\n\tWed, 14 Jan 2026 17:39:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E618C61FC7;\n\tWed, 14 Jan 2026 18:39:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA6FF61FC9\n\tfor ;\n\tWed, 14 Jan 2026 18:39:25 +0100 (CET)","from Monstersaurus.infra.iob\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCBD155C;\n\tWed, 14 Jan 2026 18:38:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SjL7wX5D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768412338;\n\tbh=jUXrNpD5O+E67bCsFbHO1Y9uWRmV5hk6P4zDQcH5uHo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SjL7wX5DdvRR/lS73h3cnMWHa0SS/4iV5AwqQuOjEw7VKdTaOeFDnkEGfPQlZjFSk\n\tOqfZ6knHzirOGTqhC914KKs08hHldwd9fLLrPnff+a9MPaU/KNa+NkeQDQQumvQGVJ\n\tyroVsiJZSiGmaLywX8WCUfLiaq80OdlDwqyeV+hw=","From":"Kieran Bingham ","To":"libcamera devel ","Cc":"Kieran Bingham ","Subject":"[PATCH v5 11/16] ipa: mali-c55: Reduce AWB calculations to float\n\tprecision","Date":"Wed, 14 Jan 2026 17:39:11 +0000","Message-ID":"<20260114173918.1744023-12-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260114173918.1744023-1-kieran.bingham@ideasonboard.com>","References":"<20260114173918.1744023-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The AWB calculations are determined using double precision, and then\nwill be soon stored in a quantized float.\n\nUse float types for the intermediate types after the sums have been\nconverted to an average to remove static cast assignments.\n\nSigned-off-by: Kieran Bingham \n\n---\nv5:\n - New in v5\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/mali-c55/algorithms/awb.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/mali-c55/algorithms/awb.cpp b/src/ipa/mali-c55/algorithms/awb.cpp\nindex 964e810882a9..b179dd7f0c1c 100644\n--- a/src/ipa/mali-c55/algorithms/awb.cpp\n+++ b/src/ipa/mali-c55/algorithms/awb.cpp\n@@ -159,7 +159,7 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * Sometimes the first frame's statistics have no valid pixels, in which\n \t * case we'll just assume a grey world until they say otherwise.\n \t */\n-\tdouble rgAvg, bgAvg;\n+\tfloat rgAvg, bgAvg;\n \tif (!counted_zones) {\n \t\trgAvg = 1.0;\n \t\tbgAvg = 1.0;\n@@ -174,15 +174,15 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * figure by the gains that were applied when the statistics for this\n \t * frame were generated.\n \t */\n-\tdouble rRatio = rgAvg / frameContext.awb.rGain;\n-\tdouble bRatio = bgAvg / frameContext.awb.bGain;\n+\tfloat rRatio = rgAvg / frameContext.awb.rGain;\n+\tfloat bRatio = bgAvg / frameContext.awb.bGain;\n \n \t/*\n \t * And then we can simply invert the ratio to find the gain we should\n \t * apply.\n \t */\n-\tdouble rGain = 1 / rRatio;\n-\tdouble bGain = 1 / bRatio;\n+\tfloat rGain = 1 / rRatio;\n+\tfloat bGain = 1 / bRatio;\n \n \t/*\n \t * Running at full speed, this algorithm results in oscillations in the\n@@ -190,7 +190,7 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * changes in gain, unless we're in the startup phase in which case we\n \t * want to fix the miscolouring as quickly as possible.\n \t */\n-\tdouble speed = frame < kNumStartupFrames ? 1.0 : 0.2;\n+\tfloat speed = frame < kNumStartupFrames ? 1.0 : 0.2;\n \trGain = speed * rGain + context.activeState.awb.rGain * (1.0 - speed);\n \tbGain = speed * bGain + context.activeState.awb.bGain * (1.0 - speed);\n \n","prefixes":["v5","11/16"]}