[{"id":37675,"web_url":"https://patchwork.libcamera.org/comment/37675/","msgid":"<8cb8ef07-96be-4ddf-91fb-6ab2a6da83c7@ideasonboard.com>","date":"2026-01-15T14:12:37","subject":"Re: [PATCH v5 10/16] ipa: rkisp1: ccm: Use Q<4, 7> format directly","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 14. 18:39 keltezéssel, Kieran Bingham írta:\n> Replace the legacy call to floatingToFixedPoint with the new FixedPoint\n> quantizer to explicitly describe the type used by the RKISP1 Colour\n> Correction Matrix.\n> \n> Reviewed-by: Isaac Scott \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> v5:\n> - Use Q<4, 7>\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/rkisp1/algorithms/ccm.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index de2b6fe775aa..466d7a116eea 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -117,8 +117,7 @@ void Ccm::setParameters(struct rkisp1_cif_isp_ctk_config &config,\n> \t */\n> \tfor (unsigned int i = 0; i < 3; i++) {\n> \t\tfor (unsigned int j = 0; j < 3; j++)\n> -\t\t\tconfig.coeff[i][j] =\n> -\t\t\t\tfloatingToFixedPoint<4, 7, uint16_t, double>(matrix[i][j]);\n> +\t\t\tconfig.coeff[i][j] = Q<4, 7>(matrix[i][j]).quantized();\n\nLooks ok to me.\n\nReviewed-by: Barnabás Pőcze \n\n\n> \t}\n> \n> \tfor (unsigned int i = 0; i < 3; i++)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 217ACBDCBF\n\tfor ;\n\tThu, 15 Jan 2026 14:12:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC0E461FBC;\n\tThu, 15 Jan 2026 15:12:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4AA961F84\n\tfor ;\n\tThu, 15 Jan 2026 15:12:40 +0100 (CET)","from [192.168.33.20] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E41224A;\n\tThu, 15 Jan 2026 15:12:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HgUXbi3I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768486333;\n\tbh=mpc8qBwm0HFybSosSmYRqpipHqCkzPyTIQCZnREc3YA=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=HgUXbi3IWPg6UQN5f9h5fssCkvfbN0+OBidS+TKoG8cw9uMXJWcor5eMBjtW+45dL\n\tfRJTw+84RaviT+kg4Xuo/E7j1WuWgmKrJL7ye3FfTUjHF5LyB3PNPMldj6eIscjh/a\n\tHvWrnYq8m8FI+vwEsIpvsD9IQ7HkvYo3we+0LFD4=","Message-ID":"<8cb8ef07-96be-4ddf-91fb-6ab2a6da83c7@ideasonboard.com>","Date":"Thu, 15 Jan 2026 15:12:37 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 10/16] ipa: rkisp1: ccm: Use Q<4, 7> format directly","To":"Kieran Bingham ,\n\tlibcamera devel ","Cc":"Isaac Scott ","References":"<20260114173918.1744023-1-kieran.bingham@ideasonboard.com>\n\t<20260114173918.1744023-11-kieran.bingham@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260114173918.1744023-11-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]