[{"id":385,"web_url":"https://patchwork.libcamera.org/comment/385/","msgid":"<20190117204203.GC23244@pendragon.ideasonboard.com>","date":"2019-01-17T20:42:03","subject":"Re: [libcamera-devel] [PATCH 2/5] test: timer: Add a 32 bit\n\twraparound test","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Jan 17, 2019 at 08:20:40PM +0000, Kieran Bingham wrote:\n> Add a test which catches a timer running longer than the nanosecond\n> resolution of 32 bits.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/timer.cpp | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n> \n> diff --git a/test/timer.cpp b/test/timer.cpp\n> index 3d1a78ac2768..c6a6ede73486 100644\n> --- a/test/timer.cpp\n> +++ b/test/timer.cpp\n> @@ -81,6 +81,19 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\t/*\n> +\t\t * 32 bit wrap test\n> +\t\t * Nanosecond resolution in a 32 bit value wraps at 4.294967\n> +\t\t * seconds (0xFFFFFFFF / 1000000)\n> +\t\t */\n> +\t\ttimer.start(4295);\n> +\t\tdispatcher->processEvents();\n> +\n> +\t\tif (timer.isRunning() || timer.jitter() > 50) {\n> +\t\t\tcout << \"Timer expiration test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\t/* Timer restart. */\n> \t\ttimer.start(500);\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9295660B2D\n\tfor ;\n\tThu, 17 Jan 2019 21:42:03 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F38D553E;\n\tThu, 17 Jan 2019 21:42:02 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547757723;\n\tbh=wKmmafWPYQ+Jjdhx/FrMIRIcXLC/seMYpRPYZQPY2b0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M2OgsgwTvcMYDVDbl+vJ+9j+LolVYJeOeCzhTP6yhbavg+ZJieDkuSGBZqs0b8CPc\n\tln67Cy+IEEZOAG4n6EdDvnyQb7gU1BJ44ISKYd9Iki0w4qZiGTyKdjeSSPfErWvzAq\n\tN/xwQWRxGqEgd2lYxOfFphAKG/2HnnkVdzENtALs=","Date":"Thu, 17 Jan 2019 22:42:03 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190117204203.GC23244@pendragon.ideasonboard.com>","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>\n\t<20190117202043.21420-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190117202043.21420-3-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/5] test: timer: Add a 32 bit\n\twraparound test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 20:42:03 -0000"}},{"id":393,"web_url":"https://patchwork.libcamera.org/comment/393/","msgid":"<20190117220051.GM6484@bigcity.dyn.berto.se>","date":"2019-01-17T22:00:51","subject":"Re: [libcamera-devel] [PATCH 2/5] test: timer: Add a 32 bit\n\twraparound test","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your patch.\n\nOn 2019-01-17 20:20:40 +0000, Kieran Bingham wrote:\n> Add a test which catches a timer running longer than the nanosecond\n> resolution of 32 bits.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/timer.cpp | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n> \n> diff --git a/test/timer.cpp b/test/timer.cpp\n> index 3d1a78ac2768..c6a6ede73486 100644\n> --- a/test/timer.cpp\n> +++ b/test/timer.cpp\n> @@ -81,6 +81,19 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\t/*\n> +\t\t * 32 bit wrap test\n> +\t\t * Nanosecond resolution in a 32 bit value wraps at 4.294967\n> +\t\t * seconds (0xFFFFFFFF / 1000000)\n> +\t\t */\n> +\t\ttimer.start(4295);\n> +\t\tdispatcher->processEvents();\n> +\n> +\t\tif (timer.isRunning() || timer.jitter() > 50) {\n> +\t\t\tcout << \"Timer expiration test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\t/* Timer restart. */\n> \t\ttimer.start(500);\n> \n> -- \n> 2.17.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C14E60B2D\n\tfor ;\n\tThu, 17 Jan 2019 23:00:53 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id k19-v6so9884842lji.11\n\tfor ;\n\tThu, 17 Jan 2019 14:00:53 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\te14-v6sm431170ljl.43.2019.01.17.14.00.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 17 Jan 2019 14:00:51 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=2ujXF6hXbx2UJeFEG/diaWrsWNmAz2UqiC3Old5Rei0=;\n\tb=ClhKUVRiZ3jyYmS65Zz7/4i+FkDi1ttfdkZy+yMOuR96PzaVOS5kH5Bsu3Tl8CsHeq\n\teLQWzlNlJsODLNQ8oM3cG3d/gBCXquRhtxYrtNtgUcKrdmQVbo1OEfJQrRAnl6t8guUl\n\tKfR0XveB6u6mw1aqaNPIXBQHPNwm3cJaRHPOReO+Dj1AprAa8gelIxu7BVubyC0J3hnL\n\tYzgWxZm/YH/0teFEJae+CVm4fBwS7qHgubtek7DfX9H0VVZNcBGfoMBRoVVzEn9sg+T1\n\tkB4pEyNRGLzHGrnsbfEto4FND+gEQo0x7KOgheqdgeBvvNFXGFKtkcj8PuVUW4dgo0ZV\n\tRW4g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=2ujXF6hXbx2UJeFEG/diaWrsWNmAz2UqiC3Old5Rei0=;\n\tb=DXsc+RgdmUgDqgQOmPwA95DL2WhexGgBOuz0qCCfxYfrgGWjtV+YaQFhljbAxE+D1I\n\tVC7pmTRRf6ylLU8HoZcvpDh4GTxW4iMQPMqhDZOLGYKOiDDn3xQcxIJL6sguOexTFNQz\n\tFvyKX5NxPcOiOFPC1P0dHk8GGyssgdkWlI9p1mbGvFp5JRkgOMOm/Un0h3AXjNx7od05\n\tQ6viKGfMxUwVIbzACnThzOKDRcWMFrDFF2mnGM4cwFuGhamIZ/dY3j2FpKxBKh1MvcNg\n\t+YNl0eVxLNYsDesp+0qj6LprUNNknzQpY22RQ0dCoPqz1DCA0KZqmD981mZgsxo4ksGZ\n\tHglQ==","X-Gm-Message-State":"AJcUukexqpKiFRk8r93YbIeTWGFEbOgWs5p37Rh7u5Yk0tLn/OEC3bC3\n\tpwwGPqU/3ameDGpYQc8Mas5iZA==","X-Google-Smtp-Source":"ALg8bN5ryNN9pYyBMjT/VxQ8mAeNvGCkp4sYvYZ1YoG57MF5G4j5Rzku6b1kQY5FIGOQ76J3nRBBxQ==","X-Received":"by 2002:a2e:8596:: with SMTP id\n\tb22-v6mr10736081lji.122.1547762452520; \n\tThu, 17 Jan 2019 14:00:52 -0800 (PST)","Date":"Thu, 17 Jan 2019 23:00:51 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190117220051.GM6484@bigcity.dyn.berto.se>","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>\n\t<20190117202043.21420-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190117202043.21420-3-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/5] test: timer: Add a 32 bit\n\twraparound test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 22:00:53 -0000"}}]