{"id":25785,"url":"https://patchwork.libcamera.org/api/patches/25785/?format=json","web_url":"https://patchwork.libcamera.org/patch/25785/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260114-sklug-lsc-resampling-v2-dev-v3-5-80cd24f4dd61@ideasonboard.com>","date":"2026-01-14T11:57:58","name":"[v3,05/15] ipa: rkisp1: lsc: Rename res to ret","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c6138798ee3dd37481ae7118fc0d8d7d79808cb2","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25785/mbox/","series":[{"id":5707,"url":"https://patchwork.libcamera.org/api/series/5707/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5707","date":"2026-01-14T11:57:53","name":"Add resampling support for polynomial LSC data","version":3,"mbox":"https://patchwork.libcamera.org/series/5707/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25785/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25785/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC5B4C3226\n\tfor ;\n\tWed, 14 Jan 2026 11:58:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92E8B61FB9;\n\tWed, 14 Jan 2026 12:58:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A08CA61FB9\n\tfor ;\n\tWed, 14 Jan 2026 12:58:14 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b781:dff2:957:7831])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id EF84B6A8;\n\tWed, 14 Jan 2026 12:57:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q2yPPNrj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768391868;\n\tbh=Q66L+qBP3d9HUh5DEB9HQOwvALS5AmnZ9rrQY4rui1k=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=q2yPPNrjn+F4hL6HrSlcUs2kWakTLvlR+5Jcyy3vmvsN1Dsq94+3xIka7OwObbAch\n\tH1Iz4PXbGCgex9yVyyW++ZPA6lvudag503AgXo7HuNWn2HNbLKya29yUPD10d/Yj5y\n\tWnOGyCiK+TnnSDgdLPagjjCq4NW7mASTcmKzMlQk=","From":"Stefan Klug ","Date":"Wed, 14 Jan 2026 12:57:58 +0100","Subject":"[PATCH v3 05/15] ipa: rkisp1: lsc: Rename res to ret","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260114-sklug-lsc-resampling-v2-dev-v3-5-80cd24f4dd61@ideasonboard.com>","References":"<20260114-sklug-lsc-resampling-v2-dev-v3-0-80cd24f4dd61@ideasonboard.com>","In-Reply-To":"<20260114-sklug-lsc-resampling-v2-dev-v3-0-80cd24f4dd61@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug , =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= ,\n\tRui Wang ","X-Mailer":"b4 0.14.2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename res to ret as that is used in libcamera for return codes.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Barnabás Pőcze \nReviewed-by: Rui Wang \n\n---\n\nChanges in v2:\n- Restored old variable order\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex bb58386ae646ad6089322ba63d2a9e89664884d2..68e262a2b057d12a9019a6a92c1b300272b04c4d 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -321,27 +321,28 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n \t}\n \n \tstd::map lscData;\n-\tint res = 0;\n+\tint ret = 0;\n+\n \tstd::string type = tuningData[\"type\"].get(\"table\");\n \tif (type == \"table\") {\n \t\tLOG(RkISP1Lsc, Debug) << \"Loading tabular LSC data.\";\n \t\tauto loader = LscTableLoader();\n-\t\tres = loader.parseLscData(yamlSets, lscData);\n+\t\tret = loader.parseLscData(yamlSets, lscData);\n \t} else if (type == \"polynomial\") {\n \t\tLOG(RkISP1Lsc, Debug) << \"Loading polynomial LSC data.\";\n \t\tauto loader = LscPolynomialLoader(context.sensorInfo.activeAreaSize,\n \t\t\t\t\t\t context.sensorInfo.analogCrop,\n \t\t\t\t\t\t xSize_,\n \t\t\t\t\t\t ySize_);\n-\t\tres = loader.parseLscData(yamlSets, lscData);\n+\t\tret = loader.parseLscData(yamlSets, lscData);\n \t} else {\n \t\tLOG(RkISP1Lsc, Error) << \"Unsupported LSC data type '\"\n \t\t\t\t << type << \"'\";\n-\t\tres = -EINVAL;\n+\t\tret = -EINVAL;\n \t}\n \n-\tif (res)\n-\t\treturn res;\n+\tif (ret)\n+\t\treturn ret;\n \n \tsets_.setData(std::move(lscData));\n \n","prefixes":["v3","05/15"]}