[{"id":37817,"web_url":"https://patchwork.libcamera.org/comment/37817/","msgid":"","date":"2026-01-21T16:40:16","subject":"Re: [PATCH v3 14/14] libcamera: ipa: simple: Disable Ccm algorithm\n\tby default again","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 14. 12:30 keltezéssel, Milan Zamazal írta:\n> The default CCM in uncalibrated.yaml is just an identity transformation\n> and has been enabled by default only to always provide a correction\n> matrix to GPU ISP. It slows down CPU ISP when CCM is not used.\n> \n> Now, when a default correction matrix is always provided to GPU ISP, we\n> can disable the Ccm algorithm in uncalibrated.yaml again. The check for\n> ccmEnabled in GPU ISP is no longer needed and it must be removed in\n> order not to fail when Ccm algorithm is not enabled. ccmEnabled flag is\n> still needed in CPU ISP where the processing differs based on whether\n> CCM is present or not.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n\nSeems fine to me.\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/simple/data/uncalibrated.yaml | 12 ++++++------\n> src/libcamera/software_isp/debayer_egl.cpp | 5 +----\n> 2 files changed, 7 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\n> index c6feda36d..fc90ca526 100644\n> --- a/src/ipa/simple/data/uncalibrated.yaml\n> +++ b/src/ipa/simple/data/uncalibrated.yaml\n> @@ -8,12 +8,12 @@ algorithms:\n> # Color correction matrices can be defined here. The CCM algorithm\n> # has a significant performance impact, and should only be enabled\n> # if tuned.\n> - - Ccm:\n> - ccms:\n> - - ct: 6500\n> - ccm: [ 1, 0, 0,\n> - 0, 1, 0,\n> - 0, 0, 1]\n> + # - Ccm:\n> + # ccms:\n> + # - ct: 6500\n> + # ccm: [ 1, 0, 0,\n> + # 0, 1, 0,\n> + # 0, 0, 1]\n> - Adjust:\n> - Agc:\n> ...\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index ddf03ad4b..b3994c29e 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -288,7 +288,7 @@ unsigned int DebayerEGL::frameSize()\n> \n> int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> \t\t\t const std::vector> &outputCfgs,\n> -\t\t\t bool ccmEnabled)\n> +\t\t\t [[maybe_unused]] bool ccmEnabled)\n> {\n> \tif (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0)\n> \t\treturn -EINVAL;\n> @@ -296,9 +296,6 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n> \tif (stats_->configure(inputCfg) != 0)\n> \t\treturn -EINVAL;\n> \n> -\tif (!ccmEnabled)\n> -\t\treturn -EINVAL;\n> -\n> \tconst Size &stats_pattern_size = stats_->patternSize();\n> \tif (inputConfig_.patternSize.width != stats_pattern_size.width ||\n> \t inputConfig_.patternSize.height != stats_pattern_size.height) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72EE1BDCBF\n\tfor ;\n\tWed, 21 Jan 2026 16:40:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B66DF61FC9;\n\tWed, 21 Jan 2026 17:40:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1894F61F9F\n\tfor ;\n\tWed, 21 Jan 2026 17:40:21 +0100 (CET)","from [192.168.33.24] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5B8D833;\n\tWed, 21 Jan 2026 17:39:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k50AH/C+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769013589;\n\tbh=jUuM+hBpVz1gPanGUP5kOVMfFm6JC8ywDEmtnCB0Vlc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=k50AH/C+OrOT3PxT1iCj+OuZaoVXTrvN03vSfb/53dGDCUbsEi6zzmHFxCnTxKZKr\n\teb99DXkw2X4T6zn1ZDU08+86RVquazpzh8RnaYcZ2ibYh7qoe//FKG8l1ZgGzSFp2A\n\tbMRcZkRktYtpbxs0qNeVDkgbKHmOVSe1Hsept7gk=","Message-ID":"","Date":"Wed, 21 Jan 2026 17:40:16 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 14/14] libcamera: ipa: simple: Disable Ccm algorithm\n\tby default again","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ","References":"<20260114113016.25162-1-mzamazal@redhat.com>\n\t<20260114113016.25162-15-mzamazal@redhat.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260114113016.25162-15-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]