[{"id":37638,"web_url":"https://patchwork.libcamera.org/comment/37638/","msgid":"<6bccb5e6-0e48-4906-8ec4-46c81ddbb911@ideasonboard.com>","date":"2026-01-14T09:35:13","subject":"Re: [PATCH 35/36] pipeline: simple: Rename supported_devices\n\tconfiguration option to devices","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 13. 1:08 keltezéssel, Laurent Pinchart írta:\n> The pipelines.simple.supported_devices configuration entry list\n> per-device options for the simple pipeline handler. Rename\n> \"supported_devices\" to \"devices\" to indicate its role more clearly.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> Documentation/runtime_configuration.rst | 6 +++---\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst\n> index 8c920978648d..19c2309ac94f 100644\n> --- a/Documentation/runtime_configuration.rst\n> +++ b/Documentation/runtime_configuration.rst\n> @@ -43,7 +43,7 @@ file structure:\n> - ... # pipeline name\n> pipelines:\n> simple:\n> - supported_devices:\n> + devices:\n> - driver: # driver name, e.g. `mxc-isi`\n> software_isp: # true/false\n> software_isp:\n> @@ -76,7 +76,7 @@ Configuration file example\n> - simple\n> pipelines:\n> simple:\n> - supported_devices:\n> + devices:\n> - driver: mxc-isi\n> software_isp: true\n> software_isp:\n> @@ -139,7 +139,7 @@ LIBCAMERA__TUNING_FILE\n> \n> Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``\n> \n> -pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp\n> +pipelines.simple.devices.driver, pipelines.simple.devices.software_isp\n> Override whether software ISP is enabled for the given driver.\n> \n> Example `driver` value: ``mxc-isi``\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index bdc87d39ef0b..0ae9e081f01a 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1881,7 +1881,7 @@ bool SimplePipelineHandler::matchDevice(std::shared_ptr media,\n> \tswIspEnabled_ = info.swIspEnabled;\n> \tconst GlobalConfiguration &configuration = cameraManager()->_d()->configuration();\n> \tfor (GlobalConfiguration::Option entry :\n> -\t configuration.configuration()[\"pipelines\"][\"simple\"][\"supported_devices\"]\n> +\t configuration.configuration()[\"pipelines\"][\"simple\"][\"devices\"]\n> \t\t .asList()) {\n> \t\tauto name = entry[\"driver\"].get();\n> \t\tif (name == info.driver) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19AF2BDCBF\n\tfor ;\n\tWed, 14 Jan 2026 09:35:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA9B561FBC;\n\tWed, 14 Jan 2026 10:35:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78D29615B2\n\tfor ;\n\tWed, 14 Jan 2026 10:35:17 +0100 (CET)","from [192.168.33.18] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DFD2E316;\n\tWed, 14 Jan 2026 10:34:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o0SHgni9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768383290;\n\tbh=T8lnyRhdea2ygA2jiAp+IPn6U7OgQkJUnfdDuTXSe2c=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=o0SHgni9JTFOjTu6gRWfHstASwfii7QdDdbxfuGF2lGrK0WWmJi3XkUfNZ5AASDoz\n\tgscmywJUL+jvdGMBs77mSupa0lxqHR9Qhqo+4gmF23jv9zxGMMNgodEbcTxQB/Mvrw\n\tTvvk2LEgZdIBe4g/a5BTxum+tMvKYqPzmUmSw8No=","Message-ID":"<6bccb5e6-0e48-4906-8ec4-46c81ddbb911@ideasonboard.com>","Date":"Wed, 14 Jan 2026 10:35:13 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 35/36] pipeline: simple: Rename supported_devices\n\tconfiguration option to devices","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-36-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260113000808.15395-36-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]