[{"id":37639,"web_url":"https://patchwork.libcamera.org/comment/37639/","msgid":"","date":"2026-01-14T09:43:22","subject":"Re: [PATCH 34/36] libcamera: software_isp: Rename \"measure\" option\n\tto \"benchmark\"","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 13. 1:08 keltezéssel, Laurent Pinchart írta:\n> The software ISP \"measure\" configuration option doesn't clearly indicate\n> what it measures. Rename it to \"benchmark\" to match the name of the\n> class that handles it and make it self-explicit.\n> \n> While at it, improve the documentation slightly by replacing \"per-frame\n> time measurement\" with \"performance measurement\".\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> Documentation/runtime_configuration.rst | 10 +++++-----\n> src/libcamera/software_isp/benchmark.cpp | 10 +++++-----\n> 2 files changed, 10 insertions(+), 10 deletions(-)\n> \n> diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst\n> index b4386cd2ef4b..8c920978648d 100644\n> --- a/Documentation/runtime_configuration.rst\n> +++ b/Documentation/runtime_configuration.rst\n> @@ -48,7 +48,7 @@ file structure:\n> software_isp: # true/false\n> software_isp:\n> copy_input_buffer: # true/false\n> - measure:\n> + benchmark:\n> skip: # non-negative integer, frames to skip initially\n> number: # non-negative integer, frames to measure\n> \n> @@ -81,7 +81,7 @@ Configuration file example\n> software_isp: true\n> software_isp:\n> copy_input_buffer: false\n> - measure:\n> + benchmark:\n> skip: 50\n> number: 30\n> \n> @@ -155,13 +155,13 @@ software_isp.copy_input_buffer\n> \n> Example value: ``false``\n> \n> -software_isp.measure.skip, software_isp.measure.number\n> - Define per-frame time measurement parameters in software ISP. `skip`\n> +software_isp.benchmark.skip, software_isp.benchmark.number\n> + Define performance measurement parameters for the software ISP. `skip`\n> defines how many initial frames are skipped before starting the\n> measurement; `number` defines how many frames then participate in the\n> measurement.\n> \n> - Set `software_isp.measure.number` to 0 to disable the measurement.\n> + Set `software_isp.benchmark.number` to 0 to disable the measurement.\n> \n> Example `skip` value: ``50``\n> \n> diff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp\n> index b15ddd66e26f..47bd58727ac3 100644\n> --- a/src/libcamera/software_isp/benchmark.cpp\n> +++ b/src/libcamera/software_isp/benchmark.cpp\n> @@ -34,11 +34,11 @@ Benchmark::Benchmark(const CameraManager &cm)\n> \tconst GlobalConfiguration &configuration = cm._d()->configuration();\n> \n> \tskipBeforeMeasure_ = configuration.option(\n> -\t\t\t\t\t\t{ \"software_isp\", \"measure\", \"skip\" })\n> -\t\t\t\t\t\t\t.value_or(skipBeforeMeasure_);\n> -\tframesToMeasure_ = configuration.option(\n> -\t\t\t\t\t\t{ \"software_isp\", \"measure\", \"number\" })\n> -\t\t\t\t\t\t\t.value_or(framesToMeasure_);\n> +\t\t\t\t\t\t{ \"software_isp\", \"benchmark\", \"skip\" })\n> +\t\t\t\t\t .value_or(skipBeforeMeasure_);\n> + framesToMeasure_ = configuration.option(\n> +\t\t\t\t\t\t{ \"software_isp\", \"benchmark\", \"number\" })\n> +\t\t\t\t\t.value_or(framesToMeasure_);\n> }\n> \n> Benchmark::~Benchmark()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC79AC3226\n\tfor ;\n\tWed, 14 Jan 2026 09:43:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12CED61FBC;\n\tWed, 14 Jan 2026 10:43:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77455615B2\n\tfor ;\n\tWed, 14 Jan 2026 10:43:26 +0100 (CET)","from [192.168.33.18] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A52AB316;\n\tWed, 14 Jan 2026 10:42:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"clcmlGMg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768383779;\n\tbh=gl8vPpX5tF04b9DepkMk+JbEOW7OF5c/8EA5mU0bzuY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=clcmlGMg0EBKYoauQx08dRUoQLHX1widep62fvHvwEWEg/yIX6j8y02T7C5TrslVN\n\t8oo7/keRflAATmcW+8OjvWXXdXf3Gm1RB+4ZUrPM7YPtCDlb0T2KvhVlNthIKc6bSk\n\tNOwlsrCzhoGxHpKFyBeHXX7iS6mWBr8mpAzoOQgE=","Message-ID":"","Date":"Wed, 14 Jan 2026 10:43:22 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 34/36] libcamera: software_isp: Rename \"measure\" option\n\tto \"benchmark\"","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-35-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260113000808.15395-35-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]