[{"id":37601,"web_url":"https://patchwork.libcamera.org/comment/37601/","msgid":"<8c790474-4060-4f30-b832-cbfe8caa362e@ideasonboard.com>","date":"2026-01-13T13:30:39","subject":"Re: [PATCH 31/36] libcamera: global_configuration: Populate empty\n\tconfiguration","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 13. 1:08 keltezéssel, Laurent Pinchart írta:\n> If no configuration file can be parsed, populate an empty configuration.\n> This will serve as a base to store the configuration options set through\n> environment variables.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/global_configuration.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\n> index 4d154c026e44..a759a086b9a4 100644\n> --- a/src/libcamera/global_configuration.cpp\n> +++ b/src/libcamera/global_configuration.cpp\n> @@ -93,7 +93,12 @@ void GlobalConfiguration::load()\n> \n> \tfor (const auto &path : globalConfigurationFiles) {\n> \t\tif (loadFile(path))\n> -\t\t\treturn;\n> +\t\t\tbreak;\n> +\t}\n\nThis misses the earlier `loadFile()` call in the `if (!userConfigurationDirectory.empty()) {` block.\n\n\n> +\n> +\tif (configuration_->isEmpty()) {\n> +\t\tconfiguration_->add(\"version\", std::make_unique(1));\n> +\t\tconfiguration_->add(\"configuration\", std::make_unique());\n> \t}\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A135BDCBF\n\tfor ;\n\tTue, 13 Jan 2026 13:30:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 546C461FC3;\n\tTue, 13 Jan 2026 14:30:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD56861FA0\n\tfor ;\n\tTue, 13 Jan 2026 14:30:42 +0100 (CET)","from [192.168.33.30] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF6142E0;\n\tTue, 13 Jan 2026 14:30:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JKjWnZQb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768311016;\n\tbh=2giRWgCMuS8gMC+BAlIMBoMU40F+1VXgmPOakoWXTgI=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=JKjWnZQbOjhvAMTXl4opN62bOgsnQ4ohpcTDqjLe/qI4vkYba53azz6HP8vW1hBdw\n\twwQEPoBNgn1KgpF8v+v0q+mGnNGR1Sg1aD+n6R1eTQarRq+bFl9vIB5PqDgux4xK1q\n\tPHw1Nz4t63uCRulDSvZoqA1AIzWlMN8HJORAiQ0k=","Message-ID":"<8c790474-4060-4f30-b832-cbfe8caa362e@ideasonboard.com>","Date":"Tue, 13 Jan 2026 14:30:39 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 31/36] libcamera: global_configuration: Populate empty\n\tconfiguration","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-32-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260113000808.15395-32-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37610,"web_url":"https://patchwork.libcamera.org/comment/37610/","msgid":"<20260113141552.GL6198@pendragon.ideasonboard.com>","date":"2026-01-13T14:15:52","subject":"Re: [PATCH 31/36] libcamera: global_configuration: Populate empty\n\tconfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 13, 2026 at 02:30:39PM +0100, Barnabás Pőcze wrote:\n> 2026. 01. 13. 1:08 keltezéssel, Laurent Pinchart írta:\n> > If no configuration file can be parsed, populate an empty configuration.\n> > This will serve as a base to store the configuration options set through\n> > environment variables.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/global_configuration.cpp | 7 ++++++-\n> > 1 file changed, 6 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\n> > index 4d154c026e44..a759a086b9a4 100644\n> > --- a/src/libcamera/global_configuration.cpp\n> > +++ b/src/libcamera/global_configuration.cpp\n> > @@ -93,7 +93,12 @@ void GlobalConfiguration::load()\n> > \n> > \tfor (const auto &path : globalConfigurationFiles) {\n> > \t\tif (loadFile(path))\n> > -\t\t\treturn;\n> > +\t\t\tbreak;\n> > +\t}\n> \n> This misses the earlier `loadFile()` call in the `if (!userConfigurationDirectory.empty()) {` block.\n\nIndeed. I'll reorganize the code.\n\n> > +\n> > +\tif (configuration_->isEmpty()) {\n> > +\t\tconfiguration_->add(\"version\", std::make_unique(1));\n> > +\t\tconfiguration_->add(\"configuration\", std::make_unique());\n> > \t}\n> > }\n> > \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9ECDABE08B\n\tfor ;\n\tTue, 13 Jan 2026 14:16:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C760961FC4;\n\tTue, 13 Jan 2026 15:16:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7D9461FA0\n\tfor ;\n\tTue, 13 Jan 2026 15:16:12 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A11C350A;\n\tTue, 13 Jan 2026 15:15:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ma95Bkln\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768313746;\n\tbh=5mUc6cpDUzqJKiyDZK98qK9SwEa6/t2W979Eu2agqis=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ma95BklnLo6Vc3Y8Yr33xdr0rN8FbBqtUIEKQ3aPwnKnrjnG601egPMaAaGt5HhZE\n\tb5WS4gwA7bnYOvZcEox0kSYSMQKgOPDHNU5RH9xx+bLzkiP8mivasoT5RT9qWq/wV/\n\tEZMWlkp7ttLjWsOAPoT5YOG20fUtBQ4yiInTGJA4=","Date":"Tue, 13 Jan 2026 16:15:52 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 31/36] libcamera: global_configuration: Populate empty\n\tconfiguration","Message-ID":"<20260113141552.GL6198@pendragon.ideasonboard.com>","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-32-laurent.pinchart@ideasonboard.com>\n\t<8c790474-4060-4f30-b832-cbfe8caa362e@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<8c790474-4060-4f30-b832-cbfe8caa362e@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]