[{"id":37646,"web_url":"https://patchwork.libcamera.org/comment/37646/","msgid":"<9b1d99fc-4770-472b-8eee-71c59bd73dbb@ideasonboard.com>","date":"2026-01-14T11:01:30","subject":"Re: [PATCH 27/36] libcamera: value_node: Add mutable adapters","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 13. 1:07 keltezéssel, Laurent Pinchart írta:\n> The ValueNode class was initially designed to store read-only property\n> trees. It is useful to also provide mutable access. Add non-const\n> adapters and iterators and adapters. This allows obtaining a mutable\n> ValueNode instance when traversing a tree.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> include/libcamera/internal/value_node.h | 32 ++++++++++++++++++-------\n> src/libcamera/value_node.cpp | 10 ++++++++\n> 2 files changed, 34 insertions(+), 8 deletions(-)\n> \n> diff --git a/include/libcamera/internal/value_node.h b/include/libcamera/internal/value_node.h\n> index dd45859f3501..56d200e1cf27 100644\n> --- a/include/libcamera/internal/value_node.h\n> +++ b/include/libcamera/internal/value_node.h\n> @@ -143,17 +143,31 @@ public:\n> \t\t}\n> \t};\n> \n> -\tclass DictAdapter : public Adapter -\t\t\t\t\t\t\tValueContainer::const_iterator>,\n> -\t\t\t\t\t const ValueContainer>\n> +\tclass DictAdapter : public Adapter +\t\t\t\t\t\t\tValueContainer::iterator>,\n> +\t\t\t\t\t ValueContainer>\n> \t{\n> \tpublic:\n> \t\tusing key_type = std::string;\n> \t};\n> \n> -\tclass ListAdapter : public Adapter -\t\t\t\t\t\t\tValueContainer::const_iterator>,\n> -\t\t\t\t\t const ValueContainer>\n> +\tclass ListAdapter : public Adapter +\t\t\t\t\t\t\tValueContainer::iterator>,\n> +\t\t\t\t\t ValueContainer>\n> +\t{\n> +\t};\n> +\n> +\tclass ConstDictAdapter : public Adapter +\t\t\t\t\t\t\t ValueContainer::const_iterator>,\n> +\t\t\t\t\t\tconst ValueContainer>\n> +\t{\n> +\tpublic:\n> +\t\tusing key_type = std::string;\n> +\t};\n> +\n> +\tclass ConstListAdapter : public Adapter +\t\t\t\t\t\t\t ValueContainer::const_iterator>,\n> +\t\t\t\t\t\tconst ValueContainer>\n> \t{\n> \t};\n> #endif /* __DOXYGEN__ */\n> @@ -209,8 +223,10 @@ public:\n> \t\treturn Accessor>{}.set(*this, std::forward(value));\n> \t}\n> \n> -\tDictAdapter asDict() const { return DictAdapter{ list_ }; }\n> -\tListAdapter asList() const { return ListAdapter{ list_ }; }\n> +\tDictAdapter asDict() { return DictAdapter{ list_ }; }\n> +\tListAdapter asList() { return ListAdapter{ list_ }; }\n> +\tConstDictAdapter asDict() const { return ConstDictAdapter{ list_ }; }\n> +\tConstListAdapter asList() const { return ConstListAdapter{ list_ }; }\n> \n> \tconst ValueNode &operator[](std::size_t index) const;\n> \n> diff --git a/src/libcamera/value_node.cpp b/src/libcamera/value_node.cpp\n> index b8f0c6d5cbc4..3c56b47bf79d 100644\n> --- a/src/libcamera/value_node.cpp\n> +++ b/src/libcamera/value_node.cpp\n> @@ -335,6 +335,11 @@ template struct ValueNode::Accessor>;\n> template struct ValueNode::Accessor>;\n> #endif /* __DOXYGEN__ */\n> \n> +/**\n> + * \\fn ValueNode::asDict()\n> + * \\copydoc ValueNode::asDict() const\n> + */\n> +\n> /**\n> * \\fn ValueNode::asDict() const\n> * \\brief Wrap a dictionary ValueNode in an adapter that exposes iterators\n> @@ -355,6 +360,11 @@ template struct ValueNode::Accessor>;\n> * \\return An adapter of unspecified type compatible with range-based for loops\n> */\n> \n> +/**\n> + * \\fn ValueNode::asList()\n> + * \\copydoc ValueNode::asList() const\n> + */\n> +\n> /**\n> * \\fn ValueNode::asList() const\n> * \\brief Wrap a list ValueNode in an adapter that exposes iterators","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B24CC3226\n\tfor ;\n\tWed, 14 Jan 2026 11:01:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2823361FBC;\n\tWed, 14 Jan 2026 12:01:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16A4661F9F\n\tfor ;\n\tWed, 14 Jan 2026 12:01:34 +0100 (CET)","from [192.168.33.18] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A25D24A;\n\tWed, 14 Jan 2026 12:01:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cqB7yLQv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768388467;\n\tbh=9meChVkrxSNQIVbyNZDbuMwhYtaOxFJX7tGv3pm8k88=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=cqB7yLQvzZ920UdZmacKYt01dCM7nT8iWk+l02OOCddtm7skIRJiY4EFw5O7GYfPE\n\t5CjPBvfn4b1ey4NakeTImsRzWazJX44rw2mIClqOEHqrpxGUCL2TeZCXKpuZCyTZsD\n\tuMHOtGCP/oq/dFzL6BmoxyQkyLXA1GSvnc2ezzWU=","Message-ID":"<9b1d99fc-4770-472b-8eee-71c59bd73dbb@ideasonboard.com>","Date":"Wed, 14 Jan 2026 12:01:30 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 27/36] libcamera: value_node: Add mutable adapters","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-28-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260113000808.15395-28-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]