{"id":25747,"url":"https://patchwork.libcamera.org/api/patches/25747/?format=json","web_url":"https://patchwork.libcamera.org/patch/25747/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260113000808.15395-28-laurent.pinchart@ideasonboard.com>","date":"2026-01-13T00:07:59","name":"[27/36] libcamera: value_node: Add mutable adapters","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4cbe092716c5a7a5c91b7a33ea65f197164cc747","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25747/mbox/","series":[{"id":5703,"url":"https://patchwork.libcamera.org/api/series/5703/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5703","date":"2026-01-13T00:07:32","name":"libcamera: Global configuration file improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/5703/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25747/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25747/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0715CC3274\n\tfor ;\n\tTue, 13 Jan 2026 00:09:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AFF616200C;\n\tTue, 13 Jan 2026 01:09:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A2E261FC8\n\tfor ;\n\tTue, 13 Jan 2026 01:09:14 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4DC1050A\n\tfor ;\n\tTue, 13 Jan 2026 01:08:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Rl4CkRIw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768262928;\n\tbh=W/yPyHKX2bBnhl5b348E0xIqiMmpbsmhk4DhPgru5Bw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Rl4CkRIwBVWeJAb/K8EGSRk19uYAxmGARjsd8lsMkd1gwjPY6tgHupCUXNo5PvnMo\n\tMUeO0Q465VFQ5prCkABhP2YgtD7WYEKJCXpUMJoldW9TJiER6NmpGZrf9VEiDuWmxM\n\tRE3G7napZ6Vy9/vCkSITr8qlCjN3KyHmE3TCFW9U=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 27/36] libcamera: value_node: Add mutable adapters","Date":"Tue, 13 Jan 2026 02:07:59 +0200","Message-ID":"<20260113000808.15395-28-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ValueNode class was initially designed to store read-only property\ntrees. It is useful to also provide mutable access. Add non-const\nadapters and iterators and adapters. This allows obtaining a mutable\nValueNode instance when traversing a tree.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/value_node.h | 32 ++++++++++++++++++-------\n src/libcamera/value_node.cpp | 10 ++++++++\n 2 files changed, 34 insertions(+), 8 deletions(-)","diff":"diff --git a/include/libcamera/internal/value_node.h b/include/libcamera/internal/value_node.h\nindex dd45859f3501..56d200e1cf27 100644\n--- a/include/libcamera/internal/value_node.h\n+++ b/include/libcamera/internal/value_node.h\n@@ -143,17 +143,31 @@ public:\n \t\t}\n \t};\n \n-\tclass DictAdapter : public Adapter,\n-\t\t\t\t\t const ValueContainer>\n+\tclass DictAdapter : public Adapter,\n+\t\t\t\t\t ValueContainer>\n \t{\n \tpublic:\n \t\tusing key_type = std::string;\n \t};\n \n-\tclass ListAdapter : public Adapter,\n-\t\t\t\t\t const ValueContainer>\n+\tclass ListAdapter : public Adapter,\n+\t\t\t\t\t ValueContainer>\n+\t{\n+\t};\n+\n+\tclass ConstDictAdapter : public Adapter,\n+\t\t\t\t\t\tconst ValueContainer>\n+\t{\n+\tpublic:\n+\t\tusing key_type = std::string;\n+\t};\n+\n+\tclass ConstListAdapter : public Adapter,\n+\t\t\t\t\t\tconst ValueContainer>\n \t{\n \t};\n #endif /* __DOXYGEN__ */\n@@ -209,8 +223,10 @@ public:\n \t\treturn Accessor>{}.set(*this, std::forward(value));\n \t}\n \n-\tDictAdapter asDict() const { return DictAdapter{ list_ }; }\n-\tListAdapter asList() const { return ListAdapter{ list_ }; }\n+\tDictAdapter asDict() { return DictAdapter{ list_ }; }\n+\tListAdapter asList() { return ListAdapter{ list_ }; }\n+\tConstDictAdapter asDict() const { return ConstDictAdapter{ list_ }; }\n+\tConstListAdapter asList() const { return ConstListAdapter{ list_ }; }\n \n \tconst ValueNode &operator[](std::size_t index) const;\n \ndiff --git a/src/libcamera/value_node.cpp b/src/libcamera/value_node.cpp\nindex b8f0c6d5cbc4..3c56b47bf79d 100644\n--- a/src/libcamera/value_node.cpp\n+++ b/src/libcamera/value_node.cpp\n@@ -335,6 +335,11 @@ template struct ValueNode::Accessor>;\n template struct ValueNode::Accessor>;\n #endif /* __DOXYGEN__ */\n \n+/**\n+ * \\fn ValueNode::asDict()\n+ * \\copydoc ValueNode::asDict() const\n+ */\n+\n /**\n * \\fn ValueNode::asDict() const\n * \\brief Wrap a dictionary ValueNode in an adapter that exposes iterators\n@@ -355,6 +360,11 @@ template struct ValueNode::Accessor>;\n * \\return An adapter of unspecified type compatible with range-based for loops\n */\n \n+/**\n+ * \\fn ValueNode::asList()\n+ * \\copydoc ValueNode::asList() const\n+ */\n+\n /**\n * \\fn ValueNode::asList() const\n * \\brief Wrap a list ValueNode in an adapter that exposes iterators\n","prefixes":["27/36"]}