[{"id":37623,"web_url":"https://patchwork.libcamera.org/comment/37623/","msgid":"","date":"2026-01-13T16:46:55","subject":"Re: [PATCH 25/36] libcamera: value_node: Add constructor with value","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 13. 1:07 keltezéssel, Laurent Pinchart írta:\n> The new constructor takes a value, allowing creation of a leaf ValueNode\n> with a value in a single operation instead of having to call set() on an\n> empty node.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> include/libcamera/internal/value_node.h | 7 +++++++\n> src/libcamera/value_node.cpp | 7 +++++++\n> 2 files changed, 14 insertions(+)\n> \n> diff --git a/include/libcamera/internal/value_node.h b/include/libcamera/internal/value_node.h\n> index a336c1d08e1c..eb509d855810 100644\n> --- a/include/libcamera/internal/value_node.h\n> +++ b/include/libcamera/internal/value_node.h\n> @@ -143,6 +143,13 @@ public:\n> #endif /* __DOXYGEN__ */\n> \n> \tValueNode();\n> +\n> +\ttemplate\n> +\tValueNode(T &&value)\n> +\t{\n> +\t\tset(std::forward(value));\n> +\t}\n> +\n> \t~ValueNode();\n> \n> \tbool isValue() const\n> diff --git a/src/libcamera/value_node.cpp b/src/libcamera/value_node.cpp\n> index 7374e7bdde8c..b8f0c6d5cbc4 100644\n> --- a/src/libcamera/value_node.cpp\n> +++ b/src/libcamera/value_node.cpp\n> @@ -44,6 +44,13 @@ ValueNode::ValueNode()\n> {\n> }\n> \n> +/**\n> + * \\fn template ValueNode::ValueNode(T &&value)\n> + * \\brief Construct a ValueNode instance with a value\n> + * \\tparam T Type of the value\n> + * \\param[in] value The value\n> + */\n> +\n> ValueNode::~ValueNode() = default;\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C505BDCBF\n\tfor ;\n\tTue, 13 Jan 2026 16:47:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFC2961FBC;\n\tTue, 13 Jan 2026 17:47:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B439F61FA0\n\tfor ;\n\tTue, 13 Jan 2026 17:46:59 +0100 (CET)","from [192.168.33.30] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8096F50A;\n\tTue, 13 Jan 2026 17:46:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bPj3fKif\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768322793;\n\tbh=1d83hFPLO9Kv3466zanmbXy2l6AXc7a+y5a1E1+0QSg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=bPj3fKifXZgTpDMlTTbLIeG7tS8PMH9c+8Fvc2+xEGE67HMNrAN5NI4tPtaQfKNSG\n\twhrYMpH59vVLU3uVPSIlu/tnJtvGdJtG7Mtzf5BK4nrnpfJ5SWA8nChAyV2zTT1aKr\n\t4IAbSbXX4c2UHkpFjLwripCMwG6xLWkypf41WVqk=","Message-ID":"","Date":"Tue, 13 Jan 2026 17:46:55 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 25/36] libcamera: value_node: Add constructor with value","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-26-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260113000808.15395-26-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]