[{"id":37621,"web_url":"https://patchwork.libcamera.org/comment/37621/","msgid":"","date":"2026-01-13T16:41:42","subject":"Re: [PATCH 23/36] libcamera: global_configuration: Rename\n\tyamlConfiguration_","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 13. 1:07 keltezéssel, Laurent Pinchart írta:\n> Once parsed, the global configuration isn't a YAML file anymore. Rename\n> the yamlConfiguration_ to configuration_.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> include/libcamera/internal/global_configuration.h | 2 +-\n> src/libcamera/global_configuration.cpp | 6 +++---\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/global_configuration.h b/include/libcamera/internal/global_configuration.h\n> index 80b57b38ba03..5c907ee92bfe 100644\n> --- a/include/libcamera/internal/global_configuration.h\n> +++ b/include/libcamera/internal/global_configuration.h\n> @@ -56,7 +56,7 @@ private:\n> \tvoid load();\n> \tbool loadFile(const std::filesystem::path &fileName);\n> \n> -\tstd::unique_ptr yamlConfiguration_ =\n> +\tstd::unique_ptr configuration_ =\n> \t\tstd::make_unique();\n> };\n> \n> diff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\n> index 44ed206de78f..ee7d9c185b80 100644\n> --- a/src/libcamera/global_configuration.cpp\n> +++ b/src/libcamera/global_configuration.cpp\n> @@ -125,7 +125,7 @@ bool GlobalConfiguration::loadFile(const std::filesystem::path &fileName)\n> \t\treturn true;\n> \t}\n> \n> -\tyamlConfiguration_ = std::move(configuration);\n> +\tconfiguration_ = std::move(configuration);\n> \treturn true;\n> }\n> \n> @@ -141,7 +141,7 @@ bool GlobalConfiguration::loadFile(const std::filesystem::path &fileName)\n> */\n> unsigned int GlobalConfiguration::version() const\n> {\n> -\treturn (*yamlConfiguration_)[\"version\"].get().value_or(0);\n> +\treturn (*configuration_)[\"version\"].get().value_or(0);\n> }\n> \n> /**\n> @@ -160,7 +160,7 @@ unsigned int GlobalConfiguration::version() const\n> */\n> GlobalConfiguration::Configuration GlobalConfiguration::configuration() const\n> {\n> -\treturn (*yamlConfiguration_)[\"configuration\"];\n> +\treturn (*configuration_)[\"configuration\"];\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9083ABE08B\n\tfor ;\n\tTue, 13 Jan 2026 16:41:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 501FA61FA3;\n\tTue, 13 Jan 2026 17:41:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 210D861FA0\n\tfor ;\n\tTue, 13 Jan 2026 17:41:46 +0100 (CET)","from [192.168.33.30] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C182A50A;\n\tTue, 13 Jan 2026 17:41:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lo9aJOCL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768322480;\n\tbh=b+AktSpwjDdItljHodWe26I13Qbznme+15AkH5nivTE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=lo9aJOCLJ3sj9dSd7FPKQTe6DGum/1VvBEnc3Qmo8wH01ymrrxOiJBQ+QXC4+dHDE\n\twZbHesxfxxuPD5/y2EzdeoviL01VThXx64dtNMZvZSML2DLaLTqK3aobjQK2dU1TZc\n\tQudpRtbxkQkKogiO2DM269n4cO6XuCnV7J9OpUPw=","Message-ID":"","Date":"Tue, 13 Jan 2026 17:41:42 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 23/36] libcamera: global_configuration: Rename\n\tyamlConfiguration_","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-24-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260113000808.15395-24-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]