[{"id":37620,"web_url":"https://patchwork.libcamera.org/comment/37620/","msgid":"<0feef980-d183-4fb1-ab18-2a8a4d79ef64@ideasonboard.com>","date":"2026-01-13T16:40:52","subject":"Re: [PATCH 22/36] libcamera: global_configuration: Add missing\n\tinclude and comment","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 13. 1:07 keltezéssel, Laurent Pinchart írta:\n> global_configuration.h uses std::initializer_list, include the\n> corresponding header. Add a comment in global_configuration.cpp to close\n> an anonymous namespace, as mandated by the coding style.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> include/libcamera/internal/global_configuration.h | 1 +\n> src/libcamera/global_configuration.cpp | 4 +++-\n> 2 files changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/internal/global_configuration.h b/include/libcamera/internal/global_configuration.h\n> index 84bdf90244d9..80b57b38ba03 100644\n> --- a/include/libcamera/internal/global_configuration.h\n> +++ b/include/libcamera/internal/global_configuration.h\n> @@ -8,6 +8,7 @@\n> #pragma once\n> \n> #include \n> +#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\n> index c853a028c91d..44ed206de78f 100644\n> --- a/src/libcamera/global_configuration.cpp\n> +++ b/src/libcamera/global_configuration.cpp\n> @@ -24,11 +24,13 @@\n> namespace libcamera {\n> \n> namespace {\n> +\n> const std::vector globalConfigurationFiles = {\n> \tstd::filesystem::path(LIBCAMERA_SYSCONF_DIR) / \"configuration.yaml\",\n> \tstd::filesystem::path(LIBCAMERA_DATA_DIR) / \"configuration.yaml\",\n> };\n> -}\n> +\n> +} /* namespace */\n> \n> LOG_DEFINE_CATEGORY(Configuration)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16818BDCBF\n\tfor ;\n\tTue, 13 Jan 2026 16:40:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BCACA61FC5;\n\tTue, 13 Jan 2026 17:40:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1611B61FA0\n\tfor ;\n\tTue, 13 Jan 2026 17:40:57 +0100 (CET)","from [192.168.33.30] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 638BE50A;\n\tTue, 13 Jan 2026 17:40:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IE1ZPopY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768322431;\n\tbh=7EmjEgOynyM3Z1pd2iV3KoEjpmOGClwtPnmWYcIkKSA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=IE1ZPopYYymuqgx5aVJzbXFb4qCetXaW6NMYxBdK3dafv9al6SEInXdhGD43k5GFV\n\txcUEmKjYwvShRr4CYXasQ4UdT2gOG/fTvmXF1H6/4N6ugT/qiqP2dG0cRNPDHDzP/n\n\t1nVoVvgk11xW4IDRjP750XJOYjDlUBq3WDaITzUw=","Message-ID":"<0feef980-d183-4fb1-ab18-2a8a4d79ef64@ideasonboard.com>","Date":"Tue, 13 Jan 2026 17:40:52 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 22/36] libcamera: global_configuration: Add missing\n\tinclude and comment","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-23-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260113000808.15395-23-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]