[{"id":37615,"web_url":"https://patchwork.libcamera.org/comment/37615/","msgid":"<4afdc969-bb0f-4108-95e5-3d42e100a540@ideasonboard.com>","date":"2026-01-13T16:06:07","subject":"Re: [PATCH 09/36] libcamera: yaml_parser: Rename Container to\n\tValueContainer","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 13. 1:07 keltezéssel, Laurent Pinchart írta:\n> The YamlObject class defines two private types, Container and\n> ListContainer. The format is an alias to std::vector, and is used\n> to store child elements. The latter hasn't been used since commit\n> 38987e165c28 (\"libcamera: yaml_parser: Preserve order of items in\n> dictionary\").\n> \n> To prepare for upcoming reworks that will use the name 'Container' as a\n> template parameter, rename Container to ValueContainer for clarity, and\n> drop the unused ListContainer type.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nTo me `Container` also seems like a perfectly fine name.\n\nReviewed-by: Barnabás Pőcze \n\n\n> include/libcamera/internal/yaml_parser.h | 13 ++++++-------\n> 1 file changed, 6 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h\n> index 8c7916565946..03d6a05e2d0f 100644\n> --- a/include/libcamera/internal/yaml_parser.h\n> +++ b/include/libcamera/internal/yaml_parser.h\n> @@ -36,8 +36,7 @@ private:\n> \t\tstd::unique_ptr value;\n> \t};\n> \n> -\tusing Container = std::vector;\n> -\tusing ListContainer = std::vector>;\n> +\tusing ValueContainer = std::vector;\n> \n> public:\n> #ifndef __DOXYGEN__\n> @@ -48,7 +47,7 @@ public:\n> \t\tusing difference_type = std::ptrdiff_t;\n> \t\tusing iterator_category = std::forward_iterator_tag;\n> \n> -\t\tIterator(typename Container::const_iterator it)\n> +\t\tIterator(typename ValueContainer::const_iterator it)\n> \t\t\t: it_(it)\n> \t\t{\n> \t\t}\n> @@ -77,14 +76,14 @@ public:\n> \t\t}\n> \n> \tprotected:\n> -\t\tContainer::const_iterator it_;\n> +\t\tValueContainer::const_iterator it_;\n> \t};\n> \n> \ttemplate\n> \tclass Adapter\n> \t{\n> \tpublic:\n> -\t\tAdapter(const Container &container)\n> +\t\tAdapter(const ValueContainer &container)\n> \t\t\t: container_(container)\n> \t\t{\n> \t\t}\n> @@ -100,7 +99,7 @@ public:\n> \t\t}\n> \n> \tprotected:\n> -\t\tconst Container &container_;\n> +\t\tconst ValueContainer &container_;\n> \t};\n> \n> \tclass ListIterator : public Iterator\n> @@ -232,7 +231,7 @@ private:\n> \tType type_;\n> \n> \tstd::string value_;\n> -\tContainer list_;\n> +\tValueContainer list_;\n> \tstd::map> dictionary_;\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 192F5BDCBF\n\tfor ;\n\tTue, 13 Jan 2026 16:06:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CD5C61FBF;\n\tTue, 13 Jan 2026 17:06:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD68C61FA0\n\tfor ;\n\tTue, 13 Jan 2026 17:06:10 +0100 (CET)","from [192.168.33.30] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B389650A;\n\tTue, 13 Jan 2026 17:05:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QSHU8ArB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768320344;\n\tbh=RfvKMJGyNh4QeF+O6WJAUKOztv+R0iyfA0L+oqh0n10=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=QSHU8ArBU3I/17MpgsmAmi6X1lTJt2EdRbK6cbHsW8W98sj/Xor8n+jMftzGNi6Py\n\tEidb9A3CVm8pUC+UxLOYc7R8vis/pfx4titDRkWTR8pRFxkbaf8qLF49i792W0DcLn\n\tfuOIokUe2nVRU3kwtcOB42AdiFzemell633H/hCc=","Message-ID":"<4afdc969-bb0f-4108-95e5-3d42e100a540@ideasonboard.com>","Date":"Tue, 13 Jan 2026 17:06:07 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 09/36] libcamera: yaml_parser: Rename Container to\n\tValueContainer","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-10-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260113000808.15395-10-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]