[{"id":37583,"web_url":"https://patchwork.libcamera.org/comment/37583/","msgid":"<6684b2fe-4580-4f2e-ba89-8b920ee0b1cb@ideasonboard.com>","date":"2026-01-13T08:56:51","subject":"Re: [PATCH 08/36] libcamera: yaml_parser: Use std::make_unique<>","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 13. 1:07 keltezéssel, Laurent Pinchart írta:\n> The YamlParser::parse() function constructs a std::unique_ptr<> instance\n> with a manual call to operator new. Replace it with std::make_unique<>.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/yaml_parser.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\n> index a5e424615c26..72580e901ddd 100644\n> --- a/src/libcamera/yaml_parser.cpp\n> +++ b/src/libcamera/yaml_parser.cpp\n> @@ -769,7 +769,7 @@ std::unique_ptr YamlParser::parse(File &file)\n> \tif (context.init(file))\n> \t\treturn nullptr;\n> \n> -\tstd::unique_ptr root(new YamlObject());\n> +\tstd::unique_ptr root = std::make_unique();\n> \n> \tif (context.parseContent(*root)) {\n> \t\tLOG(YamlParser, Error)\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51363BE08B\n\tfor ;\n\tTue, 13 Jan 2026 08:56:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BD8361FBB;\n\tTue, 13 Jan 2026 09:56:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC22461F84\n\tfor ;\n\tTue, 13 Jan 2026 09:56:54 +0100 (CET)","from [192.168.33.30] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0F7250A;\n\tTue, 13 Jan 2026 09:56:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"thBWB2cx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768294588;\n\tbh=chq0ZGgViwQ1msoxZNUL4qBBhB7MnfLxNddFaus0ma8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=thBWB2cx0fOvJXwJpsmXh6RYtXoBSoINyb1HwzazeuEVDO5ijaTKNjcRC5kj2g1h6\n\tbxInelCizoQOP6/ZZWg9Dcgw6kS0b00PtISOlvSi5gTIaiU8phh7VUaVUw03zYRQBJ\n\tqiZev30Iijw8znuPy/Shjb+o1Xo232qMZ7bPNgVw=","Message-ID":"<6684b2fe-4580-4f2e-ba89-8b920ee0b1cb@ideasonboard.com>","Date":"Tue, 13 Jan 2026 09:56:51 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 08/36] libcamera: yaml_parser: Use std::make_unique<>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<0mIPv6gpfaVaB8kFvRkukfDJRTLu1xp0g96e-Z_gkMPj9SPzQbPDYUG44fT_XiuJJkPAbGCl0jH32MnxMaf2hw==@protonmail.internalid>\n\t<20260113000808.15395-9-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260113000808.15395-9-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37643,"web_url":"https://patchwork.libcamera.org/comment/37643/","msgid":"<176838475721.20276.15738939436617016257@localhost>","date":"2026-01-14T09:59:17","subject":"Re: [PATCH 08/36] libcamera: yaml_parser: Use std::make_unique<>","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-01-13 01:07:40)\n> The YamlParser::parse() function constructs a std::unique_ptr<> instance\n> with a manual call to operator new. Replace it with std::make_unique<>.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> ---\n> src/libcamera/yaml_parser.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\n> index a5e424615c26..72580e901ddd 100644\n> --- a/src/libcamera/yaml_parser.cpp\n> +++ b/src/libcamera/yaml_parser.cpp\n> @@ -769,7 +769,7 @@ std::unique_ptr YamlParser::parse(File &file)\n> if (context.init(file))\n> return nullptr;\n> \n> - std::unique_ptr root(new YamlObject());\n> + std::unique_ptr root = std::make_unique();\n> \n> if (context.parseContent(*root)) {\n> LOG(YamlParser, Error)\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDFADBDCBF\n\tfor ;\n\tWed, 14 Jan 2026 09:59:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A14AD61FBC;\n\tWed, 14 Jan 2026 10:59:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20D3C615B2\n\tfor ;\n\tWed, 14 Jan 2026 10:59:20 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b781:dff2:957:7831])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 80A5D316;\n\tWed, 14 Jan 2026 10:58:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"akA9U1kr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768384733;\n\tbh=T9t2I4GdGNgytMQwWylWG0f7WoTJesOLETTm0ziIACk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=akA9U1kr+PxWUDOnCibsHJDpwow3lxI8a1Alcdc0Rxx4XIuxAP5/QPNMQq6lGSdYe\n\tXfr9EBKdt+S1APJqCzYTrpLRwbw5xbzp2h9iISxkOlvM57+w2pn8fzl8mbfCTzDkzH\n\tQgcrlqhaUvd3z6UyyiBAZT3+gL2J9obISfFnUSJ0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260113000808.15395-9-laurent.pinchart@ideasonboard.com>","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-9-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 08/36] libcamera: yaml_parser: Use std::make_unique<>","From":"Stefan Klug ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 14 Jan 2026 10:59:17 +0100","Message-ID":"<176838475721.20276.15738939436617016257@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]