[{"id":37586,"web_url":"https://patchwork.libcamera.org/comment/37586/","msgid":"<8a0833da-8eeb-4c30-8e96-df5836ee5e72@ideasonboard.com>","date":"2026-01-13T08:57:35","subject":"Re: [PATCH 01/36] libcamera: Drop unneeded usage of this pointer","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 13. 1:07 keltezéssel, Laurent Pinchart írta:\n> A few unneeded usages of the this pointer to quality access to class\n> members have been introduced over time. Drop them.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/internal/shared_mem_object.h | 4 ++--\n> src/libcamera/camera_manager.cpp | 2 +-\n> src/libcamera/shared_mem_object.cpp | 8 ++++----\n> 3 files changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\n> index e9f1dacd731d..21e025513fdf 100644\n> --- a/include/libcamera/internal/shared_mem_object.h\n> +++ b/include/libcamera/internal/shared_mem_object.h\n> @@ -79,7 +79,7 @@ public:\n> \tSharedMemObject(SharedMemObject &&rhs)\n> \t\t: SharedMem(std::move(rhs))\n> \t{\n> -\t\tthis->obj_ = rhs.obj_;\n> +\t\tobj_ = rhs.obj_;\n> \t\trhs.obj_ = nullptr;\n> \t}\n> \n> @@ -92,7 +92,7 @@ public:\n> \tSharedMemObject &operator=(SharedMemObject &&rhs)\n> \t{\n> \t\tSharedMem::operator=(std::move(rhs));\n> -\t\tthis->obj_ = rhs.obj_;\n> +\t\tobj_ = rhs.obj_;\n> \t\trhs.obj_ = nullptr;\n> \t\treturn *this;\n> \t}\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 23185467ba02..fc6e490bc476 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -41,7 +41,7 @@ LOG_DEFINE_CATEGORY(Camera)\n> CameraManager::Private::Private()\n> \t: Thread(\"CameraManager\"), initialized_(false)\n> {\n> -\tipaManager_ = std::make_unique(this->configuration());\n> +\tipaManager_ = std::make_unique(configuration());\n> }\n> \n> int CameraManager::Private::start()\n> diff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp\n> index d9b61d37dd43..6edab045d47e 100644\n> --- a/src/libcamera/shared_mem_object.cpp\n> +++ b/src/libcamera/shared_mem_object.cpp\n> @@ -80,8 +80,8 @@ SharedMem::SharedMem(const std::string &name, std::size_t size)\n> */\n> SharedMem::SharedMem(SharedMem &&rhs)\n> {\n> -\tthis->fd_ = std::move(rhs.fd_);\n> -\tthis->mem_ = rhs.mem_;\n> +\tfd_ = std::move(rhs.fd_);\n> +\tmem_ = rhs.mem_;\n> \trhs.mem_ = {};\n\nIt would be nice to use the member initializer list here.\n\nReviewed-by: Barnabás Pőcze \n\n\n> }\n> \n> @@ -109,8 +109,8 @@ SharedMem::~SharedMem()\n> */\n> SharedMem &SharedMem::operator=(SharedMem &&rhs)\n> {\n> -\tthis->fd_ = std::move(rhs.fd_);\n> -\tthis->mem_ = rhs.mem_;\n> +\tfd_ = std::move(rhs.fd_);\n> +\tmem_ = rhs.mem_;\n> \trhs.mem_ = {};\n> \treturn *this;\n> }\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00756BE08B\n\tfor ;\n\tTue, 13 Jan 2026 08:57:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4F8761FBC;\n\tTue, 13 Jan 2026 09:57:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3E2061FBB\n\tfor ;\n\tTue, 13 Jan 2026 09:57:37 +0100 (CET)","from [192.168.33.30] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB6AD50A;\n\tTue, 13 Jan 2026 09:57:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aJHVNhg6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768294632;\n\tbh=OK4J56W2b301Mud55Ac+uV+pjoFepwZ4KWwtOLcVhsc=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=aJHVNhg6wnZdHICaKBqymAKU10t/fzk726+7GMn4rBFylT74bx/SWpSDXEwQIjIIk\n\tLHVxOspsjeX4E04lhtHf+DbrxUtNjIV81HiOimD7oEGGS/ziCLbXdB7xCNtXXLRBBq\n\tfD2slMuzq7A5QcQ+AlBR4FXmYm93OO3EwFJHIh1Q=","Message-ID":"<8a0833da-8eeb-4c30-8e96-df5836ee5e72@ideasonboard.com>","Date":"Tue, 13 Jan 2026 09:57:35 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 01/36] libcamera: Drop unneeded usage of this pointer","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<20260113000808.15395-2-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260113000808.15395-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37592,"web_url":"https://patchwork.libcamera.org/comment/37592/","msgid":"<20260113094107.GA18320@pendragon.ideasonboard.com>","date":"2026-01-13T09:41:07","subject":"Re: [PATCH 01/36] libcamera: Drop unneeded usage of this pointer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Jan 13, 2026 at 09:57:35AM +0100, Barnabás Pőcze wrote:\n> 2026. 01. 13. 1:07 keltezéssel, Laurent Pinchart írta:\n> > A few unneeded usages of the this pointer to quality access to class\n> > members have been introduced over time. Drop them.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > include/libcamera/internal/shared_mem_object.h | 4 ++--\n> > src/libcamera/camera_manager.cpp | 2 +-\n> > src/libcamera/shared_mem_object.cpp | 8 ++++----\n> > 3 files changed, 7 insertions(+), 7 deletions(-)\n> > \n> > diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\n> > index e9f1dacd731d..21e025513fdf 100644\n> > --- a/include/libcamera/internal/shared_mem_object.h\n> > +++ b/include/libcamera/internal/shared_mem_object.h\n> > @@ -79,7 +79,7 @@ public:\n> > \tSharedMemObject(SharedMemObject &&rhs)\n> > \t\t: SharedMem(std::move(rhs))\n> > \t{\n> > -\t\tthis->obj_ = rhs.obj_;\n> > +\t\tobj_ = rhs.obj_;\n> > \t\trhs.obj_ = nullptr;\n> > \t}\n> > \n> > @@ -92,7 +92,7 @@ public:\n> > \tSharedMemObject &operator=(SharedMemObject &&rhs)\n> > \t{\n> > \t\tSharedMem::operator=(std::move(rhs));\n> > -\t\tthis->obj_ = rhs.obj_;\n> > +\t\tobj_ = rhs.obj_;\n> > \t\trhs.obj_ = nullptr;\n> > \t\treturn *this;\n> > \t}\n> > diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> > index 23185467ba02..fc6e490bc476 100644\n> > --- a/src/libcamera/camera_manager.cpp\n> > +++ b/src/libcamera/camera_manager.cpp\n> > @@ -41,7 +41,7 @@ LOG_DEFINE_CATEGORY(Camera)\n> > CameraManager::Private::Private()\n> > \t: Thread(\"CameraManager\"), initialized_(false)\n> > {\n> > -\tipaManager_ = std::make_unique(this->configuration());\n> > +\tipaManager_ = std::make_unique(configuration());\n> > }\n> > \n> > int CameraManager::Private::start()\n> > diff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp\n> > index d9b61d37dd43..6edab045d47e 100644\n> > --- a/src/libcamera/shared_mem_object.cpp\n> > +++ b/src/libcamera/shared_mem_object.cpp\n> > @@ -80,8 +80,8 @@ SharedMem::SharedMem(const std::string &name, std::size_t size)\n> > */\n> > SharedMem::SharedMem(SharedMem &&rhs)\n> > {\n> > -\tthis->fd_ = std::move(rhs.fd_);\n> > -\tthis->mem_ = rhs.mem_;\n> > +\tfd_ = std::move(rhs.fd_);\n> > +\tmem_ = rhs.mem_;\n> > \trhs.mem_ = {};\n> \n> It would be nice to use the member initializer list here.\n\nIf you send a patch I'll review it :-)\n\n> Reviewed-by: Barnabás Pőcze \n> \n> > }\n> > \n> > @@ -109,8 +109,8 @@ SharedMem::~SharedMem()\n> > */\n> > SharedMem &SharedMem::operator=(SharedMem &&rhs)\n> > {\n> > -\tthis->fd_ = std::move(rhs.fd_);\n> > -\tthis->mem_ = rhs.mem_;\n> > +\tfd_ = std::move(rhs.fd_);\n> > +\tmem_ = rhs.mem_;\n> > \trhs.mem_ = {};\n> > \treturn *this;\n> > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AD17BE08B\n\tfor ;\n\tTue, 13 Jan 2026 09:41:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6673C61FBB;\n\tTue, 13 Jan 2026 10:41:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A5FB61F84\n\tfor ;\n\tTue, 13 Jan 2026 10:41:28 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BDC7A316;\n\tTue, 13 Jan 2026 10:41:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hf7Ku7lx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768297261;\n\tbh=/iLbjDok7Ucldu5/TYO4KeZsXpRgMVhsvvBVZSgLuBU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Hf7Ku7lxMrDFU3P9cqUnCWfE2T/CzWUlP8JVVcEoATrbMM4LQth+TFvcgzz3dhpyC\n\tx1McwYsErc9H4QuYYUEirrsE/OEZRW3Lg8WwKDVLinofw4DfKTuhtG5jRZxHjVeRh/\n\tbU9pGgaHbN1Ypj55Tlmc0dCpS9w8mLlpBDW0/Qiw=","Date":"Tue, 13 Jan 2026 11:41:07 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 01/36] libcamera: Drop unneeded usage of this pointer","Message-ID":"<20260113094107.GA18320@pendragon.ideasonboard.com>","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<20260113000808.15395-2-laurent.pinchart@ideasonboard.com>\n\t<8a0833da-8eeb-4c30-8e96-df5836ee5e72@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<8a0833da-8eeb-4c30-8e96-df5836ee5e72@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37635,"web_url":"https://patchwork.libcamera.org/comment/37635/","msgid":"<176838267026.20276.7863304789104680187@localhost>","date":"2026-01-14T09:24:30","subject":"Re: [PATCH 01/36] libcamera: Drop unneeded usage of this pointer","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2026-01-13 01:07:33)\n> A few unneeded usages of the this pointer to quality access to class\n\nShould that be \"to qualify\"?\n\n> members have been introduced over time. Drop them.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/internal/shared_mem_object.h | 4 ++--\n> src/libcamera/camera_manager.cpp | 2 +-\n> src/libcamera/shared_mem_object.cpp | 8 ++++----\n> 3 files changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\n> index e9f1dacd731d..21e025513fdf 100644\n> --- a/include/libcamera/internal/shared_mem_object.h\n> +++ b/include/libcamera/internal/shared_mem_object.h\n> @@ -79,7 +79,7 @@ public:\n> SharedMemObject(SharedMemObject &&rhs)\n> : SharedMem(std::move(rhs))\n> {\n> - this->obj_ = rhs.obj_;\n> + obj_ = rhs.obj_;\n> rhs.obj_ = nullptr;\n> }\n> \n> @@ -92,7 +92,7 @@ public:\n> SharedMemObject &operator=(SharedMemObject &&rhs)\n> {\n> SharedMem::operator=(std::move(rhs));\n> - this->obj_ = rhs.obj_;\n> + obj_ = rhs.obj_;\n> rhs.obj_ = nullptr;\n> return *this;\n> }\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 23185467ba02..fc6e490bc476 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -41,7 +41,7 @@ LOG_DEFINE_CATEGORY(Camera)\n> CameraManager::Private::Private()\n> : Thread(\"CameraManager\"), initialized_(false)\n> {\n> - ipaManager_ = std::make_unique(this->configuration());\n> + ipaManager_ = std::make_unique(configuration());\n> }\n> \n> int CameraManager::Private::start()\n> diff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp\n> index d9b61d37dd43..6edab045d47e 100644\n> --- a/src/libcamera/shared_mem_object.cpp\n> +++ b/src/libcamera/shared_mem_object.cpp\n> @@ -80,8 +80,8 @@ SharedMem::SharedMem(const std::string &name, std::size_t size)\n> */\n> SharedMem::SharedMem(SharedMem &&rhs)\n> {\n> - this->fd_ = std::move(rhs.fd_);\n> - this->mem_ = rhs.mem_;\n> + fd_ = std::move(rhs.fd_);\n> + mem_ = rhs.mem_;\n> rhs.mem_ = {};\n> }\n> \n> @@ -109,8 +109,8 @@ SharedMem::~SharedMem()\n> */\n> SharedMem &SharedMem::operator=(SharedMem &&rhs)\n> {\n> - this->fd_ = std::move(rhs.fd_);\n> - this->mem_ = rhs.mem_;\n> + fd_ = std::move(rhs.fd_);\n> + mem_ = rhs.mem_;\n> rhs.mem_ = {};\n> return *this;\n> }\n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32036C3226\n\tfor ;\n\tWed, 14 Jan 2026 09:24:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F314615B2;\n\tWed, 14 Jan 2026 10:24:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31C39615B2\n\tfor ;\n\tWed, 14 Jan 2026 10:24:33 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b781:dff2:957:7831])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7A839316;\n\tWed, 14 Jan 2026 10:24:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ofSkmAZF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768382646;\n\tbh=GLgI1Z/hzx4ixu6WgplSVTMbKUBStNsspgbbXxbTPVE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ofSkmAZFixAOmPqKC5ARbJk3UAZ4uyE7gWS0HUGrGWnM4ekuV5M6vCSIRj/iJlpPH\n\t8rs6IdIRVz1RQ893VrUFxm4LumZS6WJcoxm1R9nwpcsrdojYpQtbWDxlL8bp1zJAcU\n\tljnsq5wKtx6aELNblpxC/mc3tOZuMXMQM2vUlzhE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260113000808.15395-2-laurent.pinchart@ideasonboard.com>","References":"<20260113000808.15395-1-laurent.pinchart@ideasonboard.com>\n\t<20260113000808.15395-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 01/36] libcamera: Drop unneeded usage of this pointer","From":"Stefan Klug ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 14 Jan 2026 10:24:30 +0100","Message-ID":"<176838267026.20276.7863304789104680187@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]