[{"id":37565,"web_url":"https://patchwork.libcamera.org/comment/37565/","msgid":"<1beb2677-042e-4c22-9967-54db5c3aaac0@ideasonboard.com>","date":"2026-01-12T10:53:24","subject":"Re: [PATCH v2 4/4] egl: Print GLES version","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 12. 11:37 keltezéssel, Robert Mader írta:\n> It might come in handy to know whether 2.0 or e.g. 3.2 is used.\n> \n> Signed-off-by: Robert Mader \n> ---\n> include/libcamera/internal/egl.h | 1 +\n> src/libcamera/egl.cpp | 8 ++++++++\n> 2 files changed, 9 insertions(+)\n> \n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index 21e2aa9df..f007f448a 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -136,5 +136,6 @@ private:\n> \tPFNGLEGLIMAGETARGETTEXTURE2DOESPROC glEGLImageTargetTexture2DOES;\n> \tPFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;\n> \tPFNEGLDESTROYIMAGEKHRPROC eglDestroyImageKHR;\n> +\tPFNGLGETSTRINGPROC glGetString;\n> };\n> } //namespace libcamera\n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index a88525279..da563ee09 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -325,6 +325,12 @@ int eGL::initEGLContext(GBM *gbmContext)\n> \t\tgoto fail;\n> \t}\n> \n> +\tglGetString = (PFNGLGETSTRINGPROC)eglGetProcAddress(\"glGetString\");\n\nreinterpret_cast would be preferable imo, but I see the others use the same.\n\n\nReviewed-by: Barnabás Pőcze \n\n\n> +\tif (!glGetString) {\n> +\t\tLOG(eGL, Error) << \"glGetString not found\";\n> +\t\tgoto fail;\n> +\t}\n> +\n> \tif (eglChooseConfig(display_, configAttribs, &config, 1, &numConfigs) != EGL_TRUE) {\n> \t\tLOG(eGL, Error) << \"eglChooseConfig fail\";\n> \t\tgoto fail;\n> @@ -340,6 +346,8 @@ int eGL::initEGLContext(GBM *gbmContext)\n> \n> \tmakeCurrent();\n> \n> +\tLOG(eGL, Info) << \"EGL: GL_VERSION: \" << glGetString(GL_VERSION);\n> +\n> \treturn 0;\n> fail:\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8041CBDCBF\n\tfor ;\n\tMon, 12 Jan 2026 10:53:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF20361FA0;\n\tMon, 12 Jan 2026 11:53:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8584061F9F\n\tfor ;\n\tMon, 12 Jan 2026 11:53:28 +0100 (CET)","from [192.168.33.29] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1FB557E9;\n\tMon, 12 Jan 2026 11:53:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jb3Fcfud\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768215183;\n\tbh=L4PPf4eENHxVPWVRpR9cV5zrfDDKf4rug5h96JtbNtM=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Jb3FcfudefAeNtb40YBnQjcWgGUPqAPqyYqFxAWGe1KFMCd+bIzRQbDwztnPsj0go\n\tyE6lC/EGQflE+SqeOeuMNmrtf0IGmqT+KE1pIH5BNgRimdu0EXrlId6VN1fSLh9mJD\n\t+0J40KbwUy+n7+ymuu4YcYGGclSAgq6hrGApZbCo=","Message-ID":"<1beb2677-042e-4c22-9967-54db5c3aaac0@ideasonboard.com>","Date":"Mon, 12 Jan 2026 11:53:24 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 4/4] egl: Print GLES version","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260112103740.18360-1-robert.mader@collabora.com>\n\t<20260112103740.18360-5-robert.mader@collabora.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260112103740.18360-5-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37571,"web_url":"https://patchwork.libcamera.org/comment/37571/","msgid":"<176822080065.3486172.2540775710351043219@ping.linuxembedded.co.uk>","date":"2026-01-12T12:26:40","subject":"Re: [PATCH v2 4/4] egl: Print GLES version","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-01-12 10:53:24)\n> 2026. 01. 12. 11:37 keltezéssel, Robert Mader írta:\n> > It might come in handy to know whether 2.0 or e.g. 3.2 is used.\n> > \n> > Signed-off-by: Robert Mader \n> > ---\n> > include/libcamera/internal/egl.h | 1 +\n> > src/libcamera/egl.cpp | 8 ++++++++\n> > 2 files changed, 9 insertions(+)\n> > \n> > diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> > index 21e2aa9df..f007f448a 100644\n> > --- a/include/libcamera/internal/egl.h\n> > +++ b/include/libcamera/internal/egl.h\n> > @@ -136,5 +136,6 @@ private:\n> > PFNGLEGLIMAGETARGETTEXTURE2DOESPROC glEGLImageTargetTexture2DOES;\n> > PFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;\n> > PFNEGLDESTROYIMAGEKHRPROC eglDestroyImageKHR;\n> > + PFNGLGETSTRINGPROC glGetString;\n> > };\n> > } //namespace libcamera\n> > diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> > index a88525279..da563ee09 100644\n> > --- a/src/libcamera/egl.cpp\n> > +++ b/src/libcamera/egl.cpp\n> > @@ -325,6 +325,12 @@ int eGL::initEGLContext(GBM *gbmContext)\n> > goto fail;\n> > }\n> > \n> > + glGetString = (PFNGLGETSTRINGPROC)eglGetProcAddress(\"glGetString\");\n> \n> reinterpret_cast would be preferable imo, but I see the others use the same.\n> \n\nKeeping consistent in the file makes sense indeed.\nA full update could be done later.\n\nReviewed-by: Kieran Bingham \n\n> Reviewed-by: Barnabás Pőcze \n> \n> \n> > + if (!glGetString) {\n> > + LOG(eGL, Error) << \"glGetString not found\";\n> > + goto fail;\n> > + }\n> > +\n> > if (eglChooseConfig(display_, configAttribs, &config, 1, &numConfigs) != EGL_TRUE) {\n> > LOG(eGL, Error) << \"eglChooseConfig fail\";\n> > goto fail;\n> > @@ -340,6 +346,8 @@ int eGL::initEGLContext(GBM *gbmContext)\n> > \n> > makeCurrent();\n> > \n> > + LOG(eGL, Info) << \"EGL: GL_VERSION: \" << glGetString(GL_VERSION);\n> > +\n> > return 0;\n> > fail:\n> > \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D83CBDCBF\n\tfor ;\n\tMon, 12 Jan 2026 12:26:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3C1461FA0;\n\tMon, 12 Jan 2026 13:26:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A986261FA0\n\tfor ;\n\tMon, 12 Jan 2026 13:26:43 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 423A1165B;\n\tMon, 12 Jan 2026 13:26:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IiSg8mKR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768220778;\n\tbh=p3mnhNcAxqoV0ht8KMj/AKu/NN8EU6d/OEGTg0icK8c=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=IiSg8mKR6vVUPQaAvqWJcWzF/s5B81kYFVQ4VteIMhtJCUO0k3rruxtjKtSCHNpjf\n\tlQ5HSk4jo/ElJxnmMqB9MYF43ObzBXddIuPnXG/AQ93u0B+klfAgsTPaJH5KHfRk2B\n\tqUmo2whtJHiJq8HdmnjU9TPvA273JY8TZmkUkkaY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<1beb2677-042e-4c22-9967-54db5c3aaac0@ideasonboard.com>","References":"<20260112103740.18360-1-robert.mader@collabora.com>\n\t<20260112103740.18360-5-robert.mader@collabora.com>\n\t<1beb2677-042e-4c22-9967-54db5c3aaac0@ideasonboard.com>","Subject":"Re: [PATCH v2 4/4] egl: Print GLES version","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tRobert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 12 Jan 2026 12:26:40 +0000","Message-ID":"<176822080065.3486172.2540775710351043219@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37575,"web_url":"https://patchwork.libcamera.org/comment/37575/","msgid":"","date":"2026-01-12T12:33:08","subject":"Re: [PATCH v2 4/4] egl: Print GLES version","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 12/01/2026 10:37, Robert Mader wrote:\n> It might come in handy to know whether 2.0 or e.g. 3.2 is used.\n> \n> Signed-off-by: Robert Mader \n> ---\n> include/libcamera/internal/egl.h | 1 +\n> src/libcamera/egl.cpp | 8 ++++++++\n> 2 files changed, 9 insertions(+)\n> \n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index 21e2aa9df..f007f448a 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -136,5 +136,6 @@ private:\n> \tPFNGLEGLIMAGETARGETTEXTURE2DOESPROC glEGLImageTargetTexture2DOES;\n> \tPFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;\n> \tPFNEGLDESTROYIMAGEKHRPROC eglDestroyImageKHR;\n> +\tPFNGLGETSTRINGPROC glGetString;\n> };\n> } //namespace libcamera\n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index a88525279..da563ee09 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -325,6 +325,12 @@ int eGL::initEGLContext(GBM *gbmContext)\n> \t\tgoto fail;\n> \t}\n> \n> +\tglGetString = (PFNGLGETSTRINGPROC)eglGetProcAddress(\"glGetString\");\n> +\tif (!glGetString) {\n> +\t\tLOG(eGL, Error) << \"glGetString not found\";\n> +\t\tgoto fail;\n> +\t}\n> +\n> \tif (eglChooseConfig(display_, configAttribs, &config, 1, &numConfigs) != EGL_TRUE) {\n> \t\tLOG(eGL, Error) << \"eglChooseConfig fail\";\n> \t\tgoto fail;\n> @@ -340,6 +346,8 @@ int eGL::initEGLContext(GBM *gbmContext)\n> \n> \tmakeCurrent();\n> \n> +\tLOG(eGL, Info) << \"EGL: GL_VERSION: \" << glGetString(GL_VERSION);\n> +\n> \treturn 0;\n> fail:\n> \n> --\n> 2.52.0\n> \nReviewed-by: Bryan O'Donoghue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0871EBDCBF\n\tfor ;\n\tMon, 12 Jan 2026 12:33:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1D0861FB7;\n\tMon, 12 Jan 2026 13:33:14 +0100 (CET)","from tor.source.kernel.org (tor.source.kernel.org\n\t[IPv6:2600:3c04:e001:324:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0915F61FA0\n\tfor ;\n\tMon, 12 Jan 2026 13:33:13 +0100 (CET)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 801406001D;\n\tMon, 12 Jan 2026 12:33:11 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id AE566C16AAE;\n\tMon, 12 Jan 2026 12:33:10 +0000 (UTC)"],"Message-ID":"","Date":"Mon, 12 Jan 2026 12:33:08 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 4/4] egl: Print GLES version","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260112103740.18360-1-robert.mader@collabora.com>\n\t\n\t<20260112103740.18360-5-robert.mader@collabora.com>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<20260112103740.18360-5-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]