[{"id":37566,"web_url":"https://patchwork.libcamera.org/comment/37566/","msgid":"","date":"2026-01-12T10:57:10","subject":"Re: [PATCH v2 3/4] egl: Remove duplicated logging of EGL version","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 12. 11:37 keltezéssel, Robert Mader írta:\n> The line below already prints it.\n> \n> Signed-off-by: Robert Mader \n> ---\n\nLooks good, hopefully the two are indeed consistent.\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/egl.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index fcaf7c58f..a88525279 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -285,8 +285,6 @@ int eGL::initEGLContext(GBM *gbmContext)\n> \n> \tEGLint numConfigs;\n> \tEGLConfig config;\n> -\tEGLint major;\n> -\tEGLint minor;\n> \n> \tif (!eglBindAPI(EGL_OPENGL_ES_API)) {\n> \t\tLOG(eGL, Error) << \"API bind fail\";\n> @@ -299,12 +297,11 @@ int eGL::initEGLContext(GBM *gbmContext)\n> \t\tgoto fail;\n> \t}\n> \n> -\tif (eglInitialize(display_, &major, &minor) != EGL_TRUE) {\n> +\tif (eglInitialize(display_, nullptr, nullptr) != EGL_TRUE) {\n> \t\tLOG(eGL, Error) << \"eglInitialize fail\";\n> \t\tgoto fail;\n> \t}\n> \n> -\tLOG(eGL, Info) << \"EGL: version \" << major << \".\" << minor;\n> \tLOG(eGL, Info) << \"EGL: EGL_VERSION: \" << eglQueryString(display_, EGL_VERSION);\n> \tLOG(eGL, Info) << \"EGL: EGL_VENDOR: \" << eglQueryString(display_, EGL_VENDOR);\n> \tLOG(eGL, Info) << \"EGL: EGL_CLIENT_APIS: \" << eglQueryString(display_, EGL_CLIENT_APIS);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D96BBE08B\n\tfor ;\n\tMon, 12 Jan 2026 10:57:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7DB8961FBB;\n\tMon, 12 Jan 2026 11:57:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0236661F9F\n\tfor ;\n\tMon, 12 Jan 2026 11:57:13 +0100 (CET)","from [192.168.33.29] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C36D63F;\n\tMon, 12 Jan 2026 11:56:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pmIecESQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768215408;\n\tbh=YkVs88iiKIqivPhZ03dzuVeEVAJPRSY8k6A70XId5wg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=pmIecESQcukqHBe8pPj3BFge8XHZUTJrBC+ploKiud+0qHFM9M1Z6xTm9kXglRMh3\n\tC3KnfZQR+zLPKMywpkFSN+lzOtJnAbm1E++FBiYIycxF7Y78kEfylMGUkG3+X5WSYQ\n\t8loigcT+GVHNW3QE5Xezp2X9CqdDKzj4V/DPYO18=","Message-ID":"","Date":"Mon, 12 Jan 2026 11:57:10 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 3/4] egl: Remove duplicated logging of EGL version","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260112103740.18360-1-robert.mader@collabora.com>\n\t<20260112103740.18360-4-robert.mader@collabora.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260112103740.18360-4-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37570,"web_url":"https://patchwork.libcamera.org/comment/37570/","msgid":"<176822069499.3486172.18402437258403389852@ping.linuxembedded.co.uk>","date":"2026-01-12T12:24:54","subject":"Re: [PATCH v2 3/4] egl: Remove duplicated logging of EGL version","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader (2026-01-12 10:37:39)\n> The line below already prints it.\n> \n> Signed-off-by: Robert Mader \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/egl.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index fcaf7c58f..a88525279 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -285,8 +285,6 @@ int eGL::initEGLContext(GBM *gbmContext)\n> \n> EGLint numConfigs;\n> EGLConfig config;\n> - EGLint major;\n> - EGLint minor;\n> \n> if (!eglBindAPI(EGL_OPENGL_ES_API)) {\n> LOG(eGL, Error) << \"API bind fail\";\n> @@ -299,12 +297,11 @@ int eGL::initEGLContext(GBM *gbmContext)\n> goto fail;\n> }\n> \n> - if (eglInitialize(display_, &major, &minor) != EGL_TRUE) {\n> + if (eglInitialize(display_, nullptr, nullptr) != EGL_TRUE) {\n\nI presume these are to support version specific runtime handling. But as\nwe don't have any yet... sure:\n\n\nReviewed-by: Kieran Bingham \n\n> LOG(eGL, Error) << \"eglInitialize fail\";\n> goto fail;\n> }\n> \n> - LOG(eGL, Info) << \"EGL: version \" << major << \".\" << minor;\n> LOG(eGL, Info) << \"EGL: EGL_VERSION: \" << eglQueryString(display_, EGL_VERSION);\n> LOG(eGL, Info) << \"EGL: EGL_VENDOR: \" << eglQueryString(display_, EGL_VENDOR);\n> LOG(eGL, Info) << \"EGL: EGL_CLIENT_APIS: \" << eglQueryString(display_, EGL_CLIENT_APIS);\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF740BE08B\n\tfor ;\n\tMon, 12 Jan 2026 12:24:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64C8961FA0;\n\tMon, 12 Jan 2026 13:24:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F29F6142F\n\tfor ;\n\tMon, 12 Jan 2026 13:24:57 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A749165B;\n\tMon, 12 Jan 2026 13:24:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n7z16dp/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768220672;\n\tbh=gEInXpcuPYNcvNZuU7PkB5l7M+KQV0es6HKM5dZAqYk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=n7z16dp/9twBATewivjsFzJCQNZvZvxCBIN4cuoTeEz9tD4cOMOAW+xSpA673D3D/\n\t490OYl6Jrn7ydzi/fh6Yha1iOKa9WQ5hXvZ4AbT6/+t0ZB6RZWfrh4AUuMxlVLHkJX\n\tON4AIZau+lQO+wc3a5nCXqrFT1IdPkluFl8Oq4Lc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260112103740.18360-4-robert.mader@collabora.com>","References":"<20260112103740.18360-1-robert.mader@collabora.com>\n\t<20260112103740.18360-4-robert.mader@collabora.com>","Subject":"Re: [PATCH v2 3/4] egl: Remove duplicated logging of EGL version","From":"Kieran Bingham ","Cc":"Robert Mader ","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 12 Jan 2026 12:24:54 +0000","Message-ID":"<176822069499.3486172.18402437258403389852@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37574,"web_url":"https://patchwork.libcamera.org/comment/37574/","msgid":"<461b5f8e-8149-493f-b326-0dc094d85d22@linaro.org>","date":"2026-01-12T12:32:38","subject":"Re: [PATCH v2 3/4] egl: Remove duplicated logging of EGL version","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 12/01/2026 10:37, Robert Mader wrote:\n> The line below already prints it.\n> \n> Signed-off-by: Robert Mader \n> ---\n> src/libcamera/egl.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index fcaf7c58f..a88525279 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -285,8 +285,6 @@ int eGL::initEGLContext(GBM *gbmContext)\n> \n> \tEGLint numConfigs;\n> \tEGLConfig config;\n> -\tEGLint major;\n> -\tEGLint minor;\n> \n> \tif (!eglBindAPI(EGL_OPENGL_ES_API)) {\n> \t\tLOG(eGL, Error) << \"API bind fail\";\n> @@ -299,12 +297,11 @@ int eGL::initEGLContext(GBM *gbmContext)\n> \t\tgoto fail;\n> \t}\n> \n> -\tif (eglInitialize(display_, &major, &minor) != EGL_TRUE) {\n> +\tif (eglInitialize(display_, nullptr, nullptr) != EGL_TRUE) {\n> \t\tLOG(eGL, Error) << \"eglInitialize fail\";\n> \t\tgoto fail;\n> \t}\n> \n> -\tLOG(eGL, Info) << \"EGL: version \" << major << \".\" << minor;\n> \tLOG(eGL, Info) << \"EGL: EGL_VERSION: \" << eglQueryString(display_, EGL_VERSION);\n> \tLOG(eGL, Info) << \"EGL: EGL_VENDOR: \" << eglQueryString(display_, EGL_VENDOR);\n> \tLOG(eGL, Info) << \"EGL: EGL_CLIENT_APIS: \" << eglQueryString(display_, EGL_CLIENT_APIS);\n> --\n> 2.52.0\n> \nReviewed-by: Bryan O'Donoghue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89018BDCBF\n\tfor ;\n\tMon, 12 Jan 2026 12:32:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 388E361FC2;\n\tMon, 12 Jan 2026 13:32:41 +0100 (CET)","from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F8AF61FBE\n\tfor ;\n\tMon, 12 Jan 2026 13:32:40 +0100 (CET)","by mail-wr1-x42d.google.com with SMTP id\n\tffacd0b85a97d-432d2c7a8b9so2911078f8f.2\n\tfor ;\n\tMon, 12 Jan 2026 04:32:40 -0800 (PST)","from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-432bd0daa78sm38948138f8f.6.2026.01.12.04.32.38\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 12 Jan 2026 04:32:39 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"klvDFokS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1768221160; x=1768825960;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:to:subject:user-agent:mime-version:date:message-id:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=KQttcCfqLSvKDi+zkwUHIoiwYvmilz5STr8+RPpp/SA=;\n\tb=klvDFokSq7+IaWoCjORdmaCMb5xW6VqYFfsxE0DKAeQyfHMVlEOq3/GbvJrqZWuwvo\n\th2CVMG8J7QKSNYLb+DyjvKwIEevk/EYf4vSUkNXa511RkxxglO3/1VM3PcPzCdFfZq4E\n\tiGkXhdnRVt/b95ce0GbrmdXbYbYdGBjNb8g9MBb5NYN2WcgS1GCGKTLEUIXHpFfIBWNL\n\tx0RAaQKUijTzzHYjABOZWpq4dFAL4XDhLKNADWs7s8C9sdDBlQ8N3/Mpzdp0yFJLawWd\n\tmlTmpV4uU9/l01MnVEUYLd63ZnfkRve5UsG574ETcPXrBp4CtwDTzJOaKk1nTlkBGgkh\n\t0KIQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1768221160; x=1768825960;\n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=KQttcCfqLSvKDi+zkwUHIoiwYvmilz5STr8+RPpp/SA=;\n\tb=jxws2MKkMYAlS45cZpxH1yq5tgtH8KFm+1g0Snberi1FC2asl31IaOZg3nwCbqpE8v\n\tYWvaWFonCJscz6T8MvO1fYYbO7m+90jcoNL0UX+fnZM5JOFM0gtgvXgQG5ZBFWsPk+OO\n\tAcu3TKrrhf0gHFeF8dlg7s1afvtEOyvY7pfiQ67shLHHpumWpwWv2MJSKwQNi1eqri29\n\tD+UHsMriK7KCTS2dvu22yqPTfciy0sjgE/u4mccVW995k08WA3he4KPmFlpX9wFIofFc\n\tba/Ih17gOnIucSbVImucxLIynRrkMNEUnJg2UcN81RHy8mgOAIvRz3JUFgc5YTJIWnni\n\tO2og==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCWcoY5gbspY7dUN4gGHDjW1plkM97jPZjLGCBlMUGifNAWkhepkIvwyFr6HS9/7LxTRTlVsouQVE5mhDs/eBD0=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YxZygF08ghDYnCYpv86tvwgj4i7o2x528k5Xl5Lie7lekXcc7IM\n\tdN0SW/iVXBfpGXm1j2VXS60mpt5P0BB6ESNoJPHOvFkVHhxNCZQjMdL0sn95zVPjYjwozxqLgaK\n\tK5clxd8g=","X-Gm-Gg":"AY/fxX6SoEtiZrZsNQpS4rahcItg8Tt4nT9fRfS3VL7cptvDy9eKx1b3TWV7bXM2Fyg\n\tUw3RqxymTxcCNYemtU78YP0DK2g8lpBKYdLB+49X5fo/0LfVuyFUuX77zzyA7ucNCFZ6abUWBuk\n\tMt5Km/oPMmU2VRLQOPW643+UBPKxH1AY8TALC7GQOqq+JMMTeXg8z33TJ5hmko8YgcZzXOMp5wt\n\tiYmyEd/jChNm5+WFqbCFMzJiI1CKayF/FnU5T83VhtapnUC5t7wVIXdKRfkhPM7QCfjLSPkGYLN\n\tcwt8OEo/Fg410j0VAzmt8rEYV+TGMIRP6S8h0JAWRGQ7T8A0ESKYneZGIumF0XEK/cjpKTPCW34\n\t7L2xzrwaU1RyUfmTsNXA6FZKoiFlULXpTtyhq/tp0SE/kSj8bjGj4QEc7zSizDhA5jK6zmchjFt\n\tzosr8NX5rGTWLJIN78uNOxeq0/INpuH8XHASXJRh4qbmQf0vobX1Xo","X-Google-Smtp-Source":"AGHT+IGdb19MX+kddc6MEk4WVt42EA8KBPrNXhN39bHZFYpAXx9xU+fNFDd4IHvq29Bidb/AhJbQIw==","X-Received":"by 2002:a05:6000:25c1:b0:430:ff81:2961 with SMTP id\n\tffacd0b85a97d-432c379b6b7mr20776250f8f.51.1768221159637; \n\tMon, 12 Jan 2026 04:32:39 -0800 (PST)","Message-ID":"<461b5f8e-8149-493f-b326-0dc094d85d22@linaro.org>","Date":"Mon, 12 Jan 2026 12:32:38 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 3/4] egl: Remove duplicated logging of EGL version","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260112103740.18360-1-robert.mader@collabora.com>\n\t\n\t<20260112103740.18360-4-robert.mader@collabora.com>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<20260112103740.18360-4-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]