{"id":25718,"url":"https://patchwork.libcamera.org/api/patches/25718/?format=json","web_url":"https://patchwork.libcamera.org/patch/25718/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260112103740.18360-4-robert.mader@collabora.com>","date":"2026-01-12T10:37:39","name":"[v2,3/4] egl: Remove duplicated logging of EGL version","commit_ref":"07335cbeb11f9cf0941e895c9207e2c00f7115b6","pull_url":null,"state":"accepted","archived":false,"hash":"df68f99c41994da569e493ad7059bf74898abb1a","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/?format=json","name":"Robert Mader","email":"robert.mader@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25718/mbox/","series":[{"id":5702,"url":"https://patchwork.libcamera.org/api/series/5702/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5702","date":"2026-01-12T10:37:36","name":"GPUISP cleanups","version":2,"mbox":"https://patchwork.libcamera.org/series/5702/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25718/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25718/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACAE4C323E\n\tfor ;\n\tMon, 12 Jan 2026 10:38:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BEE961FC4;\n\tMon, 12 Jan 2026 11:38:19 +0100 (CET)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E7B761FBE\n\tfor ;\n\tMon, 12 Jan 2026 11:38:16 +0100 (CET)","by mx.zohomail.com with SMTPS id 176821429312935.5066968926659;\n\tMon, 12 Jan 2026 02:38:13 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"Eprugc54\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1768214293; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=fd/Z/OEi7HzpJETXO2xo+TDzpKHceHJ5swDY7kV2dG+DMcHN65rxVHA8CD4zUO0TGlLzvcHII0fL+bjg5754t/Rh46PFizixJJ+6yn/wP3LxXhswlHs+tmJj9pTWUdyLudCBZUIJAPcWr2SGdCGH3aHvSYUV7B/IgqmkCUIdARU=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1768214293;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=M0yxTdv3AR3OUpRuELbtNefryxLkD/pC0IsO5BPWkLk=; \n\tb=EajBegscG+xNI2FXrkuPcbgN3Em68YCVcIbeSbMY0drJlN0sm+RupbYWZzNLfsh47nGlAf2Jk2s/c9jMPSHJqwCGgWmsrz6Iewjyh2X9OZ+DBhFJGUxKkkPpktVSNCQ9c0mxXOCRdFAv9gQlu5TsSCNEsPdAKEk+AGHCr7DVcQA=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768214293;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=M0yxTdv3AR3OUpRuELbtNefryxLkD/pC0IsO5BPWkLk=;\n\tb=Eprugc54gtkm0RUFe7IOjLIigoUJR3avwxIOkYlrkKSublo/MonjVrG+3dyjnlwk\n\tLJ/c3CrbbcdiG4e61RwK9/9Bbtz781QXQEuShOhuF+37OGYhLOKgMCkl1D3EkcssB+z\n\tl7WTNudhJ0D3mSMrRbWS+HUOBQwTAm+8+RqOMk6s=","From":"Robert Mader ","To":"libcamera-devel@lists.libcamera.org","Cc":"Robert Mader ","Subject":"[PATCH v2 3/4] egl: Remove duplicated logging of EGL version","Date":"Mon, 12 Jan 2026 11:37:39 +0100","Message-ID":"<20260112103740.18360-4-robert.mader@collabora.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260112103740.18360-1-robert.mader@collabora.com>","References":"<20260112103740.18360-1-robert.mader@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The line below already prints it.\n\nSigned-off-by: Robert Mader \n---\n src/libcamera/egl.cpp | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex fcaf7c58f..a88525279 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -285,8 +285,6 @@ int eGL::initEGLContext(GBM *gbmContext)\n \n \tEGLint numConfigs;\n \tEGLConfig config;\n-\tEGLint major;\n-\tEGLint minor;\n \n \tif (!eglBindAPI(EGL_OPENGL_ES_API)) {\n \t\tLOG(eGL, Error) << \"API bind fail\";\n@@ -299,12 +297,11 @@ int eGL::initEGLContext(GBM *gbmContext)\n \t\tgoto fail;\n \t}\n \n-\tif (eglInitialize(display_, &major, &minor) != EGL_TRUE) {\n+\tif (eglInitialize(display_, nullptr, nullptr) != EGL_TRUE) {\n \t\tLOG(eGL, Error) << \"eglInitialize fail\";\n \t\tgoto fail;\n \t}\n \n-\tLOG(eGL, Info) << \"EGL: version \" << major << \".\" << minor;\n \tLOG(eGL, Info) << \"EGL: EGL_VERSION: \" << eglQueryString(display_, EGL_VERSION);\n \tLOG(eGL, Info) << \"EGL: EGL_VENDOR: \" << eglQueryString(display_, EGL_VENDOR);\n \tLOG(eGL, Info) << \"EGL: EGL_CLIENT_APIS: \" << eglQueryString(display_, EGL_CLIENT_APIS);\n","prefixes":["v2","3/4"]}