[{"id":37569,"web_url":"https://patchwork.libcamera.org/comment/37569/","msgid":"<176822061241.3486172.12186087014654242203@ping.linuxembedded.co.uk>","date":"2026-01-12T12:23:32","subject":"Re: [PATCH v2 2/4] egl: Remove bpp variable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader (2026-01-12 10:37:38)\n> It's unused and, in one case, was set wrongly.\n> \n> Signed-off-by: Robert Mader \n> Reviewed-by: Hans de Goede \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/egl.h | 6 ++----\n> src/libcamera/software_isp/debayer_egl.cpp | 4 ++--\n> 2 files changed, 4 insertions(+), 6 deletions(-)\n> \n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index 7b810773c..21e2aa9df 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -49,14 +49,13 @@ public:\n> * \\brief Construct an eGLImage with explicit stride\n> * \\param[in] width Image width in pixels\n> * \\param[in] height Image height in pixels\n> - * \\param[in] bpp Bytes per pixel\n> * \\param[in] stride Row stride in bytes\n> * \\param[in] texture_unit OpenGL texture unit\n> * \\param[in] texture_unit_uniform_id Shader uniform ID\n> */\n> - eGLImage(uint32_t width, uint32_t height, uint32_t bpp, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n> + eGLImage(uint32_t width, uint32_t height, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n> : width_(width), height_(height), stride_(stride),\n> - framesize_(stride * height), bpp_(bpp),\n> + framesize_(stride * height),\n> texture_unit_uniform_id_(texture_unit_uniform_id),\n> texture_unit_(texture_unit)\n> {\n> @@ -81,7 +80,6 @@ public:\n> uint32_t stride_; /**< Row stride in bytes */\n> uint32_t offset_; /**< Buffer offset (reserved for future use) */\n> uint32_t framesize_; /**< Total frame size in bytes (stride * height) */\n> - uint32_t bpp_; /**< Bytes per pixel */\n> uint32_t texture_unit_uniform_id_; /**< Shader uniform id for texture unit */\n> GLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n> GLuint texture_; /**< OpenGL texture object ID */\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 1c13b72a5..9693d7252 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -597,10 +597,10 @@ int DebayerEGL::start()\n> LOG(Debayer, Debug) << \"Available fragment shader texture units \" << maxTextureImageUnits;\n> \n> /* Raw bayer input as texture */\n> - eglImageBayerIn_ = std::make_unique(width_, height_, 32, inputConfig_.stride, GL_TEXTURE0, 0);\n> + eglImageBayerIn_ = std::make_unique(width_, height_, inputConfig_.stride, GL_TEXTURE0, 0);\n> \n> /* Texture we will render to */\n> - eglImageBayerOut_ = std::make_unique(outputSize_.width, outputSize_.height, 31, outputConfig_.stride, GL_TEXTURE1, 1);\n> + eglImageBayerOut_ = std::make_unique(outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1);\n> \n> if (initBayerShaders(inputPixelFormat_, outputPixelFormat_))\n> return -EINVAL;\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78FEDBE08B\n\tfor ;\n\tMon, 12 Jan 2026 12:23:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A061961FBB;\n\tMon, 12 Jan 2026 13:23:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 921A86142F\n\tfor ;\n\tMon, 12 Jan 2026 13:23:35 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28DD6165B;\n\tMon, 12 Jan 2026 13:23:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c8bAVhoX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768220590;\n\tbh=69adYE5Hq9wdYSx+eRbEwVmS3dAq8bDmOI80/NZhLdU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=c8bAVhoXw1x/dSNqynUBCRiXXJryWwXPxE85j1vnzarAZ+A0mw25W7DIfhtK9jHJT\n\turcECwP8mcbH3527TDKFoihA8lYdMXrvLRdvzIwFVmidhk00efpf2I8FwRRjgra/Db\n\t8GS5x0A7JNd0lTwD3lxG9HDqUmacDlImDKa6gAbA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260112103740.18360-3-robert.mader@collabora.com>","References":"<20260112103740.18360-1-robert.mader@collabora.com>\n\t<20260112103740.18360-3-robert.mader@collabora.com>","Subject":"Re: [PATCH v2 2/4] egl: Remove bpp variable","From":"Kieran Bingham ","Cc":"Robert Mader ,\n\tHans de Goede ","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 12 Jan 2026 12:23:32 +0000","Message-ID":"<176822061241.3486172.12186087014654242203@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37573,"web_url":"https://patchwork.libcamera.org/comment/37573/","msgid":"<65c59b23-c408-42f8-bfa2-f04e32280594@nxsw.ie>","date":"2026-01-12T12:32:06","subject":"Re: [PATCH v2 2/4] egl: Remove bpp variable","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 12/01/2026 10:37, Robert Mader wrote:\n> It's unused and, in one case, was set wrongly.\n> \n> Signed-off-by: Robert Mader \n> Reviewed-by: Hans de Goede \n> ---\n> include/libcamera/internal/egl.h | 6 ++----\n> src/libcamera/software_isp/debayer_egl.cpp | 4 ++--\n> 2 files changed, 4 insertions(+), 6 deletions(-)\n> \n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index 7b810773c..21e2aa9df 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -49,14 +49,13 @@ public:\n> \t * \\brief Construct an eGLImage with explicit stride\n> \t * \\param[in] width Image width in pixels\n> \t * \\param[in] height Image height in pixels\n> -\t * \\param[in] bpp Bytes per pixel\n> \t * \\param[in] stride Row stride in bytes\n> \t * \\param[in] texture_unit OpenGL texture unit\n> \t * \\param[in] texture_unit_uniform_id Shader uniform ID\n> \t */\n> -\teGLImage(uint32_t width, uint32_t height, uint32_t bpp, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n> +\teGLImage(uint32_t width, uint32_t height, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n> \t\t: width_(width), height_(height), stride_(stride),\n> -\t\t framesize_(stride * height), bpp_(bpp),\n> +\t\t framesize_(stride * height),\n> \t\t texture_unit_uniform_id_(texture_unit_uniform_id),\n> \t\t texture_unit_(texture_unit)\n> \t{\n> @@ -81,7 +80,6 @@ public:\n> \tuint32_t stride_; /**< Row stride in bytes */\n> \tuint32_t offset_; /**< Buffer offset (reserved for future use) */\n> \tuint32_t framesize_; /**< Total frame size in bytes (stride * height) */\n> -\tuint32_t bpp_; /**< Bytes per pixel */\n> \tuint32_t texture_unit_uniform_id_; /**< Shader uniform id for texture unit */\n> \tGLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n> \tGLuint texture_; /**< OpenGL texture object ID */\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 1c13b72a5..9693d7252 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -597,10 +597,10 @@ int DebayerEGL::start()\n> \tLOG(Debayer, Debug) << \"Available fragment shader texture units \" << maxTextureImageUnits;\n> \n> \t/* Raw bayer input as texture */\n> -\teglImageBayerIn_ = std::make_unique(width_, height_, 32, inputConfig_.stride, GL_TEXTURE0, 0);\n> +\teglImageBayerIn_ = std::make_unique(width_, height_, inputConfig_.stride, GL_TEXTURE0, 0);\n> \n> \t/* Texture we will render to */\n> -\teglImageBayerOut_ = std::make_unique(outputSize_.width, outputSize_.height, 31, outputConfig_.stride, GL_TEXTURE1, 1);\n> +\teglImageBayerOut_ = std::make_unique(outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1);\n> \n> \tif (initBayerShaders(inputPixelFormat_, outputPixelFormat_))\n> \t\treturn -EINVAL;\n> --\n> 2.52.0\n> \nReviewed-by: Bryan O'Donoghue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03504BDCBF\n\tfor ;\n\tMon, 12 Jan 2026 12:32:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2A5661FC6;\n\tMon, 12 Jan 2026 13:32:12 +0100 (CET)","from sea.source.kernel.org (sea.source.kernel.org\n\t[IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B90A61FA0\n\tfor ;\n\tMon, 12 Jan 2026 13:32:10 +0100 (CET)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id EAA184374F;\n\tMon, 12 Jan 2026 12:32:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 23047C16AAE;\n\tMon, 12 Jan 2026 12:32:07 +0000 (UTC)"],"Message-ID":"<65c59b23-c408-42f8-bfa2-f04e32280594@nxsw.ie>","Date":"Mon, 12 Jan 2026 12:32:06 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 2/4] egl: Remove bpp variable","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Hans de Goede ","References":"<20260112103740.18360-1-robert.mader@collabora.com>\n\t\n\t<20260112103740.18360-3-robert.mader@collabora.com>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<20260112103740.18360-3-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]