[{"id":37572,"web_url":"https://patchwork.libcamera.org/comment/37572/","msgid":"","date":"2026-01-12T12:31:43","subject":"Re: [PATCH v2 1/4] egl: Remove unused functions","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 12/01/2026 10:37, Robert Mader wrote:\n> They are left-overs from older iterations of the GPU-ISP.\n> \n> Signed-off-by: Robert Mader \n> Reviewed-by: Hans de Goede \n> Reviewed-by: Barnabás Pőcze \n> ---\n> include/libcamera/internal/egl.h | 10 ----------\n> src/libcamera/egl.cpp | 10 ----------\n> src/libcamera/software_isp/debayer_egl.cpp | 2 --\n> 3 files changed, 22 deletions(-)\n> \n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index a92921123..7b810773c 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -64,15 +64,6 @@ public:\n> \t\tglGenFramebuffers(1, &fbo_);\n> \t}\n> \n> -\t/**\n> -\t * \\brief Construct an eGLImage with automatic stride calculation\n> -\t */\n> -\teGLImage(uint32_t width, uint32_t height, uint32_t bpp, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n> -\t\t: eGLImage(width, height, bpp, utils::alignUp(width * bpp / 8, 256),\n> -\t\t\t texture_unit, texture_unit_uniform_id)\n> -\t{\n> -\t}\n> -\n> \t/**\n> \t * \\brief Destroy the eGLImage\n> \t *\n> @@ -108,7 +99,6 @@ public:\n> \t~eGL();\n> \n> \tint initEGLContext(GBM *gbmContext);\n> -\tvoid cleanUp();\n> \n> \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n> \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index 0544056bd..fcaf7c58f 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -349,16 +349,6 @@ fail:\n> \treturn -ENODEV;\n> }\n> \n> -/**\n> - * \\brief Clean up EGL resources\n> - *\n> - * Destroys the EGL sync object. Must be called from the same thread\n> - * that created the EGL context.\n> - */\n> -void eGL::cleanUp()\n> -{\n> -}\n> -\n> /**\n> * \\brief Make the EGL context current for the calling thread\n> *\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 8e0890323..1c13b72a5 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -615,8 +615,6 @@ void DebayerEGL::stop()\n> \n> \tif (programId_)\n> \t\tglDeleteProgram(programId_);\n> -\n> -\tegl_.cleanUp();\n> }\n> \n> SizeRange DebayerEGL::sizes(PixelFormat inputFormat, const Size &inputSize)\n> --\n> 2.52.0\n> \nReviewed-by: Bryan O'Donoghue ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E156BDCBF\n\tfor ;\n\tMon, 12 Jan 2026 12:31:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1E6C61FB7;\n\tMon, 12 Jan 2026 13:31:46 +0100 (CET)","from mail-ej1-x629.google.com (mail-ej1-x629.google.com\n\t[IPv6:2a00:1450:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A064961FA0\n\tfor ;\n\tMon, 12 Jan 2026 13:31:45 +0100 (CET)","by mail-ej1-x629.google.com with SMTP id\n\ta640c23a62f3a-b86f81d8051so263390466b.1\n\tfor ;\n\tMon, 12 Jan 2026 04:31:45 -0800 (PST)","from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b8701e1d467sm560691766b.70.2026.01.12.04.31.44\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tMon, 12 Jan 2026 04:31:44 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"H+TMZAjR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1768221105; x=1768825905;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=L2TUSH/GA6fupd4oTfPngPa1CJL5s9thYrYugUFIF84=;\n\tb=H+TMZAjRbYZLmCvfZL7Q48Ac1upv3DGm5sPbXWt7zsE26yD9qwm3YKjz90xdOncJ0c\n\t9qU5SnPbapLmh7SLGNOTaKGievxnnh6pHd0zMMkyQVZzhZwr4WKDAtAHYSge/Jrj3Om4\n\tUN2G3xY5ILuOMV131XoNkEyegtcml/pe+jz85vaPvIqDu1/eNX9+ocOcwZYKvOvGsNDK\n\tvrrYy1C3uMPJJA9en9KB9EGG7ntgt3cppSUEdsh/I7/F6CEWnu9OMceNmV1AQPgPn/LJ\n\tJm9Bj4I/oVbqOeKGBAJvv1FhelwJl+bwkBvh3rUI8ALzzYxIu/tfOovzyk5QyG69CjhO\n\tvpzg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1768221105; x=1768825905;\n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=L2TUSH/GA6fupd4oTfPngPa1CJL5s9thYrYugUFIF84=;\n\tb=naip02ovY2v4sxtKQbNiq1ArGU1AZ9tlOJ/9rVduvITmcyZbEYyWmdgd6qAl5kZ5Ra\n\t4uM1hUGIYXVXr9FpPeZaJMQLH3wMAiEGmHzEeclEf/eX7LqcbILSmh38YKAlBz53Xb3r\n\tdsU+1SKQFT4h5VWZd8AeFvfFRJYmFv9eGfqC0t9kks7OW13ojO6WEZNiespYY8Jaw2Pc\n\t4rtqhcf8DYuYWjpmZ1JC75Yecf9Ad2W3AAqtNiDN28Sg5r2plaZ0OxxnNlxcTZZtbdFq\n\tWXp6hfz33gA93RzF93WSPkfqHTsWl5Yp0IISmgmRdprPJpgNZuw0jB4w9yFxUbTqgvQe\n\tEA0Q==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCV63Vqzxh8d1mhZMipk9612255CwfNv1gLaypk+Dx/lpDrD/axOvhFjXleg9wzuNiIi34lGtEmzQaOrIRxKtRY=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YzzV4zzySSpiruQ6F82vvaDsi9t+9tgo/ub4corIQ4DxaMjnhY6\n\t/2dvglBGwxu6U1v9wVnD9qWtT8tIYMzMaXXT9II8OyxKZxvKjh7P9QhRr1AjhNGj7lY=","X-Gm-Gg":"AY/fxX7Gs3oU4L1cDkIMTjBWqT351xqYPewxCNQy3bOYAow/Calj6trrngaZw+XQKaJ\n\taGS/0F0fnKvDaH1IkIwXtPQCqqBEx+ZFEje46YiP+rLjXZwEKtfax/wfoiPHwCXIb7C5ZmExD78\n\tp58mL11Hu9lFkRxtjO+Em0e4vWOOuioqlTLo9m5xCcUDU6O+l6qC0g7bzD7P728YNi/2ELhdo6F\n\tnoxxQj794QUEm2qPiSoWC000jBpfp5SnHbeZuX0jPzfEbyZl7bU3QuuSv+QBeEqhcxtvK00GXnj\n\t9A7H1jdWOmqidkYDeubavkl/wWRf0ewTlxcbxv/W6QlQE6uoPlH7rAduv97Emn89i8M/3OqqK0/\n\t+K06NThr8pujQnd5rv1Y3va2Z4tZDJjcHlTeDHsg5apsypIa4Jtvj+s0CFcmUxa3drpQrJspsIV\n\tO0GfTPqaKZ+mSfwFSw4Tca53RJEmTBicoxV8oiyxjZ5slYY030jjQ1L0d6cx+Y0OA=","X-Google-Smtp-Source":"AGHT+IHHpFlVuMfM4EzGg26EnuIjyPpbm4QX1jJVbYaaGfxGXT9dKDL0CAdDJDwAhmMIEVBoF/1yrA==","X-Received":"by 2002:a17:907:86ac:b0:b87:2882:bf7e with SMTP id\n\ta640c23a62f3a-b872882c3bamr189938366b.11.1768221104893; \n\tMon, 12 Jan 2026 04:31:44 -0800 (PST)","Message-ID":"","Date":"Mon, 12 Jan 2026 12:31:43 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/4] egl: Remove unused functions","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Hans de Goede , =?utf-8?q?Barnab?=\n\t=?utf-8?b?w6FzIFDFkWN6ZQ==?= ","References":"<20260112103740.18360-1-robert.mader@collabora.com>\n\t\n\t<20260112103740.18360-2-robert.mader@collabora.com>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<20260112103740.18360-2-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]