{"id":25712,"url":"https://patchwork.libcamera.org/api/patches/25712/?format=json","web_url":"https://patchwork.libcamera.org/patch/25712/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260110221337.145378-1-robert.mader@collabora.com>","date":"2026-01-10T22:13:36","name":"[1/2] egl: Use the Mesa surfaceless platform instead of GBM","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"76b72f647159944eac995da759fae13154323d18","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/?format=json","name":"Robert Mader","email":"robert.mader@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25712/mbox/","series":[{"id":5700,"url":"https://patchwork.libcamera.org/api/series/5700/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5700","date":"2026-01-10T22:13:36","name":"[1/2] egl: Use the Mesa surfaceless platform instead of GBM","version":1,"mbox":"https://patchwork.libcamera.org/series/5700/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25712/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25712/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97A75BDCBF\n\tfor ;\n\tSat, 10 Jan 2026 22:14:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB50B61FA0;\n\tSat, 10 Jan 2026 23:14:06 +0100 (CET)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D53AB61A35\n\tfor ;\n\tSat, 10 Jan 2026 23:14:04 +0100 (CET)","by mx.zohomail.com with SMTPS id 1768083239161604.506332273738;\n\tSat, 10 Jan 2026 14:13:59 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"YpclywkI\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1768083240; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=YSZrlCqGKH+yLNladjjY15nPQ0+asiIZzaEsXWrkx6aDVuPXUhIldziWpR0u3wFk6lAy1x5nwGuiOQ/X/MgFwEK0tbEPK5r1Ibm11506Xjf+rBUAnGcvjVQdcAJ7kylOD9GXwNcjDaH4k5rP+BN0kZpMQwL/zZOXvTx3MsB0Ejg=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1768083240;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=USnnGUxMn80iI+SxSSUSFxB0RK7h4M33qz+GLMb65/0=; \n\tb=bmxv4ubpvhUEKnQv01Nuh/RFpxahUyXcaeWb6CrzFh6HeW1PosjnU8dvLzjH8YorXoMU0e4zpJ7HktRehbNysbM5ZFSN7ZTHLUhW0mLS4TyoEWxK54iVpjgVOd9nrti/EIlbyEGehzNkWhOWW3gUBQogOi/heFaE4UBsbsn1ckk=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768083240;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=USnnGUxMn80iI+SxSSUSFxB0RK7h4M33qz+GLMb65/0=;\n\tb=YpclywkIX1BAqv7NZCGK7aASRgzIXoEb9QqvLMt9Vc4nkNKM7+LKX+CNu7xy/JhT\n\tUNKvIKbBW9wiwu3/5Yf9YSIqystQfxvQlSgRO6wyiAm3j6smZgjdDXnDrPp/RaOyKhi\n\tlqLdbO0SShq0NAJ9FcYrqnZV9fyRvTzPEsjAJCvY=","From":"Robert Mader ","To":"libcamera-devel@lists.libcamera.org","Cc":"Robert Mader ","Subject":"[PATCH 1/2] egl: Use the Mesa surfaceless platform instead of GBM","Date":"Sat, 10 Jan 2026 23:13:36 +0100","Message-ID":"<20260110221337.145378-1-robert.mader@collabora.com>","X-Mailer":"git-send-email 2.52.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Which appears to be a better fit for the use-case at hand:\n1. Like GBM it is Mesa specific, so no change in supported setups is\n expected. If ever required, a fallback to the generic device platform\n could be added on top.\n2. It leaves the complexity of selecting a renderer device to the\n driver, reducing code and dependencies.\n3. It allows to use llvmpipe / software drivers without dri device,\n which can be useful on CI or debugging (with LIBGL_ALWAYS_SOFTWARE=1).\n\nSigned-off-by: Robert Mader \n\n---\n\nShould be applied on to of\nhttps://patchwork.libcamera.org/cover/25706/\n---\n include/libcamera/internal/egl.h | 4 +---\n src/libcamera/egl.cpp | 12 +++++-------\n src/libcamera/software_isp/debayer_egl.cpp | 7 ++-----\n src/libcamera/software_isp/debayer_egl.h | 1 -\n 4 files changed, 8 insertions(+), 16 deletions(-)","diff":"diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex f007f448a..630345ea7 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -16,8 +16,6 @@\n #include \n #include \n \n-#include \"libcamera/internal/gbm.h\"\n-\n #define EGL_EGLEXT_PROTOTYPES\n #include \n #include \n@@ -96,7 +94,7 @@ public:\n \teGL();\n \t~eGL();\n \n-\tint initEGLContext(GBM *gbmContext);\n+\tint initEGLContext();\n \n \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 0ffd008c7..19c5ff48f 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -256,24 +256,22 @@ void eGL::createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint\n \n /**\n * \\brief Initialise the EGL context\n- * \\param[in] gbmContext Pointer to initialised GBM context\n *\n- * Sets up the EGL display from the GBM device, creates an OpenGL ES 2.0\n- * context, and retrieves function pointers for required extensions\n- * including:\n+ * Sets up the EGL display, creates an OpenGL ES 2.0 context, and retrieves\n+ * function pointers for required extensions including:\n * - eglCreateImageKHR / eglDestroyImageKHR\n * - glEGLImageTargetTexture2DOES\n *\n * \\return 0 on success, or -ENODEV on failure\n */\n-int eGL::initEGLContext(GBM *gbmContext)\n+int eGL::initEGLContext()\n {\n \tEGLint configAttribs[] = {\n \t\tEGL_RED_SIZE, 8,\n \t\tEGL_GREEN_SIZE, 8,\n \t\tEGL_BLUE_SIZE, 8,\n \t\tEGL_ALPHA_SIZE, 8,\n-\t\tEGL_SURFACE_TYPE, EGL_WINDOW_BIT,\n+\t\tEGL_SURFACE_TYPE, EGL_PBUFFER_BIT,\n \t\tEGL_RENDERABLE_TYPE, EGL_OPENGL_ES2_BIT,\n \t\tEGL_NONE\n \t};\n@@ -297,7 +295,7 @@ int eGL::initEGLContext(GBM *gbmContext)\n \t\tgoto fail;\n \t}\n \n-\tdisplay_ = eglGetDisplay(gbmContext->device());\n+\tdisplay_ = eglGetPlatformDisplay(EGL_PLATFORM_SURFACELESS_MESA, nullptr, nullptr);\n \tif (display_ == EGL_NO_DISPLAY) {\n \t\tLOG(eGL, Error) << \"Unable to get EGL display\";\n \t\tgoto fail;\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 9693d7252..c85c7d6cd 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -142,7 +142,7 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm\n \n \t/*\n \t * Tell shaders how to re-order output taking account of how the\n-\t * pixels are actually stored by GBM\n+\t * pixels are actually stored by EGL\n \t */\n \tswitch (outputFormat) {\n \tcase formats::ARGB8888:\n@@ -586,10 +586,7 @@ int DebayerEGL::start()\n {\n \tGLint maxTextureImageUnits;\n \n-\tif (gbmSurface_.createDevice())\n-\t\treturn -ENODEV;\n-\n-\tif (egl_.initEGLContext(&gbmSurface_))\n+\tif (egl_.initEGLContext())\n \t\treturn -ENODEV;\n \n \tglGetIntegerv(GL_MAX_TEXTURE_IMAGE_UNITS, &maxTextureImageUnits);\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex a5033bc63..cfbaf8e9d 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -113,7 +113,6 @@ private:\n \tRectangle window_;\n \tstd::unique_ptr stats_;\n \teGL egl_;\n-\tGBM gbmSurface_;\n \tuint32_t width_;\n \tuint32_t height_;\n \tGLint glFormat_;\n","prefixes":["1/2"]}