[{"id":37549,"web_url":"https://patchwork.libcamera.org/comment/37549/","msgid":"<f27bd0cc-e3e1-4d34-9a5f-2c7a7704ad55@oss.qualcomm.com>","date":"2026-01-10T19:36:48","subject":"Re: [PATCH 3/4] egl: Remove duplicated logging of EGL version","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"content":"Hi,\n\nOn 10-Jan-26 18:09, Robert Mader wrote:\n> The line above already prints it.\n> \n> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n\nThanks, patch looks good to me:\n\nReviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n\nRegards,\n\nHans\n\n\n\n> ---\n>  src/libcamera/egl.cpp | 1 -\n>  1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index fcaf7c58f..0bd9a83be 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -305,7 +305,6 @@ int eGL::initEGLContext(GBM *gbmContext)\n>  \t}\n>  \n>  \tLOG(eGL, Info) << \"EGL: version \" << major << \".\" << minor;\n> -\tLOG(eGL, Info) << \"EGL: EGL_VERSION: \" << eglQueryString(display_, EGL_VERSION);\n>  \tLOG(eGL, Info) << \"EGL: EGL_VENDOR: \" << eglQueryString(display_, EGL_VENDOR);\n>  \tLOG(eGL, Info) << \"EGL: EGL_CLIENT_APIS: \" << eglQueryString(display_, EGL_CLIENT_APIS);\n>  \tLOG(eGL, Info) << \"EGL: EGL_EXTENSIONS: \" << eglQueryString(display_, EGL_EXTENSIONS);","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2471CBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 10 Jan 2026 19:36:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8307461FC3;\n\tSat, 10 Jan 2026 20:36:54 +0100 (CET)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E95561A35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 10 Jan 2026 20:36:52 +0100 (CET)","from pps.filterd (m0279866.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t60ABMGZE3263861 for <libcamera-devel@lists.libcamera.org>;\n\tSat, 10 Jan 2026 19:36:51 GMT","from mail-qk1-f199.google.com (mail-qk1-f199.google.com\n\t[209.85.222.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bkntugkjy-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 10 Jan 2026 19:36:50 +0000 (GMT)","by mail-qk1-f199.google.com with SMTP id\n\taf79cd13be357-8b2217a9c60so1370477785a.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 10 Jan 2026 11:36:50 -0800 (PST)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b842a4d1c61sm1434919366b.35.2026.01.10.11.36.48\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tSat, 10 Jan 2026 11:36:49 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"XEPKxL8k\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"B0TcKSJ2\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcontent-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tKeWKC4Gdz8P/z2wnOMBzMSUHXDXKgy/9nYZB7pXAloE=; b=XEPKxL8k16L1kZZB\n\tloZTLoAsml60Kta/nwJe2xZY6i6yU+sF+tX/ivNKxPFYziFYiLtoOiTMV2GjOYMu\n\tNCskn4NYmUHwz1T/5eAZMrUcAG/BnbndJJaEgv1CBpESeHFVmMhJLRTEdeo+0k0E\n\tgkedmvgCKTfSoMr3C1O9//vRiJafVU8jwmk+kS70FsM//IWqNmpFEyTmtccWfXR3\n\t/8dmheYxkbLUwed/DEf2KLI16RyjH/TJ96Q25MeR6O8smD3RZSZAx9O/LFquNYyE\n\t8/f7sMv2avAqALnyBRUsVtHVnu25ZdAXWjxOzsHwMHVMqwwyP586Ki63ZrWa5IMP\n\t21952A==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1768073810; x=1768678610;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:to:subject:from:user-agent:mime-version:date:message-id:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=KeWKC4Gdz8P/z2wnOMBzMSUHXDXKgy/9nYZB7pXAloE=;\n\tb=B0TcKSJ2qjZoPIyyYPL2aXwCklbTZMmwxeR34JShWLFKpPH6bOOlE8B/4IMw/6V037\n\tUDXYkh9bHx8PZz/XUh3wpm3LVROLT96M9y6Hqy7Xa0qKC26OsdMtdPjpLftoto9AseQs\n\tDkIbcFB9aJ8ag692HkMgAsRmTMhy/BJYw9IlNZGgrWbG9jBbKH7XU686BkP2JGFEzGMu\n\t2AQZJXpwGNyYujOE09uT6oSBerRlmV064f7DdyrO32h59AAtcIc6uTZ2TPmbX6bPctWK\n\tdA7S+0/iHT+JmJ77fUfdKWp+J52rnkl6ylLONl5FTNwlaO32b9zV9zrrBkrK3D/EGukv\n\tbFvA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1768073810; x=1768678610;\n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=KeWKC4Gdz8P/z2wnOMBzMSUHXDXKgy/9nYZB7pXAloE=;\n\tb=mKv0seUqgngSIioQo74vnMAPkL+6Dn5Oas/gdF7VjrrF4xyiPy3esjnREaHSy3kjFb\n\tl2syGOxLlmG+afYsmulXccpkhAUDsmNGeDzFebHgXhj9pPkp5BlUbB4UQmRy47oIh7Y5\n\tFKjO7jRvf5ebxmia614Ai+huKJTLw2nZRP90b+bzaqV1wH8Nng2AIcLihM4SLe85fhUp\n\tT8YQ53MpmTArLHqD+oUPuME794FVX5ywTRC7RowCYBkjOF4BBnl6YJ0jdavrh22QeGVW\n\ta/5JKbFBo7cyZkEv0HmM8q8hg0GbYPZ+ic4bEEyqxT0cQVr+LgBMJ/PuyhwhYrOvO/0t\n\tKM1Q==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVl1+w6Yh7Bcwz3P73TYBE18xpMCItKHg+0EFA1yskw1vPCl+BA1dwIYnP0h15gOvBFO9wW5emfSDVhRv5jlqI=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwJxblUYutMWNmCk34h1rmLN54nDmNN3zqYjyqGFFJL/X8w2JB2\n\tCmVL//+jymdq0ln4a8IuXY21TPtT8fWWJTXeCjoDE5mnT9XFmd6K0Wo9OdxyaFMdZS/oOU5frbv\n\tZSs0EmEkpjBJ8nX92/gDJ6f2mvWcoU7gv4vYd1UikQPh1gUaUvyugvkc+tTShv5bUzJFEuUZJEu\n\tHW","X-Gm-Gg":"AY/fxX7HgA/bc3IeshnQ14wS1qBLmjyiQvLpRGJWe9jYKpKj8CTRmyCanU8o8trMMha\n\t3ygspqAXpEjtgrH7NH87/j2PgFyiV0xrtgu84BTVw94c0P0E2QhSu7Wdyi6YpW3wy5AefJxkP+i\n\t/iX5VRcxBHFuZMrQ6P03b18Yay4purdCNx5FLwe45jXHsIiuyQG4f3i2l5fZKjr/BwT0un2Frk2\n\tz412INF/QS4oC55fLc6BQvyKbfzIItlgLEmV5dOrpU5SKiAN1gX2fBjOqOnd994EWPNr15kFLX3\n\tAgp8lxD4EinWUHkR66uEcvZhyrvFW30LbQ6URHKnX/O64RGbGr5qTGap54ON7g3kHz9nrq93xfG\n\tBgvJV6Ok44Pm9b92T6nZSK1e1Egei4HyP8zKPmfP4xNIAz9rQhlO7tF4GxIqE01p8G8YSo9c3Kx\n\tZfrW0e6imFt9IdTmAULMt52TPmLV2tCLTytEoG0/24gQHoS2l1pzDJLDyBn1wNMfLvLmocpKwgi\n\thpm","X-Received":["by 2002:a05:620a:298c:b0:878:16ad:3a5b with SMTP id\n\taf79cd13be357-8c38936c4b8mr2022673285a.14.1768073809932; \n\tSat, 10 Jan 2026 11:36:49 -0800 (PST)","by 2002:a05:620a:298c:b0:878:16ad:3a5b with SMTP id\n\taf79cd13be357-8c38936c4b8mr2022671885a.14.1768073809522; \n\tSat, 10 Jan 2026 11:36:49 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IGd6o7syFSszHFqab8tg5W9Pd01P+l3CKhcU9hpVM2LndoWDHoxoiCCJNBCyPg+gtregcWO5w==","Message-ID":"<f27bd0cc-e3e1-4d34-9a5f-2c7a7704ad55@oss.qualcomm.com>","Date":"Sat, 10 Jan 2026 20:36:48 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"johannes.goede@oss.qualcomm.com","Subject":"Re: [PATCH 3/4] egl: Remove duplicated logging of EGL version","To":"Robert Mader <robert.mader@collabora.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260110170927.79918-1-robert.mader@collabora.com>\n\t<20260110170927.79918-4-robert.mader@collabora.com>","Content-Language":"en-US, nl","In-Reply-To":"<20260110170927.79918-4-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMTEwMDE3MyBTYWx0ZWRfXzAaCQFzB3nDQ\n\t7P15EZwLxkm0ww5VJxtFMHVsxy6hGBWE4OL9QbfV7jhzArzoNdehUiWV+6iW/67T+zKkj4C78Gf\n\tyd/1h7XKhx6hlwwttcpEmgR9meUk1C+tpBL53rd/Vz1dtiRBQ4k07Enn04ES+ZRZYCvTdiDHpbE\n\t5yhU/sbonG9EkTPefgyzU/A/OW647YGN2s6dsEzAeyS37O1FBC23/ehW27bpgqPr9yEDbhhaF6b\n\tVR2XJEaH0EgeAkzP6SiOrkBA6VpwxxOuL9uQHophq/0MCwpl9yuxTqiSCyJkRenBgjFSgKz+TdY\n\t9IeepLQwuO6iWIAtQwZWYS2Ge1bcEBlziS00HsMa3lRPCMeOPXfYp2RABe6YldJF624i9R/ZYyW\n\txIBNMczX/zmQ3mGvb1d5CgmjuO3NG2DhSX4plzJtnXgXAp3kBSY47ieam42WVIYXQh7IuHugqoF\n\tQR6/0Ob6sQHkgaq5n9Q==","X-Authority-Analysis":"v=2.4 cv=R6AO2NRX c=1 sm=1 tr=0 ts=6962aa52 cx=c_pps\n\ta=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n\ta=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n\ta=QX4gbG5DAAAA:8 a=EUspDBNiAAAA:8 a=TYjHxKBhVybMGIGbsqcA:9\n\ta=QEXdDO2ut3YA:10\n\ta=bTQJ7kPSJx9SKPbeHEYW:22 a=AbAUZ8qAyYyZVLSsDulk:22","X-Proofpoint-ORIG-GUID":"ACn6z42qTM_iF8wVc8j3K1zHQv4K7cRE","X-Proofpoint-GUID":"ACn6z42qTM_iF8wVc8j3K1zHQv4K7cRE","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.9,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-01-10_06,2026-01-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tmalwarescore=0 bulkscore=0 spamscore=0 clxscore=1015\n\tpriorityscore=1501\n\tadultscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0\n\timpostorscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2512120000\n\tdefinitions=main-2601100173","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":37552,"web_url":"https://patchwork.libcamera.org/comment/37552/","msgid":"<472b37fc-03f7-4bfb-a263-7beb9070ee23@ideasonboard.com>","date":"2026-01-12T08:35:05","subject":"Re: [PATCH 3/4] egl: Remove duplicated logging of EGL version","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 10. 18:09 keltezéssel, Robert Mader írta:\n> The line above already prints it.\n> \n> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n> ---\n>   src/libcamera/egl.cpp | 1 -\n>   1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n> index fcaf7c58f..0bd9a83be 100644\n> --- a/src/libcamera/egl.cpp\n> +++ b/src/libcamera/egl.cpp\n> @@ -305,7 +305,6 @@ int eGL::initEGLContext(GBM *gbmContext)\n>   \t}\n> \n>   \tLOG(eGL, Info) << \"EGL: version \" << major << \".\" << minor;\n> -\tLOG(eGL, Info) << \"EGL: EGL_VERSION: \" << eglQueryString(display_, EGL_VERSION);\n\nIs it not possible that this string could contain more info\nthat the major + minor version numbers?\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\n\n>   \tLOG(eGL, Info) << \"EGL: EGL_VENDOR: \" << eglQueryString(display_, EGL_VENDOR);\n>   \tLOG(eGL, Info) << \"EGL: EGL_CLIENT_APIS: \" << eglQueryString(display_, EGL_CLIENT_APIS);\n>   \tLOG(eGL, Info) << \"EGL: EGL_EXTENSIONS: \" << eglQueryString(display_, EGL_EXTENSIONS);\n> --\n> 2.52.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FF3ABDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Jan 2026 08:35:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F257361FA0;\n\tMon, 12 Jan 2026 09:35:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFACD61F9F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Jan 2026 09:35:09 +0100 (CET)","from [192.168.33.29] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 945ED7E9;\n\tMon, 12 Jan 2026 09:34:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c9sjkZWL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768206884;\n\tbh=MqlLGjBW0IsYZCPymCJ+/eq8ycsPqQ+/JzJtOMtkQF4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=c9sjkZWLIXxGbYcgkRi+1Dodzn9kRG1YGLXwM3k3Te0MVQHzH/fXLUcoGBu1HsCgt\n\ttGp9yalCjhee7z3NMI9oq7j5kQwU8WhctKZUFqMfgZfgtY4/zJkU6KPG4bBoUhCBI9\n\tmacxBU3JJqv9cdWNnvJ2DGfe+MGdWDAQKBUUf1EA=","Message-ID":"<472b37fc-03f7-4bfb-a263-7beb9070ee23@ideasonboard.com>","Date":"Mon, 12 Jan 2026 09:35:05 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/4] egl: Remove duplicated logging of EGL version","To":"Robert Mader <robert.mader@collabora.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260110170927.79918-1-robert.mader@collabora.com>\n\t<yg7MJac-HmeFp81xFsVJkl1XF4EcvDj2_pUdMVx_MqSmbMCa7D6sxpl4ZrjyMGS4LN2bop59gmjLU2FJzU1CRg==@protonmail.internalid>\n\t<20260110170927.79918-4-robert.mader@collabora.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260110170927.79918-4-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":37558,"web_url":"https://patchwork.libcamera.org/comment/37558/","msgid":"<68e28843-5dbb-4c64-b054-c5a608e96f7d@collabora.com>","date":"2026-01-12T09:47:11","subject":"Re: [PATCH 3/4] egl: Remove duplicated logging of EGL version","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"Hi, thanks for the review.\n\nOn 12.01.26 09:35, Barnabás Pőcze wrote:\n> 2026. 01. 10. 18:09 keltezéssel, Robert Mader írta:\n>> The line above already prints it.\n>>\n>> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n>> ---\n>>   src/libcamera/egl.cpp | 1 -\n>>   1 file changed, 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\n>> index fcaf7c58f..0bd9a83be 100644\n>> --- a/src/libcamera/egl.cpp\n>> +++ b/src/libcamera/egl.cpp\n>> @@ -305,7 +305,6 @@ int eGL::initEGLContext(GBM *gbmContext)\n>>       }\n>>\n>>       LOG(eGL, Info) << \"EGL: version \" << major << \".\" << minor;\n>> -    LOG(eGL, Info) << \"EGL: EGL_VERSION: \" << \n>> eglQueryString(display_, EGL_VERSION);\n>\n> Is it not possible that this string could contain more info\n> that the major + minor version numbers?\n\nIt's possible in theory, but has not been the case on Mesa drivers so far.\n\nWhat we could do, however, is remove the line above instead (so we print \nEGL_VERSION instead of major.minor) - but I'd only do that if somebody \nhere shows a strong preference for that.\n\n> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n>\n>\n>>       LOG(eGL, Info) << \"EGL: EGL_VENDOR: \" << \n>> eglQueryString(display_, EGL_VENDOR);\n>>       LOG(eGL, Info) << \"EGL: EGL_CLIENT_APIS: \" << \n>> eglQueryString(display_, EGL_CLIENT_APIS);\n>>       LOG(eGL, Info) << \"EGL: EGL_EXTENSIONS: \" << \n>> eglQueryString(display_, EGL_EXTENSIONS);\n>> -- \n>> 2.52.0\n>>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FC89BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Jan 2026 09:47:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7B7661FBB;\n\tMon, 12 Jan 2026 10:47:19 +0100 (CET)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 912BC61F9F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Jan 2026 10:47:18 +0100 (CET)","by mx.zohomail.com with SMTPS id 1768211234762727.7055926259552;\n\tMon, 12 Jan 2026 01:47:14 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"E6oI2k2N\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1768211235; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=mjkVjcwqteTN79xZmG+dTQzhJ7BB7vxsUf3gFkYlgmhwCuMCy74tMlR77AMjLuB5mJUW8QHohXSELu0t/ExqvGtg36/CfpeAfLE9myP7AOl9lduVcVqWHwRh2mBG80nsC/7j5HRIr3DEgm8pMzcsx87HRYvljI4MZqDLgLdNHLc=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1768211235;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=BkKf83zO1/24CKhb4sxm5nqacq2ejzapqMsECsm0w3I=; \n\tb=hVgDPn/Av+l7HGRDfSgua18BgHoy/rp9X6aMzLxrHMPAfNV9LUrlGOXePgNrWsnMZCO5U8nOyestXrFm2sg/QNKgBtf6CVuKniGunfj4sRAnbRd5edujbVwtfgXLQl5++NIkgYEbM2wu6M5hjBH0mKrljfcDDP8jc6SV2q9JDHI=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass  header.i=collabora.com;\n\tspf=pass  smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768211235;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=BkKf83zO1/24CKhb4sxm5nqacq2ejzapqMsECsm0w3I=;\n\tb=E6oI2k2NGV3VNyVikEG8osvfRPNgnlf1zTk5OG46ZQL4rBAyN1crl8ZB1tsj0U2G\n\t9sEj7n0Mp2fH7MpQlJvqL9mXaxf/7XZ+DsvsIcBaB3/L3afNYKkw3qVn7xhpQRc/yMM\n\tk6oaxvxneg65sqwX1v9w59rS6aiy1cBRwVpUH2SA=","Message-ID":"<68e28843-5dbb-4c64-b054-c5a608e96f7d@collabora.com>","Date":"Mon, 12 Jan 2026 10:47:11 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/4] egl: Remove duplicated logging of EGL version","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260110170927.79918-1-robert.mader@collabora.com>\n\t<yg7MJac-HmeFp81xFsVJkl1XF4EcvDj2_pUdMVx_MqSmbMCa7D6sxpl4ZrjyMGS4LN2bop59gmjLU2FJzU1CRg==@protonmail.internalid>\n\t<20260110170927.79918-4-robert.mader@collabora.com>\n\t<472b37fc-03f7-4bfb-a263-7beb9070ee23@ideasonboard.com>","Content-Language":"en-US, de-DE","From":"Robert Mader <robert.mader@collabora.com>","In-Reply-To":"<472b37fc-03f7-4bfb-a263-7beb9070ee23@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]