[{"id":37548,"web_url":"https://patchwork.libcamera.org/comment/37548/","msgid":"<03df0c53-7929-4048-bd20-89d82c43b6e5@oss.qualcomm.com>","date":"2026-01-10T19:36:24","subject":"Re: [PATCH 2/4] egl: Remove bpp variable","submitter":{"id":242,"url":"https://patchwork.libcamera.org/api/people/242/","name":"Hans de Goede","email":"johannes.goede@oss.qualcomm.com"},"content":"Hi,\n\nOn 10-Jan-26 18:09, Robert Mader wrote:\n> It's unused and, in one case, was set wrongly.\n> \n> Signed-off-by: Robert Mader \n\nThanks, patch looks good to me:\n\nReviewed-by: Hans de Goede \n\nRegards,\n\nHans\n\n\n\n> ---\n> include/libcamera/internal/egl.h | 6 ++----\n> src/libcamera/software_isp/debayer_egl.cpp | 4 ++--\n> 2 files changed, 4 insertions(+), 6 deletions(-)\n> \n> diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\n> index 7b810773c..21e2aa9df 100644\n> --- a/include/libcamera/internal/egl.h\n> +++ b/include/libcamera/internal/egl.h\n> @@ -49,14 +49,13 @@ public:\n> \t * \\brief Construct an eGLImage with explicit stride\n> \t * \\param[in] width Image width in pixels\n> \t * \\param[in] height Image height in pixels\n> -\t * \\param[in] bpp Bytes per pixel\n> \t * \\param[in] stride Row stride in bytes\n> \t * \\param[in] texture_unit OpenGL texture unit\n> \t * \\param[in] texture_unit_uniform_id Shader uniform ID\n> \t */\n> -\teGLImage(uint32_t width, uint32_t height, uint32_t bpp, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n> +\teGLImage(uint32_t width, uint32_t height, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n> \t\t: width_(width), height_(height), stride_(stride),\n> -\t\t framesize_(stride * height), bpp_(bpp),\n> +\t\t framesize_(stride * height),\n> \t\t texture_unit_uniform_id_(texture_unit_uniform_id),\n> \t\t texture_unit_(texture_unit)\n> \t{\n> @@ -81,7 +80,6 @@ public:\n> \tuint32_t stride_; /**< Row stride in bytes */\n> \tuint32_t offset_; /**< Buffer offset (reserved for future use) */\n> \tuint32_t framesize_; /**< Total frame size in bytes (stride * height) */\n> -\tuint32_t bpp_; /**< Bytes per pixel */\n> \tuint32_t texture_unit_uniform_id_; /**< Shader uniform id for texture unit */\n> \tGLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n> \tGLuint texture_; /**< OpenGL texture object ID */\n> diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\n> index 1c13b72a5..9693d7252 100644\n> --- a/src/libcamera/software_isp/debayer_egl.cpp\n> +++ b/src/libcamera/software_isp/debayer_egl.cpp\n> @@ -597,10 +597,10 @@ int DebayerEGL::start()\n> \tLOG(Debayer, Debug) << \"Available fragment shader texture units \" << maxTextureImageUnits;\n> \n> \t/* Raw bayer input as texture */\n> -\teglImageBayerIn_ = std::make_unique(width_, height_, 32, inputConfig_.stride, GL_TEXTURE0, 0);\n> +\teglImageBayerIn_ = std::make_unique(width_, height_, inputConfig_.stride, GL_TEXTURE0, 0);\n> \n> \t/* Texture we will render to */\n> -\teglImageBayerOut_ = std::make_unique(outputSize_.width, outputSize_.height, 31, outputConfig_.stride, GL_TEXTURE1, 1);\n> +\teglImageBayerOut_ = std::make_unique(outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1);\n> \n> \tif (initBayerShaders(inputPixelFormat_, outputPixelFormat_))\n> \t\treturn -EINVAL;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27D6FBDCBF\n\tfor ;\n\tSat, 10 Jan 2026 19:36:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0FC861FBE;\n\tSat, 10 Jan 2026 20:36:28 +0100 (CET)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA2C661A35\n\tfor ;\n\tSat, 10 Jan 2026 20:36:27 +0100 (CET)","from pps.filterd (m0279870.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t60AFf5B2341692 for ;\n\tSat, 10 Jan 2026 19:36:26 GMT","from mail-qk1-f199.google.com (mail-qk1-f199.google.com\n\t[209.85.222.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bkeush6jg-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ;\n\tSat, 10 Jan 2026 19:36:26 +0000 (GMT)","by mail-qk1-f199.google.com with SMTP id\n\taf79cd13be357-8bb3388703dso2044226785a.1\n\tfor ;\n\tSat, 10 Jan 2026 11:36:26 -0800 (PST)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-6507be642f5sm13074081a12.20.2026.01.10.11.36.24\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tSat, 10 Jan 2026 11:36:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"XA/wfBck\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"gCAJHF6a\"; dkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcontent-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\t+eh44kMGedWL9pJL9/g9AeI+oYGhPxAq0FJg0NIE7s4=; b=XA/wfBck8K/cCTdt\n\tCOuAOD/3rnAhihxuSkvxVXVUL1bTuDMAY9CVqHlF9FNHD/bTgvEkrPZTvZOwId8c\n\t7x4osY9LeTjiM7mWSo99GcULd0dWODHcDZOXglm+DJnqqQk511M9PirwcTCG5Iki\n\tIejS6eSjkWmxAH5yr1SFn+akLGFstO7lEpaAaolsELF1FGQW7AqCi5memjkoSGWa\n\tfeHUVYNTSKKqAodmRVCLD6WO6i0UxmfH7kstHM6XUnHn07n5HlCeAOqUXfOS6RV2\n\tDfYuozaqVn7Y9cmQUjhqKhh8dlFvBLBYOs4pU+feHqiolOKaO7re6YbZLCwmvkgz\n\tMFgsZA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1768073786; x=1768678586;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:to:subject:from:user-agent:mime-version:date:message-id:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=+eh44kMGedWL9pJL9/g9AeI+oYGhPxAq0FJg0NIE7s4=;\n\tb=gCAJHF6aWqZ8e51tTGkuIcCIoVOEEi9RGWLzZULFfCS1EqQYIDkVAkBw9Q4dw2mDow\n\ttKW+oUVtxF0GkDAhDhIZCui0oYtEPctOdMsXITUSJkFN9FDC6dMHRc5gtyFcpZPZfhPy\n\tUiDL7gabMq7MD1lS8QtvkqHZIeluFXJTLd0ZpKsMxC3OqHDVs+yVt96FGkMSiz2pmgBQ\n\tqmFfCwpghtGn4TYq8fTvyUGxleKW3ayS5Ecg2uFix/7OS0blGm94Ko8nh8Ktb/BeZHmr\n\tCYIQUZiyTpCjaViOBRBp4jFhZVe0YPmkDkJl7sAV4nnnVcWfJfNfAw62Siwkt0m08k/7\n\tSg8g=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1768073786; x=1768678586;\n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=+eh44kMGedWL9pJL9/g9AeI+oYGhPxAq0FJg0NIE7s4=;\n\tb=iwsSq2BwcK/QkrgQ7+3XX36S4OjzAek4JGXnoNxhaF8kuj7/Ot0/U5EtoEisFqsGUd\n\tOWmCL0oeIidDqU6ZpKRXu7KEGV9p+6Y5rOaBEOG11LUIZ4uuZhxuyDYqR84gXJGwJiAj\n\tSQ+fsvgp0oJ+f5YAO+N2HGwyK7TLzhEhhGeONDcJfSNob+tO/QgfBoJKqSNEajG0hZLf\n\tYNHGKqWyOJTT33YJQTi4SyfP5Qw2eXAJlJNvkiRWSeCHrywEVdSljSra5sC9WOTfvoqz\n\t3M661QAO86m7jETXk9ioXUyIKNMHuZ9Zjvcbf2xk8YSTP+eg2ZVhmfuEjFj8Jw0DOHqw\n\tq1Rw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVRHDnq61MkOze3BXIgj2EOrkxyleMaXjm/px6X98ieQC0dIM2dzoeTUj52LXWwgdtnibzJxgZfwpoECRiPY+M=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YznyI565sAaA73sEnaiGXZDZ4fa2zSLqS8EZHWCoHe5N/1MX5iT\n\tk6XseNanp+J6iHovYDo2DjcqqcoWnNQ6WgtmxzhMITlwls0w+/GAvHFmCvbGEZ6/75glmh9Qwef\n\tB7lbo4URRN2ZcbKlp9rpFXdAqNLP4LU0F3LI77UB8YAykpGABC6+4lYY2BN+txXm51+x7dAsLDg\n\tlWgoiXWBQs","X-Gm-Gg":"AY/fxX7J0jgV1kFltdQq3fWBYyRCayBsmmQfV/b14ranId2epoNVhGPikyWRDEAxLV6\n\t+ifc+dLL+cIVr/6X0dwbuR8I1Dvke8kGwM9vk8gNbzy0SGihzX3NmBzZv29LQ8ml04gB0Fy6y4m\n\tymGU2H7Ydlt3yI3mERnZLhddo8qPhs5Mdh0La+OMRga/5KDCpfB0kb2LFLTQPURGe0qHEeGdQxs\n\tCvmdVOPOOeFTKV9a7HHF4hT3pnY+4LVlaP9DFakkX6mnjtUNRS4z6OUxr1cHwP7Cc60+adDpUs6\n\tIxBdCNtsFmqzMrmdphuwWcCg1OQZPuJh2ZBBlX1NTXq1UieynjThN6tdgfi8GzOJXx2zB//u0y2\n\tMynOBASjjRIPWSt3Jy/4T1XCWE7MbzRN6zo7mNMpjCwDshvxJro7DWHXvyTgfPSkWtKmAtnY6De\n\tU2iafCPkuT/5BA6ZM1PI5X7z89yfx6lhGwJy2n6Nkv+2rmOFlyRxNqqEmDwz+ihHrVe7TQ5D5un\n\teGI","X-Received":["by 2002:a05:620a:298c:b0:8b2:eb79:d37c with SMTP id\n\taf79cd13be357-8c389379d9emr2058956485a.14.1768073785691; \n\tSat, 10 Jan 2026 11:36:25 -0800 (PST)","by 2002:a05:620a:298c:b0:8b2:eb79:d37c with SMTP id\n\taf79cd13be357-8c389379d9emr2058954585a.14.1768073785315; \n\tSat, 10 Jan 2026 11:36:25 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IFSu+iqWRMQFuIUF3sqf/927jQWzycHUawdhgqS5+9ZOM/FMkACTNA/STcGHl02BJLuxKD3GA==","Message-ID":"<03df0c53-7929-4048-bd20-89d82c43b6e5@oss.qualcomm.com>","Date":"Sat, 10 Jan 2026 20:36:24 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","From":"johannes.goede@oss.qualcomm.com","Subject":"Re: [PATCH 2/4] egl: Remove bpp variable","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260110170927.79918-1-robert.mader@collabora.com>\n\t<20260110170927.79918-3-robert.mader@collabora.com>","Content-Language":"en-US, nl","In-Reply-To":"<20260110170927.79918-3-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-ORIG-GUID":"65mydbju0DKBjQOoXhgbSgvkwCIfTBmt","X-Authority-Analysis":"v=2.4 cv=GNMF0+NK c=1 sm=1 tr=0 ts=6962aa3a cx=c_pps\n\ta=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n\ta=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n\ta=QX4gbG5DAAAA:8 a=EUspDBNiAAAA:8 a=x6ac_1GcjAQ1I-mbdjgA:9\n\ta=QEXdDO2ut3YA:10\n\ta=bTQJ7kPSJx9SKPbeHEYW:22 a=AbAUZ8qAyYyZVLSsDulk:22","X-Proofpoint-GUID":"65mydbju0DKBjQOoXhgbSgvkwCIfTBmt","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMTEwMDE3MyBTYWx0ZWRfX7vKrZ1oj+qRE\n\t2JSnpMx/SyeBnWDIBaIbzNoAbbWgEalvmyqbb6cjnlAtcWnKnnCzmBZ6hB9NawzuvmJAnWpOqGp\n\tfZ7Zm8DgR/KU1pwGaIO4+6qcQjMVa31GShWSL6pV97AwwOaakdIkUfJoFIq1lEMGcx7s77GsS4Q\n\tcKCFaznDhUFXPH7Pdc1LXvJQbfU7mTEi2pM4n+TjbH0ppvCOZ28/VMrKplAbpCrblxbN19SXkWp\n\t1rA/r1R8u1i1CAS/X/b0k2R/6BGCkOCLPDnEsfr14czSPrchSafpzkI+GpQM6ZNcFd0mYhteMTH\n\tOVXZHiHNSD34h1r92OQFnUGDMzB4iA/n3zKt8XWU5jp87x85vL6cam/qMainOXTCwpG+CLlHAQh\n\tumLPFiABoy0ResmhFOwdgwz3gCpvlfGpDA+OzeGGdPiRyKqU07beSDN/8oL+1ZHPvPgf06twJhw\n\tSOJHLZvmL92ZiTM7enw==","X-Proofpoint-Virus-Version":"vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.9,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-01-10_06,2026-01-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tclxscore=1015 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0\n\tlowpriorityscore=0 suspectscore=0 spamscore=0 priorityscore=1501\n\timpostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n\troute=outbound adjust=0 reason=mlx scancount=1\n\tengine=8.22.0-2512120000\n\tdefinitions=main-2601100173","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]