{"id":25708,"url":"https://patchwork.libcamera.org/api/patches/25708/?format=json","web_url":"https://patchwork.libcamera.org/patch/25708/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260110170927.79918-3-robert.mader@collabora.com>","date":"2026-01-10T17:09:25","name":"[2/4] egl: Remove bpp variable","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6921b75202d415f092887f300eadbc162894d1d3","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/?format=json","name":"Robert Mader","email":"robert.mader@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25708/mbox/","series":[{"id":5698,"url":"https://patchwork.libcamera.org/api/series/5698/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5698","date":"2026-01-10T17:09:23","name":"GPUISP cleanups","version":1,"mbox":"https://patchwork.libcamera.org/series/5698/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25708/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25708/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30887BE08B\n\tfor ;\n\tSat, 10 Jan 2026 17:10:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE07561FC1;\n\tSat, 10 Jan 2026 18:10:22 +0100 (CET)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5F6B61A35\n\tfor ;\n\tSat, 10 Jan 2026 18:10:21 +0100 (CET)","by mx.zohomail.com with SMTPS id 1768065016734439.5995581327402;\n\tSat, 10 Jan 2026 09:10:16 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"hZkPXXV9\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1768065017; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=FaSdbPSCtYbRpHy8RgTuSqG8SyXThYRiesPCJX/FScHxqPK+pPASJ17XDBp4iJd0d+m/2kmoYacapLZhfned18lmcgHJNPO4TkBRrLFrcxOEyJJa1s0QlVouD/l3G3XUZDtruU2OGYXklSMs+xQK7Ewj32qNgmH2qGHp9uh/AhA=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1768065017;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=6WGzZY50jt8+gkUXB/PX2OWCswi+UuC6PACD/tR+DIg=; \n\tb=Ug/L5D+LInsraVcLEKsrZnxCm2+lATo0PqCRWeiVv04mhw82OLx/4+gQWgfNX3Z1qH61Z3AXC1cfWcp+D2a4CZjbTYctNt6U5DuLflOAP+8GrFtG/DQ7nquxDeZZKtCfCcXescta6Ukn+fvsDMAWcq+uUYg12SZzCkgcJOwoZWE=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768065017;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=6WGzZY50jt8+gkUXB/PX2OWCswi+UuC6PACD/tR+DIg=;\n\tb=hZkPXXV9qOBXG54B2NB3yT5IOY5m3beWimF1mfxJBxxgEUJLPh8IleXD29B7L6v6\n\tF63akY9jVpWoHY8pF+85guMj+spdWjqNP6L/p4xtynh/Jah3R33biRgEg8GDgjyu7EV\n\tX4IVNg5f+SjwaB5E5Lbmf6qfyY6E8CV7UimOztVE=","From":"Robert Mader ","To":"libcamera-devel@lists.libcamera.org","Cc":"Robert Mader ","Subject":"[PATCH 2/4] egl: Remove bpp variable","Date":"Sat, 10 Jan 2026 18:09:25 +0100","Message-ID":"<20260110170927.79918-3-robert.mader@collabora.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260110170927.79918-1-robert.mader@collabora.com>","References":"<20260110170927.79918-1-robert.mader@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It's unused and, in one case, was set wrongly.\n\nSigned-off-by: Robert Mader \n---\n include/libcamera/internal/egl.h | 6 ++----\n src/libcamera/software_isp/debayer_egl.cpp | 4 ++--\n 2 files changed, 4 insertions(+), 6 deletions(-)","diff":"diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 7b810773c..21e2aa9df 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -49,14 +49,13 @@ public:\n \t * \\brief Construct an eGLImage with explicit stride\n \t * \\param[in] width Image width in pixels\n \t * \\param[in] height Image height in pixels\n-\t * \\param[in] bpp Bytes per pixel\n \t * \\param[in] stride Row stride in bytes\n \t * \\param[in] texture_unit OpenGL texture unit\n \t * \\param[in] texture_unit_uniform_id Shader uniform ID\n \t */\n-\teGLImage(uint32_t width, uint32_t height, uint32_t bpp, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n+\teGLImage(uint32_t width, uint32_t height, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n \t\t: width_(width), height_(height), stride_(stride),\n-\t\t framesize_(stride * height), bpp_(bpp),\n+\t\t framesize_(stride * height),\n \t\t texture_unit_uniform_id_(texture_unit_uniform_id),\n \t\t texture_unit_(texture_unit)\n \t{\n@@ -81,7 +80,6 @@ public:\n \tuint32_t stride_; /**< Row stride in bytes */\n \tuint32_t offset_; /**< Buffer offset (reserved for future use) */\n \tuint32_t framesize_; /**< Total frame size in bytes (stride * height) */\n-\tuint32_t bpp_; /**< Bytes per pixel */\n \tuint32_t texture_unit_uniform_id_; /**< Shader uniform id for texture unit */\n \tGLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n \tGLuint texture_; /**< OpenGL texture object ID */\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 1c13b72a5..9693d7252 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -597,10 +597,10 @@ int DebayerEGL::start()\n \tLOG(Debayer, Debug) << \"Available fragment shader texture units \" << maxTextureImageUnits;\n \n \t/* Raw bayer input as texture */\n-\teglImageBayerIn_ = std::make_unique(width_, height_, 32, inputConfig_.stride, GL_TEXTURE0, 0);\n+\teglImageBayerIn_ = std::make_unique(width_, height_, inputConfig_.stride, GL_TEXTURE0, 0);\n \n \t/* Texture we will render to */\n-\teglImageBayerOut_ = std::make_unique(outputSize_.width, outputSize_.height, 31, outputConfig_.stride, GL_TEXTURE1, 1);\n+\teglImageBayerOut_ = std::make_unique(outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1);\n \n \tif (initBayerShaders(inputPixelFormat_, outputPixelFormat_))\n \t\treturn -EINVAL;\n","prefixes":["2/4"]}