[{"id":37542,"web_url":"https://patchwork.libcamera.org/comment/37542/","msgid":"<61261fae-c316-409a-b2a6-14cea1e9454d@ideasonboard.com>","date":"2026-01-09T12:30:57","subject":"Re: [PATCH v2 15/15] ipa: rkisp1: Implement\n\tLensShadingCorrectionEnable control","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 08. 17:05 keltezéssel, Stefan Klug írta:\n> Implement the LensShadingCorrectionEnable control for rkisp1.\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n\nA cursory test with camshark works ok (no dpf).\n\nTested-by: Barnabás Pőcze \n\n\n> \n> Changes in v2:\n> - Add the control only if LSC is properly configured in the tuning file\n> - Introduce enable flag in frame context for per frame control\n> ---\n> src/ipa/rkisp1/algorithms/dpf.cpp | 2 +-\n> src/ipa/rkisp1/algorithms/lsc.cpp | 48 ++++++++++++++++++++++++++++++++++-----\n> src/ipa/rkisp1/algorithms/lsc.h | 3 +++\n> src/ipa/rkisp1/ipa_context.h | 13 +++++++----\n> 4 files changed, 55 insertions(+), 11 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n> index 39f3e461f313dfbf35cb5d6a0daca0540bdf7b6b..83c1e4b7b355041295cbe0498a8dd70877ea6636 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n> @@ -233,7 +233,7 @@ void Dpf::prepare(IPAContext &context, const uint32_t frame,\n> \t\t*strengthConfig = strengthConfig_;\n> \n> \t\tconst auto &awb = context.configuration.awb;\n> -\t\tconst auto &lsc = context.configuration.lsc;\n> +\t\tconst auto &lsc = context.activeState.lsc;\n> \n> \t\tauto &mode = config->gain.mode;\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index 698f07b85bfa5d3de0c454087bf8e0874d85add7..cb3f8550457eb2e67959ce034d037ac60328d267 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -416,6 +416,8 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> \tif (ret)\n> \t\treturn ret;\n> \n> +\tcontext.ctrlMap[&controls::LensShadingCorrectionEnable] = ControlInfo(false, true, true);\n> +\n> \tshadingDescriptors_ = std::move(lscData);\n> \n> \treturn 0;\n> @@ -460,7 +462,7 @@ int LensShadingCorrection::configure(IPAContext &context,\n> \n> \tsets_.setData(std::move(shadingData));\n> \n> -\tcontext.configuration.lsc.enabled = true;\n> +\tcontext.activeState.lsc.enabled = true;\n> \treturn 0;\n> }\n> \n> @@ -481,6 +483,29 @@ void LensShadingCorrection::copyTable(rkisp1_cif_isp_lsc_config &config,\n> \tstd::copy(set.b.begin(), set.b.end(), &config.b_data_tbl[0][0]);\n> }\n> \n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::queueRequest\n> + */\n> +void LensShadingCorrection::queueRequest(IPAContext &context,\n> +\t\t\t\t\t [[maybe_unused]] const uint32_t frame,\n> +\t\t\t\t\t IPAFrameContext &frameContext,\n> +\t\t\t\t\t const ControlList &controls)\n> +{\n> +\tauto &lsc = context.activeState.lsc;\n> +\n> +\tconst auto &lscEnable = controls.get(controls::LensShadingCorrectionEnable);\n> +\tif (lscEnable && *lscEnable != lsc.enabled) {\n> +\t\tlsc.enabled = *lscEnable;\n> +\n> +\t\tLOG(RkISP1Lsc, Debug)\n> +\t\t\t<< (*lscEnable ? \"Enabling\" : \"Disabling\") << \" Lsc\";\n> +\n> +\t\tframeContext.lsc.update = true;\n> +\t}\n> +\n> +\tframeContext.lsc.enabled = lsc.enabled;\n> +}\n> +\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::prepare\n> */\n> @@ -493,14 +518,25 @@ void LensShadingCorrection::prepare([[maybe_unused]] IPAContext &context,\n> \tunsigned int quantizedCt = quantize(ct, kColourTemperatureChangeThreshhold);\n> \tint ctDiff = static_cast(ct) - static_cast(lastAppliedCt_);\n> \n> -\tif (quantizedCt == lastAppliedQuantizedCt_)\n> -\t\treturn;\n> \n> -\tif (std::abs(ctDiff) < kColourTemperatureChangeThreshhold)\n> -\t\treturn;\n> +\t/* Check if we can skip the update. */\n> +\tif (!frameContext.lsc.update) {\n> +\t\tif (!frameContext.lsc.enabled)\n> +\t\t\treturn;\n> +\n> +\t\tif (quantizedCt == lastAppliedQuantizedCt_)\n> +\t\t\treturn;\n> +\n> +\t\tif (std::abs(ctDiff) < kColourTemperatureChangeThreshhold)\n> +\t\t\treturn;\n> +\t}\n> \n> \tauto config = params->block();\n> -\tconfig.setEnabled(true);\n> +\tconfig.setEnabled(frameContext.lsc.enabled);\n> +\n> +\tif (!frameContext.lsc.enabled)\n> +\t\treturn;\n> +\n> \tsetParameters(*config);\n> \n> \tconst Components &set = sets_.getInterpolated(quantizedCt);\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> index 3097740a6cb2ce9063a4ba087856987a489b0ab6..ff4e8d91fe87d99b6dae8d611afc23846081bcd5 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.h\n> +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> @@ -29,6 +29,9 @@ public:\n> \tvoid prepare(IPAContext &context, const uint32_t frame,\n> \t\t IPAFrameContext &frameContext,\n> \t\t RkISP1Params *params) override;\n> +\tvoid queueRequest(IPAContext &context, const uint32_t frame,\n> +\t\t\t IPAFrameContext &frameContext,\n> +\t\t\t const ControlList &controls) override;\n> \n> \tstruct Components {\n> \t\tstd::vector r;\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index b257cee55379ad932b42e613f94eccbe69a939e3..fa748811be743b43ce6ee289408c054c6f9a7046 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -55,10 +55,6 @@ struct IPASessionConfiguration {\n> \t\tbool supported;\n> \t} compress;\n> \n> -\tstruct {\n> -\t\tbool enabled;\n> -\t} lsc;\n> -\n> \tstruct {\n> \t\tutils::Duration minExposureTime;\n> \t\tutils::Duration maxExposureTime;\n> @@ -143,6 +139,10 @@ struct IPAActiveState {\n> \t\tdouble gain;\n> \t\tdouble strength;\n> \t} wdr;\n> +\n> +\tstruct {\n> +\t\tbool enabled;\n> +\t} lsc;\n> };\n> \n> struct IPAFrameContext : public FrameContext {\n> @@ -218,6 +218,11 @@ struct IPAFrameContext : public FrameContext {\n> \t\tdouble strength;\n> \t\tdouble gain;\n> \t} wdr;\n> +\n> +\tstruct {\n> +\t\tbool enabled;\n> +\t\tbool update;\n> +\t} lsc;\n> };\n> \n> struct IPAContext {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48A1FBE08B\n\tfor ;\n\tFri, 9 Jan 2026 12:31:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A15961FA0;\n\tFri, 9 Jan 2026 13:31:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1E8861F61\n\tfor ;\n\tFri, 9 Jan 2026 13:31:00 +0100 (CET)","from [192.168.33.17] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22A7D63B;\n\tFri, 9 Jan 2026 13:30:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wfMu3+84\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767961837;\n\tbh=3gTFb5KYqPfCECLfi4QdkMPfNxGxFNX1wDi6ynXxq8s=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=wfMu3+844PRggcn6te252R6mG1tPh/Z0DfrMHa9um3QHe+KsDAi0k6oHc5w5iWIB/\n\tygCZ4sypk3VVqeTKS9fSDSQZHAa+xHXPjgV627wTO2nkALFPXj0Yo/XT3LQAqEO2wm\n\twly0KOKz4jnOtYggAc9MPUXHx1fOwe/Uqmt3DmhI=","Message-ID":"<61261fae-c316-409a-b2a6-14cea1e9454d@ideasonboard.com>","Date":"Fri, 9 Jan 2026 13:30:57 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 15/15] ipa: rkisp1: Implement\n\tLensShadingCorrectionEnable control","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>\n\t<20260108-sklug-lsc-resampling-v2-dev-v2-15-e682ec4b9893@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260108-sklug-lsc-resampling-v2-dev-v2-15-e682ec4b9893@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37543,"web_url":"https://patchwork.libcamera.org/comment/37543/","msgid":"","date":"2026-01-09T12:32:55","subject":"Re: [PATCH v2 15/15] ipa: rkisp1: Implement\n\tLensShadingCorrectionEnable control","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 08. 17:05 keltezéssel, Stefan Klug írta:\n> Implement the LensShadingCorrectionEnable control for rkisp1.\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n\nI see that `LensShadingCorrectionEnable` is an inout control.\nIs the addition to metadata intentionally omitted here?\n\n\n> \n> Changes in v2:\n> - Add the control only if LSC is properly configured in the tuning file\n> - Introduce enable flag in frame context for per frame control\n> ---\n> src/ipa/rkisp1/algorithms/dpf.cpp | 2 +-\n> src/ipa/rkisp1/algorithms/lsc.cpp | 48 ++++++++++++++++++++++++++++++++++-----\n> src/ipa/rkisp1/algorithms/lsc.h | 3 +++\n> src/ipa/rkisp1/ipa_context.h | 13 +++++++----\n> 4 files changed, 55 insertions(+), 11 deletions(-)\n> \n> [...]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E865BBE08B\n\tfor ;\n\tFri, 9 Jan 2026 12:33:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2029761FBE;\n\tFri, 9 Jan 2026 13:33:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3859061FA0\n\tfor ;\n\tFri, 9 Jan 2026 13:32:59 +0100 (CET)","from [192.168.33.17] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E88CC63B;\n\tFri, 9 Jan 2026 13:32:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eKMmQbnR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767961956;\n\tbh=t6BdtScN0cE/Y3wIead4jVuXCFlHZnh78IX5QrcxEMc=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=eKMmQbnRm9HV5YavwiQKwJiAXZZznzHSoBsa6HCkDtVWV/QAUu1wAL+9EZ2ieeqEx\n\tokMXk7F61Kcchkfi6eoX061NTfvAaCDaQJjl2thx/Eqxj7Jz77pusozRNupAUV9SNr\n\t5Uls7Ulc/XzU2Ox25fqjfqma6l55poqE9ZKfymfc=","Message-ID":"","Date":"Fri, 9 Jan 2026 13:32:55 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 15/15] ipa: rkisp1: Implement\n\tLensShadingCorrectionEnable control","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>\n\t<20260108-sklug-lsc-resampling-v2-dev-v2-15-e682ec4b9893@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260108-sklug-lsc-resampling-v2-dev-v2-15-e682ec4b9893@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37551,"web_url":"https://patchwork.libcamera.org/comment/37551/","msgid":"<176820684798.21455.6642933753169687903@localhost>","date":"2026-01-12T08:34:07","subject":"Re: [PATCH v2 15/15] ipa: rkisp1: Implement\n\tLensShadingCorrectionEnable control","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2026-01-09 13:32:55)\n> 2026. 01. 08. 17:05 keltezéssel, Stefan Klug írta:\n> > Implement the LensShadingCorrectionEnable control for rkisp1.\n> > \n> > Signed-off-by: Stefan Klug \n> > \n> > ---\n> \n> I see that `LensShadingCorrectionEnable` is an inout control.\n> Is the addition to metadata intentionally omitted here?\n\nGood point. THat should be added. I'll add that for v3.\n\nThanks,\nStefan\n\n> \n> \n> > \n> > Changes in v2:\n> > - Add the control only if LSC is properly configured in the tuning file\n> > - Introduce enable flag in frame context for per frame control\n> > ---\n> > src/ipa/rkisp1/algorithms/dpf.cpp | 2 +-\n> > src/ipa/rkisp1/algorithms/lsc.cpp | 48 ++++++++++++++++++++++++++++++++++-----\n> > src/ipa/rkisp1/algorithms/lsc.h | 3 +++\n> > src/ipa/rkisp1/ipa_context.h | 13 +++++++----\n> > 4 files changed, 55 insertions(+), 11 deletions(-)\n> > \n> > [...]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DB0BBDCBF\n\tfor ;\n\tMon, 12 Jan 2026 08:34:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3721061FC1;\n\tMon, 12 Jan 2026 09:34:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7CD7A61F9F\n\tfor ;\n\tMon, 12 Jan 2026 09:34:11 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:67bf:b901:c41c:c9f])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0797D7E9;\n\tMon, 12 Jan 2026 09:33:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"khli6UXP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768206826;\n\tbh=2HEowSgijh40ZIIXN/2B4UlDQtsWf7go/dbP8B20fwQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=khli6UXPZEYscfvJQt7XzKag0IIOQSX/nrdGQ3WwmPR96YCm0MRIi2EwIWqIof4rN\n\thOHMiYVyVpPLIJ3/zoNQ9eSS12NswlM+IMU4DuQnDv7FVaaVkH2+K5vIQTd3exEDFD\n\tIxu8af0cBYIwgsjvMKURrE18pxvnudX7iAk9CwPs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>\n\t<20260108-sklug-lsc-resampling-v2-dev-v2-15-e682ec4b9893@ideasonboard.com>\n\t","Subject":"Re: [PATCH v2 15/15] ipa: rkisp1: Implement\n\tLensShadingCorrectionEnable control","From":"Stefan Klug ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 12 Jan 2026 09:34:07 +0100","Message-ID":"<176820684798.21455.6642933753169687903@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]