[{"id":382,"web_url":"https://patchwork.libcamera.org/comment/382/","msgid":"<20190117203008.GA23244@pendragon.ideasonboard.com>","date":"2019-01-17T20:30:08","subject":"Re: [libcamera-devel] [PATCH 1/5] test: timer: Initialise all\n\tvariables","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Jan 17, 2019 at 08:20:39PM +0000, Kieran Bingham wrote:\n> The ManagedTimer does not initialise the integer 'interval_' variable.\n> \n> This is set before used, and should not break - but for completeness\n> (and to cover static analysers) initialise the variable in the\n> initialiser list.\n> \n> Fixes: 034ea868027d (\"test: Add timer test\")\n> Signed-off-by: Kieran Bingham \n> ---\n> test/timer.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/timer.cpp b/test/timer.cpp\n> index 6a3cda70bef4..3d1a78ac2768 100644\n> --- a/test/timer.cpp\n> +++ b/test/timer.cpp\n> @@ -19,7 +19,8 @@ using namespace libcamera;\n> class ManagedTimer : public Timer\n> {\n> public:\n> -\tManagedTimer() : Timer()\n> +\tManagedTimer() :\n> +\t\tTimer(), interval_(0)\n\nNitpicking, this should read\n\n\tManagedTimer()\n\t\t: Timer(), interval_(0)\n\nApart from that,\n\nReviewed-by: Laurent Pinchart \n\n> \t{\n> \t\ttimeout.connect(this, &ManagedTimer::timeoutHandler);\n> \t}","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 515DB60B2D\n\tfor ;\n\tThu, 17 Jan 2019 21:30:09 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B84FC53E;\n\tThu, 17 Jan 2019 21:30:08 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547757008;\n\tbh=nsww5knmQjXfp58/2H+7xMmPV3xVOzPH+U4cTljZMfo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OBpYiuUHGiDmprUce29+1ek/eGxcHXB5vf/yYnN1v0a2FJjc8hUgK+OEbwlHWohXl\n\t6J5w3RApqLrM7nD/+nXajzhXqVRw61eUWsQ4e9z91Q5oocK7JC5Rt2UuHgQuDmRY66\n\tCX+l+P3+AhqxMfAV/I7camOH1fAXyr9ObYqlLieY=","Date":"Thu, 17 Jan 2019 22:30:08 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190117203008.GA23244@pendragon.ideasonboard.com>","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>\n\t<20190117202043.21420-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190117202043.21420-2-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/5] test: timer: Initialise all\n\tvariables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 20:30:09 -0000"}},{"id":383,"web_url":"https://patchwork.libcamera.org/comment/383/","msgid":"","date":"2019-01-17T20:31:11","subject":"Re: [libcamera-devel] [PATCH 1/5] test: timer: Initialise all\n\tvariables","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 17/01/2019 20:30, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Jan 17, 2019 at 08:20:39PM +0000, Kieran Bingham wrote:\n>> The ManagedTimer does not initialise the integer 'interval_' variable.\n>>\n>> This is set before used, and should not break - but for completeness\n>> (and to cover static analysers) initialise the variable in the\n>> initialiser list.\n>>\n>> Fixes: 034ea868027d (\"test: Add timer test\")\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> test/timer.cpp | 3 ++-\n>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/test/timer.cpp b/test/timer.cpp\n>> index 6a3cda70bef4..3d1a78ac2768 100644\n>> --- a/test/timer.cpp\n>> +++ b/test/timer.cpp\n>> @@ -19,7 +19,8 @@ using namespace libcamera;\n>> class ManagedTimer : public Timer\n>> {\n>> public:\n>> -\tManagedTimer() : Timer()\n>> +\tManagedTimer() :\n>> +\t\tTimer(), interval_(0)\n> \n> Nitpicking, this should read\n> \n> \tManagedTimer()\n> \t\t: Timer(), interval_(0)\n\nAha, I can fix this before pushing.\n\n\n> \n> Apart from that,\n> \n> Reviewed-by: Laurent Pinchart \n\nThanks.\n\n\n> \n>> \t{\n>> \t\ttimeout.connect(this, &ManagedTimer::timeoutHandler);\n>> \t}\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69DEA60B2D\n\tfor ;\n\tThu, 17 Jan 2019 21:31:15 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5CFE41;\n\tThu, 17 Jan 2019 21:31:14 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547757075;\n\tbh=sdUwkVw7UNJnQ1erwbyrAaPkRasSFGYd6S/T+jhj8ZA=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=JdFAV/nY3jLHEvs+Him3vV24nFSfO4EHdzVGXdc/tuRsIDWkG1Bj3N+VYX5AwPjuH\n\thVQz6IkHNv9T8Hhn/Ipfi1PtOMdRENRpMGbQHCbaYMtmY2S8IGKHkFge/GPAPaSieA\n\tFnrnJLhDYW135cazJdGSLO89TxjGG6OVI2wHK59E=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>\n\t<20190117202043.21420-2-kieran.bingham@ideasonboard.com>\n\t<20190117203008.GA23244@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 17 Jan 2019 20:31:11 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190117203008.GA23244@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/5] test: timer: Initialise all\n\tvariables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 20:31:15 -0000"}},{"id":392,"web_url":"https://patchwork.libcamera.org/comment/392/","msgid":"<20190117215754.GL6484@bigcity.dyn.berto.se>","date":"2019-01-17T21:57:54","subject":"Re: [libcamera-devel] [PATCH 1/5] test: timer: Initialise all\n\tvariables","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2019-01-17 20:20:39 +0000, Kieran Bingham wrote:\n> The ManagedTimer does not initialise the integer 'interval_' variable.\n> \n> This is set before used, and should not break - but for completeness\n> (and to cover static analysers) initialise the variable in the\n> initialiser list.\n> \n> Fixes: 034ea868027d (\"test: Add timer test\")\n> Signed-off-by: Kieran Bingham \n\nWith the comment Laurent points out fixed,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/timer.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/timer.cpp b/test/timer.cpp\n> index 6a3cda70bef4..3d1a78ac2768 100644\n> --- a/test/timer.cpp\n> +++ b/test/timer.cpp\n> @@ -19,7 +19,8 @@ using namespace libcamera;\n> class ManagedTimer : public Timer\n> {\n> public:\n> -\tManagedTimer() : Timer()\n> +\tManagedTimer() :\n> +\t\tTimer(), interval_(0)\n> \t{\n> \t\ttimeout.connect(this, &ManagedTimer::timeoutHandler);\n> \t}\n> -- \n> 2.17.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8182560B2D\n\tfor ;\n\tThu, 17 Jan 2019 22:57:56 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id b20so8967070lfa.12\n\tfor ;\n\tThu, 17 Jan 2019 13:57:56 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tm21sm491589lfl.97.2019.01.17.13.57.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 17 Jan 2019 13:57:55 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=jpcYAY6gUu1CBdBWBp2Bn+HmBu9J4jCYP0z0y55RWZA=;\n\tb=VIMbRTyYYiQFZWszhY4/4pECA6fUhx22XzPbDbAV2fX1ccNvL/qBT4kPIcj/0pxgB7\n\tVq15zWJ+DoRpcZXmqRfPUFwBwFkrUsR/dzxotQfjQZuyz7DdDy/U58/n2MpLGHAuT2lc\n\t8U2ACC0Utk6kYcwADc6l7U1ntXAc8PpmIpbZ6r1P4ebYVZj56lWRCYQeQQlgp6kk1MkE\n\tqje5VOUx/V6HoecsSDuF5kQxtWWZYBmbXCS4PHGUwUBCPqcUJtuBsqVsoY0Sz3JZ6X29\n\tEw3DeeWyLlJrbzhzFcj2aw+sKV/GpuEMoGspDXRgU/k5CxrzcmNyO753AekGDNJ0waU/\n\tQHfw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=jpcYAY6gUu1CBdBWBp2Bn+HmBu9J4jCYP0z0y55RWZA=;\n\tb=ThsxAtBeWjbNmNli+bEgFmjsBpVszsyHkfdE18MV+/ueiOEmpRSnkZkJd/OHguqvsY\n\tYV+1xv/jRW6WgsrpPJGhqgM5AoZZf1BTnyIHKfNKL6tmz1htx9gazeseb3j/lWI3aqdc\n\tDlYxZePSvc9+jbkyeRLGnJhej6r77KdRKjBwzyE02uotQuZmy36uBEkX0zTs88+C62yR\n\tSr7AmIsae7LOSv0VfjnmwPzEdO5OUfPXb6y4Yzy9JdqW/P0rkNyj0VhhDj4/EkKQeIj+\n\tcMXzIiaktXZjMkSZmLMIL+kt6UwYRTxwUr8pADUarCjf2lQk2l8ukLWKl/JzAoK9EPav\n\teLzw==","X-Gm-Message-State":"AJcUukd6mM7BDnru8WT5hhLKPW5gxXPlFhdzOIAsnrttE6aKNmG9fUxE\n\t9wxamSWf+4uMIfnpirVXx30EqA==","X-Google-Smtp-Source":"ALg8bN4+4MP4gGXgPdyqYvONoVLLndINylIrdQjXxAqO/EPegdrpNr5ELjdKw21gUaC0EIAruUVDgw==","X-Received":"by 2002:a19:d5:: with SMTP id 204mr10742860lfa.116.1547762275726;\n\tThu, 17 Jan 2019 13:57:55 -0800 (PST)","Date":"Thu, 17 Jan 2019 22:57:54 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190117215754.GL6484@bigcity.dyn.berto.se>","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>\n\t<20190117202043.21420-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190117202043.21420-2-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/5] test: timer: Initialise all\n\tvariables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 21:57:56 -0000"}}]