{"id":257,"url":"https://patchwork.libcamera.org/api/patches/257/?format=json","web_url":"https://patchwork.libcamera.org/patch/257/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190117202043.21420-2-kieran.bingham@ideasonboard.com>","date":"2019-01-17T20:20:39","name":"[libcamera-devel,1/5] test: timer: Initialise all variables","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"51dff08790ff6af9fc3c76050715c1a7e97b93f0","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/257/mbox/","series":[{"id":87,"url":"https://patchwork.libcamera.org/api/series/87/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=87","date":"2019-01-17T20:20:38","name":"General fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/87/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/257/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/257/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 102D560B2D\n\tfor ;\n\tThu, 17 Jan 2019 21:20:49 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 70B2C558;\n\tThu, 17 Jan 2019 21:20:48 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547756448;\n\tbh=/wol2C7SFb/6v3zR6PILBgk5x6EO0TLGLvwQnvpbflM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PWC3bWNvOiSLBGI9HnwkA5lVsGPF95AfgfxhuG8PkT6dZV8ITjiTWMJZBAmku9gz6\n\t99pR15/hwMB7f/v0Ow8vYaUkXEVcBJ/bJt5UY4JHrd/bc9UwqmHXObr+LevFo24mqV\n\todsr+8B1foNjPGvbS+/ac6+aKgZU38A6/fM3Kn7o=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Thu, 17 Jan 2019 20:20:39 +0000","Message-Id":"<20190117202043.21420-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>","References":"<20190117202043.21420-1-kieran.bingham@ideasonboard.com>","Subject":"[libcamera-devel] [PATCH 1/5] test: timer: Initialise all variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 17 Jan 2019 20:20:49 -0000"},"content":"The ManagedTimer does not initialise the integer 'interval_' variable.\n\nThis is set before used, and should not break - but for completeness\n(and to cover static analysers) initialise the variable in the\ninitialiser list.\n\nFixes: 034ea868027d (\"test: Add timer test\")\nSigned-off-by: Kieran Bingham \n---\n test/timer.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/test/timer.cpp b/test/timer.cpp\nindex 6a3cda70bef4..3d1a78ac2768 100644\n--- a/test/timer.cpp\n+++ b/test/timer.cpp\n@@ -19,7 +19,8 @@ using namespace libcamera;\n class ManagedTimer : public Timer\n {\n public:\n-\tManagedTimer() : Timer()\n+\tManagedTimer() :\n+\t\tTimer(), interval_(0)\n \t{\n \t\ttimeout.connect(this, &ManagedTimer::timeoutHandler);\n \t}\n","prefixes":["libcamera-devel","1/5"]}