[{"id":37532,"web_url":"https://patchwork.libcamera.org/comment/37532/","msgid":"<176789115553.3486172.10415420911595321369@ping.linuxembedded.co.uk>","date":"2026-01-08T16:52:35","subject":"Re: [PATCH v2 08/15] ipa: rkisp1: lsc: Move local types into\n\tanonymous namespace","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2026-01-08 16:05:51)\n> Move all local helpers into an anonymous namespace and drop a static\n> modifier that is no longer needed.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Kieran Bingham \n\n> \n> ---\n> \n> Changes in v2:\n> - Added this patch\n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 12 ++++++++----\n> 1 file changed, 8 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index 1962d18d148b4abac6e601ec36e0c68944a6191c..c42f74557c7364935254d75ee1fb923d176e0dbd 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -27,8 +27,6 @@ namespace libcamera {\n> \n> namespace ipa {\n> \n> -constexpr int kColourTemperatureChangeThreshhold = 10;\n> -\n> template\n> void interpolateVector(const std::vector &a, const std::vector &b,\n> std::vector &dest, double lambda)\n> @@ -70,6 +68,10 @@ namespace ipa::rkisp1::algorithms {\n> \n> LOG_DEFINE_CATEGORY(RkISP1Lsc)\n> \n> +namespace {\n> +\n> +constexpr int kColourTemperatureChangeThreshhold = 10;\n> +\n> class LscPolynomialLoader\n> {\n> public:\n> @@ -276,8 +278,8 @@ std::vector LscTableLoader::parseTable(const YamlObject &tuningData,\n> return table;\n> }\n> \n> -static std::vector parseSizes(const YamlObject &tuningData,\n> - const char *prop)\n> +std::vector parseSizes(const YamlObject &tuningData,\n> + const char *prop)\n> {\n> std::vector sizes =\n> tuningData[prop].getList().value_or(std::vector{});\n> @@ -306,6 +308,8 @@ static std::vector parseSizes(const YamlObject &tuningData,\n> return sizes;\n> }\n> \n> +} /* namespace */\n> +\n> LensShadingCorrection::LensShadingCorrection()\n> : lastAppliedCt_(0), lastAppliedQuantizedCt_(0)\n> {\n> \n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2E8DBDCBF\n\tfor ;\n\tThu, 8 Jan 2026 16:52:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1180D61FBB;\n\tThu, 8 Jan 2026 17:52:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2F17615B2\n\tfor ;\n\tThu, 8 Jan 2026 17:52:38 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18A4763B;\n\tThu, 8 Jan 2026 17:52:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CUb7ZVGw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767891136;\n\tbh=1nNfhC8ly8j6Li28a/4SaVCg3MYborq0tKvhEnZs5Gg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=CUb7ZVGwm9Ik7vePmsDcjYl/5XvnwFV6bdNBZDvjl3DHI0mkVZXMne8K/asotR3OT\n\ticmliVTGNVIdC2fsqRS8KlV2kvH32GdUgL7XN0zrj0QyJv0GTIQ9gAOdUo3RG0hImf\n\tvQhmqXBQIYzU+aVtdCtja4RkXDVwJr73wcrJQcbk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20260108-sklug-lsc-resampling-v2-dev-v2-8-e682ec4b9893@ideasonboard.com>","References":"<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>\n\t<20260108-sklug-lsc-resampling-v2-dev-v2-8-e682ec4b9893@ideasonboard.com>","Subject":"Re: [PATCH v2 08/15] ipa: rkisp1: lsc: Move local types into\n\tanonymous namespace","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 08 Jan 2026 16:52:35 +0000","Message-ID":"<176789115553.3486172.10415420911595321369@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37537,"web_url":"https://patchwork.libcamera.org/comment/37537/","msgid":"","date":"2026-01-09T09:37:17","subject":"Re: [PATCH v2 08/15] ipa: rkisp1: lsc: Move local types into\n\tanonymous namespace","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2026. 01. 08. 17:05 keltezéssel, Stefan Klug írta:\n> Move all local helpers into an anonymous namespace and drop a static\n> modifier that is no longer needed.\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> \n> Changes in v2:\n> - Added this patch\n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 12 ++++++++----\n> 1 file changed, 8 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index 1962d18d148b4abac6e601ec36e0c68944a6191c..c42f74557c7364935254d75ee1fb923d176e0dbd 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -27,8 +27,6 @@ namespace libcamera {\n> \n> namespace ipa {\n> \n> -constexpr int kColourTemperatureChangeThreshhold = 10;\n> -\n> template\n> void interpolateVector(const std::vector &a, const std::vector &b,\n> \t\t std::vector &dest, double lambda)\n> @@ -70,6 +68,10 @@ namespace ipa::rkisp1::algorithms {\n> \n> LOG_DEFINE_CATEGORY(RkISP1Lsc)\n> \n> +namespace {\n> +\n> +constexpr int kColourTemperatureChangeThreshhold = 10;\n> +\n> class LscPolynomialLoader\n> {\n> public:\n> @@ -276,8 +278,8 @@ std::vector LscTableLoader::parseTable(const YamlObject &tuningData,\n> \treturn table;\n> }\n> \n> -static std::vector parseSizes(const YamlObject &tuningData,\n> -\t\t\t\t const char *prop)\n> +std::vector parseSizes(const YamlObject &tuningData,\n> +\t\t\t const char *prop)\n> {\n> \tstd::vector sizes =\n> \t\ttuningData[prop].getList().value_or(std::vector{});\n> @@ -306,6 +308,8 @@ static std::vector parseSizes(const YamlObject &tuningData,\n> \treturn sizes;\n> }\n> \n> +} /* namespace */\n> +\n> LensShadingCorrection::LensShadingCorrection()\n> \t: lastAppliedCt_(0), lastAppliedQuantizedCt_(0)\n> {\n> \n> --\n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D3F3BDCBF\n\tfor ;\n\tFri, 9 Jan 2026 09:37:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D58CE61FA0;\n\tFri, 9 Jan 2026 10:37:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDAC8606D5\n\tfor ;\n\tFri, 9 Jan 2026 10:37:19 +0100 (CET)","from [192.168.33.17] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D41CA63B;\n\tFri, 9 Jan 2026 10:36:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EAWyjQok\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767951416;\n\tbh=6m0lzXWLqzUxBoCYArYdvfnzF2VUhKCN0d07uzbF3oQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=EAWyjQoktvTCtihvnG7sYTErKc22dUsteD7zZoxjTHWbiL3Nr4Fw67XJUfa1iW6ZF\n\tOS/+sTGAoNmcC5ql2nturJwOMGWnIiJBeLKEIrGqpI+s8+LA+OBP8uo3Rdsg3yJKF4\n\tt49aob20zQAaGvlSXXfCYFiQHZY1Fch5z0O39eCM=","Message-ID":"","Date":"Fri, 9 Jan 2026 10:37:17 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 08/15] ipa: rkisp1: lsc: Move local types into\n\tanonymous namespace","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>\n\t\n\t<20260108-sklug-lsc-resampling-v2-dev-v2-8-e682ec4b9893@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260108-sklug-lsc-resampling-v2-dev-v2-8-e682ec4b9893@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]