{"id":25693,"url":"https://patchwork.libcamera.org/api/patches/25693/?format=json","web_url":"https://patchwork.libcamera.org/patch/25693/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260108-sklug-lsc-resampling-v2-dev-v2-3-e682ec4b9893@ideasonboard.com>","date":"2026-01-08T16:05:46","name":"[v2,03/15] ipa: rkisp1: lsc: Replace assert with ASSERT","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8094acb57bebdfcfd211f102066d2286aa26def8","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25693/mbox/","series":[{"id":5697,"url":"https://patchwork.libcamera.org/api/series/5697/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5697","date":"2026-01-08T16:05:43","name":"Add resampling support for polynomial LSC data","version":2,"mbox":"https://patchwork.libcamera.org/series/5697/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25693/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25693/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C6D5BE08B\n\tfor ;\n\tThu, 8 Jan 2026 16:06:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE45D61FC0;\n\tThu, 8 Jan 2026 17:06:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2696561FA0\n\tfor ;\n\tThu, 8 Jan 2026 17:06:35 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:90af:8957:b721:10d4])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9DFE81C7B; \n\tThu, 8 Jan 2026 17:06:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XVNClCEz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767888372;\n\tbh=XclvvXKia3KXTQl/qKvBdoELOBtaOgq+NkY74Ldf5HU=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=XVNClCEzd1eYPsfr1yJKYhteKkootTuhP1CCndJlT71YMI1//KsUnoXA5JyI2jMxi\n\t9igaVNzLY1jk19e5B71Wm/+9qc+95U7veQwKY1vBto4La6Yl/TDrkMY86F2EuDTZpV\n\tcktP4vc+QuDjuzbm0TPb7Hq5LSrVIR6oaTZIiX+Y=","From":"Stefan Klug ","Date":"Thu, 08 Jan 2026 17:05:46 +0100","Subject":"[PATCH v2 03/15] ipa: rkisp1: lsc: Replace assert with ASSERT","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","Message-Id":"<20260108-sklug-lsc-resampling-v2-dev-v2-3-e682ec4b9893@ideasonboard.com>","References":"<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>","In-Reply-To":"<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug , =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= ,\n\tRui Wang ","X-Mailer":"b4 0.14.2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Replace assert() by ASSERT() and drop a set of unnecessary curly braces.\nThose were noticed in the former review but after the series was\napplied. Fix them now.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Barnabás Pőcze \nReviewed-by: Rui Wang \n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex ab0ada4eed46bc3fdbce17377164a7fbfb321957..c581e6441853d18618284b51bfa25c25e1fc8083 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -33,11 +33,10 @@ template\n void interpolateVector(const std::vector &a, const std::vector &b,\n \t\t std::vector &dest, double lambda)\n {\n-\tassert(a.size() == b.size());\n+\tASSERT(a.size() == b.size());\n \tdest.resize(a.size());\n-\tfor (size_t i = 0; i < a.size(); i++) {\n+\tfor (size_t i = 0; i < a.size(); i++)\n \t\tdest[i] = a[i] * (1.0 - lambda) + b[i] * lambda;\n-\t}\n }\n \n template<>\n@@ -167,8 +166,8 @@ private:\n \t\tdouble h = cropRectangle_.height / m;\n \t\tstd::vector res;\n \n-\t\tassert(xSizes_.size() * 2 + 1 == k);\n-\t\tassert(ySizes_.size() * 2 + 1 == k);\n+\t\tASSERT(xSizes_.size() * 2 + 1 == k);\n+\t\tASSERT(ySizes_.size() * 2 + 1 == k);\n \n \t\tres.reserve(k * k);\n \n","prefixes":["v2","03/15"]}