[{"id":37522,"web_url":"https://patchwork.libcamera.org/comment/37522/","msgid":"<20260107202625.GG20168@pendragon.ideasonboard.com>","date":"2026-01-07T20:26:25","subject":"Re: [RFC PATCH v1 3/5] libcamera: base: log: Ignore deprecations","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Wed, Jan 07, 2026 at 08:36:05PM +0100, Barnabás Pőcze wrote:\n> `std::atomic_{load,store}()` with `std::shared_ptr` has been deprecated\n> in C++20 in favour of `std::atomic>`. However, it is\n> not available on all supported platforms. So ignore the deprecation warnings.\n\nCould you please list the platforms that are missing it ? With that,\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/base/log.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index 6e6d2887c..b28217750 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -326,6 +326,11 @@ private:\n> \tstd::vector> categories_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> \tstd::list> levels_;\n> \n> +\t/*\n> +\t * \\todo Use `std::atomic>` and drop the pragma\n> +\t * once it works on all supported platforms.\n> +\t */\n> +#pragma GCC diagnostic ignored \"-Wdeprecated-declarations\"\n> \tstd::shared_ptr output_;\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2510BDCBF\n\tfor ;\n\tWed, 7 Jan 2026 20:26:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AEE861FC2;\n\tWed, 7 Jan 2026 21:26:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFD4F61F84\n\tfor ;\n\tWed, 7 Jan 2026 21:26:43 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E03A3593;\n\tWed, 7 Jan 2026 21:26:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mwi4DP5D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767817582;\n\tbh=hWNKSDyiVXx9kwAOzBMufJBgRvA4EentHkVi4xzswb4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mwi4DP5DKALn1XkXIQa3QVzxgIdMEzrmYO+Hq95YmDDCKAta1JfS0nl37q6DkmYGP\n\t7Ag1Bn/U2HJFZ0hCfHR1Fr6UEviFyNj62GLzh+RY3ik3e/MQ+mqWsgaDxU4aL8JpX3\n\tZILpQqzQBVAyb/ZrXoc8b9HAs2CZTjdhIFVtgKXg=","Date":"Wed, 7 Jan 2026 22:26:25 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ","Subject":"Re: [RFC PATCH v1 3/5] libcamera: base: log: Ignore deprecations","Message-ID":"<20260107202625.GG20168@pendragon.ideasonboard.com>","References":"<20260107193607.2168539-1-barnabas.pocze@ideasonboard.com>\n\t<20260107193607.2168539-4-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20260107193607.2168539-4-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37561,"web_url":"https://patchwork.libcamera.org/comment/37561/","msgid":"","date":"2026-01-12T09:51:11","subject":"Re: [RFC PATCH v1 3/5] libcamera: base: log: Ignore deprecations","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Barnabás,\n\n\nOn Wed, 7 Jan 2026 at 19:36, Barnabás Pőcze\n wrote:\n>\n> `std::atomic_{load,store}()` with `std::shared_ptr` has been deprecated\n> in C++20 in favour of `std::atomic>`. However, it is\n> not available on all supported platforms. So ignore the deprecation warnings.\n>\n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/libcamera/base/log.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\n> index 6e6d2887c..b28217750 100644\n> --- a/src/libcamera/base/log.cpp\n> +++ b/src/libcamera/base/log.cpp\n> @@ -326,6 +326,11 @@ private:\n> std::vector> categories_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n> std::list> levels_;\n>\n> + /*\n> + * \\todo Use `std::atomic>` and drop the pragma\n> + * once it works on all supported platforms.\n> + */\n> +#pragma GCC diagnostic ignored \"-Wdeprecated-declarations\"\n> std::shared_ptr output_;\n> };\n>\n> --\n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93FC5BDCBF\n\tfor ;\n\tMon, 12 Jan 2026 09:51:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF9EE61FA0;\n\tMon, 12 Jan 2026 10:51:49 +0100 (CET)","from mail-ua1-x935.google.com (mail-ua1-x935.google.com\n\t[IPv6:2607:f8b0:4864:20::935])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EDCD661F9F\n\tfor ;\n\tMon, 12 Jan 2026 10:51:47 +0100 (CET)","by mail-ua1-x935.google.com with SMTP id\n\ta1e0cc1a2514c-940e2630162so134840241.3\n\tfor ;\n\tMon, 12 Jan 2026 01:51:47 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"O15Hmp88\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1768211507; x=1768816307;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=4bklTfRts5HuINyeWUd7YBhCIYVoXhKBpbQkhsNNASU=;\n\tb=O15Hmp88VmHkC8qg0m8LSqvvu1rE3MzxkSzrgXbhy4fLXY7ol9IMipRJEO3o5dtrnx\n\tZdfudzjhz0RDQkR9nzUUYkcf86Dd8KsUbJOQVmzB7gt2e60RjiNGHrvTnQEZ+mlbtlfw\n\t6RwvzO7NAjauP6wShpL0P/sA546kXJiYFPZF+jgLvSDnTWYfT9Tv9P2C6vUloWnE99TK\n\tcHg9gPb0nm9/5zSmWOfx2Re3ZG9y0RuVXSg9r8WoZlh3JnV11wqcPpecz6dnpx/kFNy4\n\tpmuWdAaeA6nVpAIRqDYlA5flwsPpWl+UjwcP3HlCROnJ3ainbFFbBcdfL0rvuAUeCtNc\n\thylA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1768211507; x=1768816307;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=4bklTfRts5HuINyeWUd7YBhCIYVoXhKBpbQkhsNNASU=;\n\tb=dh31JJDAxQLmfvHu0B6M39FTU3+zKzHtzU2FR8DIMLFjHEZVk7bxO3ZtT6kt1I4TWp\n\tLAxTHf1Gquuz1JGca3k+iEiQKhH8d1PKKAqbE7UfT4zyxeyGopBjEQlgP+RxtR7kfhkn\n\t+CO6zQAAkxwqJXrY3XQbwTNG0uVVhYGV5Ytabg9EPgB2k9Al+6x54sOrt3rEksj5qIj8\n\tU68EF38iMg9KDaDhSoIr5VgtPg08RVbckR1DbmlY0m701Pb+ZWP8hr1KS4Rplu+1lkFF\n\tWGw6dYgc6cOP6s+VTd9UEEEU3tuujLhXUK3J8bp83Pq37bvsf3MicKhq+kc3w7CxwxkA\n\t/P+g==","X-Gm-Message-State":"AOJu0YzAdLyfZQ2wQRtS1B708CcEeKKowYKR4m9Zdr7WEANf309xTt/E\n\tPLGsTEOmJDNnbgpyA+02dDSH0yBlchffpaCF4uSqiGxtimSyKyhehVMuGsSCBbKW9rL9AVp9jHB\n\tgABWZuye7Cqa4UxTz6mQshwZQ5QUq4SYRllQoO3ASNA==","X-Gm-Gg":"AY/fxX5fUn9YjrdPER+1Gh+AFo5P/n/lnGA+njKdQMdu3pxXP3j1rGlm4kcvKzHA7tQ\n\tw26oM8ZJPUepnC4NmYo+SsTzZVJWid5WJank4CJKQ0uTsB8GVi/414bglkJsMOoWvijD7AVSKKw\n\tAIyZUq0u0+lQjGxDPJW+jQcX5D4hkZ0SYfpQBrFaHxtK3rJs2a/fZfqLaH+YiQm0qib9QPuVhKp\n\tzML8MSfAhYvoKitxpnsbR/+u9vxDmBh8awZSY7jKmaUgfIycYkhh59ovEjsEGTNxr++d5DRRwJW\n\tA0IRCbIq2wtBm21OQs652mIvtVc=","X-Google-Smtp-Source":"AGHT+IHQZQn2pS1K1xYww9AhhOJFQ4cByiDp2eusMHKG9C57dW3speiYOMZqTQE1b5957qVWb7p4plBGH9KHs8WdWzU=","X-Received":"by 2002:a67:cb02:0:b0:5e4:933e:5748 with SMTP id\n\tada2fe7eead31-5ecb698f954mr3454034137.7.1768211506858;\n\tMon, 12 Jan 2026 01:51:46 -0800 (PST)","MIME-Version":"1.0","References":"<20260107193607.2168539-1-barnabas.pocze@ideasonboard.com>\n\t<20260107193607.2168539-4-barnabas.pocze@ideasonboard.com>","In-Reply-To":"<20260107193607.2168539-4-barnabas.pocze@ideasonboard.com>","From":"Naushir Patuck ","Date":"Mon, 12 Jan 2026 09:51:11 +0000","X-Gm-Features":"AZwV_Qi7j6Y0wzDk_aNJv8QfDD3g742hXc5x8DSvxmUMjprPtIsvLSYX-WtrRRg","Message-ID":"","Subject":"Re: [RFC PATCH v1 3/5] libcamera: base: log: Ignore deprecations","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]