[{"id":37508,"web_url":"https://patchwork.libcamera.org/comment/37508/","msgid":"","date":"2026-01-07T10:50:14","subject":"Re: [PATCH] libcamera: control_serializer: Remove unnecessary\n\tallocation","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Paul\n\nOn 07/01/2026 10:38, Paul Elder wrote:\n> In between versions of the patch \"libcamera: control_serializer: Add\n> array info to serialized ControlValue\", ipa_control_value_entry was\n> changed to be members of ipa_control_info_entry as opposed to being\n> serialized at the same level. The binarySize/entriesSize computation was\n> not updated, however, leaving some extra memory allocated for the\n> serialized form of ControlInfoMap.\n> \n> Fix this by removing the extra size for 3 * ipa_control_value_entry..\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Daniel Scally \n> ---\n> src/libcamera/control_serializer.cpp | 6 ++----\n> 1 file changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> index 843e2772f848..8812e6e23d5a 100644\n> --- a/src/libcamera/control_serializer.cpp\n> +++ b/src/libcamera/control_serializer.cpp\n> @@ -164,8 +164,7 @@ size_t ControlSerializer::binarySize(const ControlInfo &info)\n> size_t ControlSerializer::binarySize(const ControlInfoMap &infoMap)\n> {\n> \tsize_t size = sizeof(struct ipa_controls_header)\n> -\t\t + infoMap.size() * (sizeof(struct ipa_control_info_entry) +\n> -\t\t\t\t\t3 * sizeof(struct ipa_control_value_entry));\n> +\t\t + infoMap.size() * (sizeof(struct ipa_control_info_entry));\n> \n> \tfor (const auto &ctrl : infoMap)\n> \t\tsize += binarySize(ctrl.second);\n> @@ -234,8 +233,7 @@ int ControlSerializer::serialize(const ControlInfoMap &infoMap,\n> \n> \t/* Compute entries and data required sizes. */\n> \tsize_t entriesSize = infoMap.size()\n> -\t\t\t * (sizeof(struct ipa_control_info_entry) +\n> -\t\t\t 3 * sizeof(struct ipa_control_value_entry));\n> +\t\t\t * (sizeof(struct ipa_control_info_entry));\n> \tsize_t valuesSize = 0;\n> \tfor (const auto &ctrl : infoMap)\n> \t\tvaluesSize += binarySize(ctrl.second);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BD23BE08B\n\tfor ;\n\tWed, 7 Jan 2026 10:50:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAE6061FBB;\n\tWed, 7 Jan 2026 11:50:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE9AF61F61\n\tfor ;\n\tWed, 7 Jan 2026 11:50:17 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D740ED0;\n\tWed, 7 Jan 2026 11:49:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d0JVFSUo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767782995;\n\tbh=fZNGJorZAGakHFr4KLlSdwNh6PbjKdXg6850QbjMXPY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=d0JVFSUozIgTUppd9n+3sUyspWEssGd70cTWpGHuQlF/R8+jxe+EWNPg7HQgo1Jjo\n\txa1vqawx1eVzwtda7CoTQ60vcGbaJRxQkN7Q4mJYwOsdqKL+eJ72L26U1MwfQ2X2O0\n\t9YI0ug/u/c0AWPZpGDTr9bK1nCXw5Eact42VdfWM=","Message-ID":"","Date":"Wed, 7 Jan 2026 10:50:14 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: control_serializer: Remove unnecessary\n\tallocation","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260107103830.1415267-1-paul.elder@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","In-Reply-To":"<20260107103830.1415267-1-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37511,"web_url":"https://patchwork.libcamera.org/comment/37511/","msgid":"","date":"2026-01-07T11:32:51","subject":"Re: [PATCH] libcamera: control_serializer: Remove unnecessary\n\tallocation","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2026. 01. 07. 11:38 keltezéssel, Paul Elder írta:\n> In between versions of the patch \"libcamera: control_serializer: Add\n> array info to serialized ControlValue\", ipa_control_value_entry was\n> changed to be members of ipa_control_info_entry as opposed to being\n> serialized at the same level. The binarySize/entriesSize computation was\n> not updated, however, leaving some extra memory allocated for the\n> serialized form of ControlInfoMap.\n> \n> Fix this by removing the extra size for 3 * ipa_control_value_entry..\n\nExtra `.` at the end?\n\n\n> \n> Signed-off-by: Paul Elder \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/control_serializer.cpp | 6 ++----\n> 1 file changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> index 843e2772f848..8812e6e23d5a 100644\n> --- a/src/libcamera/control_serializer.cpp\n> +++ b/src/libcamera/control_serializer.cpp\n> @@ -164,8 +164,7 @@ size_t ControlSerializer::binarySize(const ControlInfo &info)\n> size_t ControlSerializer::binarySize(const ControlInfoMap &infoMap)\n> {\n> \tsize_t size = sizeof(struct ipa_controls_header)\n> -\t\t + infoMap.size() * (sizeof(struct ipa_control_info_entry) +\n> -\t\t\t\t\t3 * sizeof(struct ipa_control_value_entry));\n> +\t\t + infoMap.size() * (sizeof(struct ipa_control_info_entry));\n> \n> \tfor (const auto &ctrl : infoMap)\n> \t\tsize += binarySize(ctrl.second);\n> @@ -234,8 +233,7 @@ int ControlSerializer::serialize(const ControlInfoMap &infoMap,\n> \n> \t/* Compute entries and data required sizes. */\n> \tsize_t entriesSize = infoMap.size()\n> -\t\t\t * (sizeof(struct ipa_control_info_entry) +\n> -\t\t\t 3 * sizeof(struct ipa_control_value_entry));\n> +\t\t\t * (sizeof(struct ipa_control_info_entry));\n> \tsize_t valuesSize = 0;\n> \tfor (const auto &ctrl : infoMap)\n> \t\tvaluesSize += binarySize(ctrl.second);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0AD24BE08B\n\tfor ;\n\tWed, 7 Jan 2026 11:32:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 217A661FBB;\n\tWed, 7 Jan 2026 12:32:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB1FB61F84\n\tfor ;\n\tWed, 7 Jan 2026 12:32:54 +0100 (CET)","from [192.168.33.35] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3625573B;\n\tWed, 7 Jan 2026 12:32:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q8tW4NI9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767785553;\n\tbh=WaOmSUK/bNhDNLaFWIlUPoVlxH/Hn3d2qYOL0xAnNqI=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Q8tW4NI9FPsdCtyvv2xhB7aGOIpNU8O12nisECUEteq94vWKhnvB5D+xu8Em7j8eX\n\tpvWRNhIjWkQ2uS/RCzwK5VXUB+1dNGMrkQulZlZ6SbMEMKF8Gg62UVWtTAUW6BZm4O\n\tyrwaqxNsP/BI59WOrdsjMIljH+avtA6RT74UFCsI=","Message-ID":"","Date":"Wed, 7 Jan 2026 12:32:51 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: control_serializer: Remove unnecessary\n\tallocation","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20260107103830.1415267-1-paul.elder@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20260107103830.1415267-1-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37512,"web_url":"https://patchwork.libcamera.org/comment/37512/","msgid":"<20260107132644.GA27019@pendragon.ideasonboard.com>","date":"2026-01-07T13:26:44","subject":"Re: [PATCH] libcamera: control_serializer: Remove unnecessary\n\tallocation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Jan 07, 2026 at 07:38:30PM +0900, Paul Elder wrote:\n> In between versions of the patch \"libcamera: control_serializer: Add\n> array info to serialized ControlValue\", ipa_control_value_entry was\n> changed to be members of ipa_control_info_entry as opposed to being\n> serialized at the same level. The binarySize/entriesSize computation was\n> not updated, however, leaving some extra memory allocated for the\n> serialized form of ControlInfoMap.\n> \n> Fix this by removing the extra size for 3 * ipa_control_value_entry..\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/control_serializer.cpp | 6 ++----\n> 1 file changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\n> index 843e2772f848..8812e6e23d5a 100644\n> --- a/src/libcamera/control_serializer.cpp\n> +++ b/src/libcamera/control_serializer.cpp\n> @@ -164,8 +164,7 @@ size_t ControlSerializer::binarySize(const ControlInfo &info)\n> size_t ControlSerializer::binarySize(const ControlInfoMap &infoMap)\n> {\n> \tsize_t size = sizeof(struct ipa_controls_header)\n> -\t\t + infoMap.size() * (sizeof(struct ipa_control_info_entry) +\n> -\t\t\t\t\t3 * sizeof(struct ipa_control_value_entry));\n> +\t\t + infoMap.size() * (sizeof(struct ipa_control_info_entry));\n\nYou can remove the parenthesis around sizeof.\n\n> \n> \tfor (const auto &ctrl : infoMap)\n> \t\tsize += binarySize(ctrl.second);\n> @@ -234,8 +233,7 @@ int ControlSerializer::serialize(const ControlInfoMap &infoMap,\n> \n> \t/* Compute entries and data required sizes. */\n> \tsize_t entriesSize = infoMap.size()\n> -\t\t\t * (sizeof(struct ipa_control_info_entry) +\n> -\t\t\t 3 * sizeof(struct ipa_control_value_entry));\n> +\t\t\t * (sizeof(struct ipa_control_info_entry));\n\nSame here.\n\nReviewed-by: Laurent Pinchart \n\n> \tsize_t valuesSize = 0;\n> \tfor (const auto &ctrl : infoMap)\n> \t\tvaluesSize += binarySize(ctrl.second);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CBCD7BDCBF\n\tfor ;\n\tWed, 7 Jan 2026 13:27:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D72F261FA0;\n\tWed, 7 Jan 2026 14:27:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5686761F84\n\tfor ;\n\tWed, 7 Jan 2026 14:27:03 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 588CA557;\n\tWed, 7 Jan 2026 14:26:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wAwEQmqW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767792401;\n\tbh=x2q9Qq0siBCxLvgy8uNEgEOodUH4JpfIG9uLbD4iKwE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wAwEQmqWl10ckz/yPJlVgZssmEV5btIUPKutANTLLtMrOf4rPJAr7coggaujof/B+\n\tDe/bTZD2IlSuYFbNhcucri9eeEYhkCm08xT2xPVWCehSzxBHL98z7k+Vl2wXoNowMT\n\tPM3RJjyxuXfQVQNlUcw/W0qc16WXQ4JRd3NxqCd8=","Date":"Wed, 7 Jan 2026 15:26:44 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: control_serializer: Remove unnecessary\n\tallocation","Message-ID":"<20260107132644.GA27019@pendragon.ideasonboard.com>","References":"<20260107103830.1415267-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260107103830.1415267-1-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]