{"id":25662,"url":"https://patchwork.libcamera.org/api/patches/25662/?format=json","web_url":"https://patchwork.libcamera.org/patch/25662/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20260106170059.56193-10-bryan.odonoghue@linaro.org>","date":"2026-01-06T17:00:44","name":"[v11,09/24] libcamera: shaders: Add support for black level compensation","commit_ref":"6029dcf9a6dee38130bef23750444867cb517018","pull_url":null,"state":"accepted","archived":false,"hash":"1e4d840dcfd8f9799dd645f70a5f669ba26f823b","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25662/mbox/","series":[{"id":5689,"url":"https://patchwork.libcamera.org/api/series/5689/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5689","date":"2026-01-06T17:00:35","name":"Add GLES 2.0 GPUISP to libcamera","version":10,"mbox":"https://patchwork.libcamera.org/series/5689/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25662/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25662/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3F09BDCC0\n\tfor ;\n\tTue, 6 Jan 2026 17:01:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D4856200F;\n\tTue, 6 Jan 2026 18:01:18 +0100 (CET)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D20C6200D\n\tfor ;\n\tTue, 6 Jan 2026 18:01:14 +0100 (CET)","by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-4775ae77516so13072525e9.1\n\tfor ;\n\tTue, 06 Jan 2026 09:01:14 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jan 2026 09:01:12 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"jHotMmce\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1767718874; x=1768323674;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=;\n\tb=jHotMmceuVQWtt2vCL4tt2JIeiZiunHPvS4OWghvc1sLpYQSvQf5vlxxWDCqpxEIno\n\tg7BjWfiFAnCM8H/Q5HO9yU5ibj3KD0XvC3fqxG9Tbn3SDd5zSg538zHDDJJSmbTecNcq\n\tYO/VUjnWpB6JGnZZzemvaVMJDyGE4azhBjE3eJfjCNqrneNlib+YWfOG8KMGqVKjYhIl\n\t83yXN7DzojM//0pvhMr8posd46S6PByYYPcWm8195wWKu0iw/kKWHIpa3PIGIa/F24P4\n\tYlrvVVEPojBsj8v/PDD+nAWAdC/QzN4OVeKBrvb645tw2jyaXXpGomDLMgKGiPX68N0h\n\tDN4Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767718874; x=1768323674;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=;\n\tb=rY/SxSWkPEGlysZ8TvFZXcEpA9XnKCU+QQumEymRd3pUXMlUs7lSSTS5+YtvxhVKpz\n\t4vv4BcJ8HBizDiyPtlG+8Txztbqq4M5QcvQzDwyvuv3lVNc0ZWzoFgOJ9zfq5re0dby+\n\tfssj9TSSLo+VDI5v8zCdeZvbrwkUKCGjPLFuFsyNDwUwgJaUr/udRc1Yow/ZBmsFq2os\n\t+v+dWyeTTXgKoQD5IWDLneabXpfYW0fC2Qkmwu7xTt/1tVLThTqhh4TGB/3FLgORjN70\n\tYnsuEfgkA6B+JrVWDvFbjl1jCoCCWHnAxxXkMRXJtf3LvTefMAv+WUoWqQTgfNT+rTHZ\n\tIHjg==","X-Gm-Message-State":"AOJu0YwSvqYwV17RROP9IcwKAsLaYMHPp3VRgkRhAIAJuVnVMgTmcJFv\n\tQMnlqDBfkTePLisR0xkfq0kCnVbRHx72Gr/qCNwWTuJIYHeBjonUJxtCCbh8AL3rx33FIQphkkO\n\t22oLy9Tk=","X-Gm-Gg":"AY/fxX5xxJlHY0cqeBcQw7YqO4gW6S2qxs35q4GojPOrIbvfwhXZJDAJrPcyYYAOxIH\n\tCYgdKdkxvObK2vPKBaGp6iO1sBoVChvbjWSYsIm59NXX14oJN2npB856RFWGcdksxG+DbA93BHu\n\tG0wMDAl3toWWqlXiR0lH4ZBAXj8Jbmstb2lWdBLPhIwlstdrsGqAkBG6CdnDvWLWDOSG+nl1MK+\n\tXZjXPSuhoaDA+vWbSkE5Xs1ZnJp38G8LDYJgldCUT8T405DgTct+ZqvTbE33AC189C0VWHlyVFe\n\tL+3wVqi6g8D/0tg6Rhiq37/3fAhBdZhy6TxY0M5gxIxqbCwvjAChRl0tmdoKtSGJcCcegyLKQFm\n\tDrM22rp7sOywDN4JBfzocGT4+tWUZWIlpwCJ1R5pQ52wJCBPgSN4NmdY2EwRHrW1epXYqWa2YYz\n\t22T8kkohfZBumZ5UA81ytJh5lnluU0TLBbjeF0GZh84TFKBuf03QQv7ta9mdTKZ3swmrY=","X-Google-Smtp-Source":"AGHT+IGk04wS6fiwL2wtMDFH/ztDpNqMqNc48Kz8v8UVM+7jXklUA4Va1pvciKOKJa64TPKDoZ1CLA==","X-Received":"by 2002:a05:600c:818f:b0:471:131f:85b7 with SMTP id\n\t5b1f17b1804b1-47d7f076b6fmr41724875e9.15.1767718873182; \n\tTue, 06 Jan 2026 09:01:13 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tMilan Zamazal ","Subject":"[PATCH v11 09/24] libcamera: shaders: Add support for black level\n\tcompensation","Date":"Tue, 6 Jan 2026 17:00:44 +0000","Message-ID":"<20260106170059.56193-10-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260106170059.56193-1-bryan.odonoghue@linaro.org>","References":"<20260106170059.56193-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add the ability to apply a int blacklevel gain against the demosaiced data\nprior to application of colour correction data.\n\nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/shaders/bayer_1x_packed.frag | 3 +++\n src/libcamera/shaders/bayer_unpacked.frag | 3 +++\n 2 files changed, 6 insertions(+)","diff":"diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex db8c2a0b3..7036fe278 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -66,6 +66,7 @@ uniform vec2 tex_bayer_first_red;\n \n uniform sampler2D tex_y;\n uniform mat3 ccm;\n+uniform vec3 blacklevel;\n \n void main(void)\n {\n@@ -213,6 +214,8 @@ void main(void)\n \t\t\tvec3(patterns.y, C, patterns.x) :\n \t\t\tvec3(patterns.wz, C));\n \n+\trgb = rgb - blacklevel;\n+\n \t/*\n \t * CCM is a 3x3 in the format\n \t *\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 06d80f3dd..f0d8cd1e2 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -25,6 +25,7 @@ varying vec4 center;\n varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3 ccm;\n+uniform vec3 blacklevel;\n \n void main(void) {\n vec3 rgb;\n@@ -108,6 +109,8 @@ void main(void) {\n vec3(PATTERN.w, C, PATTERN.z) :\n vec3(PATTERN.yx, C));\n \n+ rgb = rgb - blacklevel;\n+\n /*\n * CCM is a 3x3 in the format\n *\n","prefixes":["v11","09/24"]}