[{"id":37455,"web_url":"https://patchwork.libcamera.org/comment/37455/","msgid":"<85ms2wpb8j.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-02T10:20:12","subject":"Re: [PATCH] libcamera: software_isp: Always report saturation\n\tmetadata","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Kieran,\n\nthank you for the patch.\n\nKieran Bingham writes:\n\n> When the saturation is applied the metadata is reported for one frame\n> only. Once the colour temperature and saturation is stable, the\n> metadata for the saturation is not stored into the frame context and\n> therefore not reported in the completed request metadata.\n>\n> Update the CCM component to also store the applied saturation in the\n> frameContext so that it can be reported in the metadata.\n>\n> Fixes: 59ac34b728c5 (\"libcamera: software_isp: Add saturation control\")\n> Signed-off-by: Kieran Bingham \n> ---\n>\n> This is visible when the CCM is enabled, which is more convenient to\n> test now that we have the GPU ISP enablement where I noticed this - but\n> it's still applicable directly to mainline too.\n>\n> src/ipa/simple/algorithms/ccm.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/simple/algorithms/ccm.cpp b/src/ipa/simple/algorithms/ccm.cpp\n> index 0a98406c1a3a..f28b1037d2d2 100644\n> --- a/src/ipa/simple/algorithms/ccm.cpp\n> +++ b/src/ipa/simple/algorithms/ccm.cpp\n> @@ -95,6 +95,7 @@ void Ccm::prepare(IPAContext &context, const uint32_t frame,\n> \t utils::abs_diff(ct, lastCt_) < kTemperatureThreshold &&\n> \t saturation == lastSaturation_) {\n> \t\tframeContext.ccm.ccm = context.activeState.ccm.ccm;\n> +\t\tframeContext.saturation = saturation;\n\nOr the same assignment present a few lines below could be moved before\nthis check. With or without this change:\n\nReviewed-by: Milan Zamazal \n\n> \t\tcontext.activeState.ccm.changed = false;\n> \t\treturn;\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BF80BDCBF\n\tfor ;\n\tFri, 2 Jan 2026 10:20:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99FBD61FA0;\n\tFri, 2 Jan 2026 11:20:20 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F6436142F\n\tfor ;\n\tFri, 2 Jan 2026 11:20:18 +0100 (CET)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-284-BS5Wm8QwNvSAoIRQqUcZng-1; Fri, 02 Jan 2026 05:20:16 -0500","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-430fc153d50so9291889f8f.1\n\tfor ;\n\tFri, 02 Jan 2026 02:20:15 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-4324ea830f3sm83029971f8f.22.2026.01.02.02.20.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Jan 2026 02:20:13 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"C+ER/Mo3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1767349217;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=EFfEY00ZQ5S6+p/RvwZFCd7Ji1ThlT3D+vAIvSZQL5s=;\n\tb=C+ER/Mo3+josFPaBvZXr0tOcDkMwCe/PzHnME5w0D6z5oQNM83HRhXwemcpn5PpnsDTMB7\n\t0d0DyxuoTbn5N6mow80r85CpCI8eKA5GYMMHfuYRofD583flszqaxj+7PxIa6NcchZDpff\n\tLc+AwZfdWlo2HH5FvFxfpuYWPW22cO4=","X-MC-Unique":"BS5Wm8QwNvSAoIRQqUcZng-1","X-Mimecast-MFC-AGG-ID":"BS5Wm8QwNvSAoIRQqUcZng_1767349215","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767349214; x=1767954014;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=EFfEY00ZQ5S6+p/RvwZFCd7Ji1ThlT3D+vAIvSZQL5s=;\n\tb=Xz3lgI9bMkxTziOqlXmSzPx+2523UJAbVAfl9tzN5+G51dElgOhj6SV7FDjdGjY5vR\n\trUlz0B2Sg1HKavPasAIW+aToshYp7QHREX7USesZJXq8374QUDl98cvNeIetIXOUmQ0Y\n\tl8FeaeqaI7CD9LbCtgSXiMKurwM0+cQgSS8ZYZCEt8S0a9Ur+w15lrK+uQhabKU51e3p\n\tCnLO/jn8QseZ+FPDYcN2/doltb5kJesN8kHD/IXFj/rkYiwAPS1HcuuRdal8wOfOBhkP\n\tCAqxzUY57wLauYMCla2EWN8OrmF5AZrkG3XhMsvFQ/cvKUiCQVusMQbxmgHs/+Cc/BAE\n\te/Qg==","X-Gm-Message-State":"AOJu0YyNBiin36aUHMLiFAwxG2E5Lk+cY84TMSkHCAEftnwnv9h4ck0/\n\trZ9AIEWFG8lJSlgnepEgnFWABYKJNOstLNOjaz/sW3zXM5ncwxU8IiprmXtPfXyUSfSiRYZW2L6\n\t01PAif7T9gVQjGLtMCFOFuyzm/so3bvmFhA6rhH/E5QtzCzxYHEZczzL8KAwy1GN4JdS7NMU464\n\toBud2XwybtYlIHI1eMk8JOcrkCslB3o2rIySE9jV0RB2dIWViEoeIw+Kyai1c=","X-Gm-Gg":"AY/fxX7t3HRJdJmGmF+dEKnsT8b1ScpDXF16x9IIqBTqu73bpC/hBk+FeNEAsbI4/qF\n\trLRWqV8TvHUmTDwQilFfGXeIa/+WPyO5UAwg+Frc3ViwS/GSXxoVCCQvNI4S7uTsmpmGcvbzdk9\n\tvWBZszlQ233CxQvF8tzIQz4+YGZOxZecPamBebE8fhmI2IyxcSSUygZMT+s7Kbz2c0fcrAG6bYQ\n\tjf9CYJ9HJmmHI7TufbstDCVGDBahLt6c3e4Y3NMg/SNHd7r289M/F2gDjeHYWw7CY5wDbVgEnZo\n\t6Ab62KJh5BDUgO71eKO8qWOMkZL287uTVnADGTaJJswtNZ+hKDMuR06KLYNInHlSH19UBiCHDLJ\n\tyKjyQPtE7ySkHnDKqNRD231MDyQYgjwJTGXp5emto9ICIa9g9CvIcv0BXrqvAH4c=","X-Received":["by 2002:a05:6000:1865:b0:430:fd69:9920 with SMTP id\n\tffacd0b85a97d-4324e4cb8fcmr42602714f8f.16.1767349214097; \n\tFri, 02 Jan 2026 02:20:14 -0800 (PST)","by 2002:a05:6000:1865:b0:430:fd69:9920 with SMTP id\n\tffacd0b85a97d-4324e4cb8fcmr42602692f8f.16.1767349213618; \n\tFri, 02 Jan 2026 02:20:13 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IFiO2BzMmvEfFbQwDUqKaJI0nG6muws3ZWQ7gXQw55/hR7rxC7EA2/jReDA3DTE6QHk10dG6g==","From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH] libcamera: software_isp: Always report saturation\n\tmetadata","In-Reply-To":"<20251229194152.1087528-1-kieran.bingham@ideasonboard.com>\n\t(Kieran Bingham's message of \"Mon, 29 Dec 2025 19:41:52 +0000\")","References":"<20251229194152.1087528-1-kieran.bingham@ideasonboard.com>","Date":"Fri, 02 Jan 2026 11:20:12 +0100","Message-ID":"<85ms2wpb8j.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"iaqz0vN73tDaLGGiwpMJYEfWnTilTIGAD2hh0LLQI50_1767349215","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]