[{"id":37441,"web_url":"https://patchwork.libcamera.org/comment/37441/","msgid":"<176647140715.3205628.392203161513068054@freya>","date":"2025-12-23T06:30:07","subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","submitter":{"id":223,"url":"https://patchwork.libcamera.org/api/people/223/","name":"Jai Luthra","email":"jai.luthra@ideasonboard.com"},"content":"Hi Robert,\n\nQuoting Robert Mader (2025-12-20 02:40:06)\n> Since commit \"libcamera: simple: Make raw streams working\" apps that rely\n> on raw streams - such as Millipixels - can work with the SoftISP being\n> enabled. Thus let's enable the later by default.\n> \n> Tested on a Librem5.\n> \n> Signed-off-by: Robert Mader \n\nCould you also append i.MX7 under the list of platforms supported by\nCPU-based ISP in Documentation/isp-feature-matrix.rst ?\n\nFor this patch,\n\nReviewed-by: Jai Luthra \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index b30b0a122..4a0b9f58d 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -257,7 +257,7 @@ namespace {\n> \n> static const SimplePipelineInfo supportedDevices[] = {\n> { \"dcmipp\", {}, false },\n> - { \"imx7-csi\", { { \"pxp\", 1 } }, false },\n> + { \"imx7-csi\", { { \"pxp\", 1 } }, true },\n> { \"intel-ipu6\", {}, true },\n> { \"intel-ipu7\", {}, true },\n> { \"j721e-csi2rx\", {}, true },\n> -- \n> 2.52.0\n> \n\nThanks,\nJai","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB282BD160\n\tfor ;\n\tTue, 23 Dec 2025 06:30:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 744AA61F9F;\n\tTue, 23 Dec 2025 07:30:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 634C5610A6\n\tfor ;\n\tTue, 23 Dec 2025 07:30:22 +0100 (CET)","from mail.ideasonboard.com (unknown [223.190.85.95])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 802045B2;\n\tTue, 23 Dec 2025 07:30:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hx8hSLXu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1766471411;\n\tbh=ujobqw03SKddPLw9+NF41QZBr1GD0k6XLV2faBRuZhk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=hx8hSLXuVvK+fax2hPQjcYRxFVtpGqFJ4LLIvd5QpsUP7ybw6+5bOSMS64sCo4iJJ\n\tS0O3daFMeHBQ4hXCuX9qsANOI3Qh8gU4LhOMH20kc7wETzhqLSDw47EtODxgXzExCy\n\tyF4JIY0ssaFIVRjBD/+gClgFpBHId1NQ3fY1/pfU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251219211006.104821-1-robert.mader@collabora.com>","References":"<20251219211006.104821-1-robert.mader@collabora.com>","Subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","From":"Jai Luthra ","Cc":"Robert Mader ","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 23 Dec 2025 12:00:07 +0530","Message-ID":"<176647140715.3205628.392203161513068054@freya>","User-Agent":"alot/0.12.dev62+gb9d6144a6","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37442,"web_url":"https://patchwork.libcamera.org/comment/37442/","msgid":"<20251223095527.GE9817@pendragon.ideasonboard.com>","date":"2025-12-23T09:55:27","subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Dec 19, 2025 at 10:10:06PM +0100, Robert Mader wrote:\n> Since commit \"libcamera: simple: Make raw streams working\" apps that rely\n> on raw streams - such as Millipixels - can work with the SoftISP being\n> enabled. Thus let's enable the later by default.\n> \n> Tested on a Librem5.\n\nThis is an interesting one. I assume the librem5 has enough CPU (and\npossibly GPU, once Bryan series lands) power to support this. The\n\"imx7-csi\" driver name is however also used by i.MX6UL, i.MX7S, i.MX7D\nand i.MX8MM. Do we really want to enable the soft ISP on all those\nplatforms ?\n\n> Signed-off-by: Robert Mader \n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index b30b0a122..4a0b9f58d 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -257,7 +257,7 @@ namespace {\n> \n> static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"dcmipp\", {}, false },\n> -\t{ \"imx7-csi\", { { \"pxp\", 1 } }, false },\n> +\t{ \"imx7-csi\", { { \"pxp\", 1 } }, true },\n> \t{ \"intel-ipu6\", {}, true },\n> \t{ \"intel-ipu7\", {}, true },\n> \t{ \"j721e-csi2rx\", {}, true },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07FEDBDCBF\n\tfor ;\n\tTue, 23 Dec 2025 09:55:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BA8061F90;\n\tTue, 23 Dec 2025 10:55:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B79A761A35\n\tfor ;\n\tTue, 23 Dec 2025 10:55:45 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-152.bb.dnainternet.fi\n\t[81.175.209.152])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BAF9E593;\n\tTue, 23 Dec 2025 10:55:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PZ5xq/V3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1766483734;\n\tbh=sRFuAkNjqf5W7aOvxx10HvO4+ZNA8XFORnWZvnHyV3Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PZ5xq/V318aSjna1+iMj6HlshKpq3JRy+jLE+6PfCThsj+im3Jy+XFZfToZOyXhPh\n\t1kPXuajP9A3v9Lc7D4UwKu8UCMFMigVxDzGP3SuXU7sDN3cQUphs3uJ21dqLKwr6uC\n\tPRB4P1qCkC6DK43mjTdBTKQqoi+cItb1DqAvL9D8=","Date":"Tue, 23 Dec 2025 11:55:27 +0200","From":"Laurent Pinchart ","To":"Robert Mader ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","Message-ID":"<20251223095527.GE9817@pendragon.ideasonboard.com>","References":"<20251219211006.104821-1-robert.mader@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251219211006.104821-1-robert.mader@collabora.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37443,"web_url":"https://patchwork.libcamera.org/comment/37443/","msgid":"<6da32085-d448-4e6a-9e0a-ec1b3fb66e09@collabora.com>","date":"2025-12-23T10:23:30","subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 23.12.25 10:55, Laurent Pinchart wrote:\n> On Fri, Dec 19, 2025 at 10:10:06PM +0100, Robert Mader wrote:\n>> Since commit \"libcamera: simple: Make raw streams working\" apps that rely\n>> on raw streams - such as Millipixels - can work with the SoftISP being\n>> enabled. Thus let's enable the later by default.\n>>\n>> Tested on a Librem5.\n> This is an interesting one. I assume the librem5 has enough CPU (and\n> possibly GPU, once Bryan series lands) power to support this. The\n> \"imx7-csi\" driver name is however also used by i.MX6UL, i.MX7S, i.MX7D\n> and i.MX8MM. Do we really want to enable the soft ISP on all those\n> platforms ?\n\nIndeed, I suppose it raises the broader question of: do we need to \nprotect users from using the soft ISP?\n\nSome platforms that are too slow to sustain high enough framerates for a \nviewfinder/video might still benefit from the possibility to take single \npictures, IMO making it worth enable the feature. We might go as far as \nunconditionally enabling it for all platform - as long as it can be \nturned of at build or runtime.\n\nDo you see a reason / a scenario where this could have negative impact?\n\n>> Signed-off-by: Robert Mader\n>> ---\n>> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>> index b30b0a122..4a0b9f58d 100644\n>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> @@ -257,7 +257,7 @@ namespace {\n>> \n>> static const SimplePipelineInfo supportedDevices[] = {\n>> \t{ \"dcmipp\", {}, false },\n>> -\t{ \"imx7-csi\", { { \"pxp\", 1 } }, false },\n>> +\t{ \"imx7-csi\", { { \"pxp\", 1 } }, true },\n>> \t{ \"intel-ipu6\", {}, true },\n>> \t{ \"intel-ipu7\", {}, true },\n>> \t{ \"j721e-csi2rx\", {}, true },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0681BD160\n\tfor ;\n\tTue, 23 Dec 2025 10:23:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D6C0361F96;\n\tTue, 23 Dec 2025 11:23:39 +0100 (CET)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82B0B61A35\n\tfor ;\n\tTue, 23 Dec 2025 11:23:37 +0100 (CET)","by mx.zohomail.com with SMTPS id 1766485412938499.4995915395051;\n\tTue, 23 Dec 2025 02:23:32 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"SntLO7FO\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1766485414; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=h3A3r1uCkTapZhaUEjKPyU41bZmlWbSDrEjigltasqO6FmSgtX1zhYIDfQFcu3UF/4/sm9l3FpgQgz+6A/TLfB1frOdgza4e+cH/CZBSfAdt60RwfdEdNF6x8cTezdwEMl2B0yMhWHLi7JhVYo4FtXIvrvZTvf29eIRjfOEguzI=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1766485414;\n\th=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=kQxI0WvXwvut6rwvblGygoPJ8LwwIAZmJ59ZfgSKEnQ=; \n\tb=HCvtc4wsIVUkhGt4+iZ48jj9Q6RrWaN195vR1DU6gHwYB80F9wXjIOZ5ZAlnqqhQ5IFR1WqYPQkBLMpv9yi0CgPY6IFQmx5Yx9g3zs6mgXpHfjHVK8vGUNcUu3+cxXJ2jmLA6J/V1R2Zcnt0jxtPaFvQ0Vpp0AA3q0L+y4D3xQI=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1766485414;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Content-Type:Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Message-Id:Reply-To;\n\tbh=kQxI0WvXwvut6rwvblGygoPJ8LwwIAZmJ59ZfgSKEnQ=;\n\tb=SntLO7FOEluGuGM3XYylvWiOXsGRMNvt/n9StRGawzIHkDLbsJp97nSEpq6fOsjw\n\tPn1l9zHfxFnTdX+t7I7lElz/lW44f67+f+kO9/2uoIL+Gl61ha8NmPx87/h0jHF7yxP\n\tEP95BPtrgTgcXxkwaYiPCx2JqTbhY0u4ooO5jYBQ=","Content-Type":"multipart/alternative;\n\tboundary=\"------------0kamx3kXY6ju1bvtAjAMGjgB\"","Message-ID":"<6da32085-d448-4e6a-9e0a-ec1b3fb66e09@collabora.com>","Date":"Tue, 23 Dec 2025 11:23:30 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20251219211006.104821-1-robert.mader@collabora.com>\n\t<20251223095527.GE9817@pendragon.ideasonboard.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20251223095527.GE9817@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37453,"web_url":"https://patchwork.libcamera.org/comment/37453/","msgid":"<8fa77990-8a18-4836-a5ab-97f8f74145a4@nxsw.ie>","date":"2025-12-30T22:57:16","subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 23/12/2025 10:23, Robert Mader wrote:\n> Indeed, I suppose it raises the broader question of: do we need to \n> protect users from using the soft ISP?\n\nEnvironment variable.\n\nThe question is I think - should it be on by default for i.MX6/7/8 or off ?\n\nIt'd be nice to think LLVM pipeline could perform some magic with eGL \nthat somehow makes this usable where the CPU is not.\n\nWorth a test to confirm this is no so :)\n\nI have an i.MX7 Solo board with upstream CSI2 support and a sensor, I \ncould even test this eventually myself.\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F34BEBD160\n\tfor ;\n\tTue, 30 Dec 2025 22:57:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 381E161FB8;\n\tTue, 30 Dec 2025 23:57:24 +0100 (CET)","from mail-4399.protonmail.ch (mail-4399.protonmail.ch\n\t[185.70.43.99])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B286B61613\n\tfor ;\n\tTue, 30 Dec 2025 23:57:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxsw.ie header.i=@nxsw.ie header.b=\"mZr4+fPn\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxsw.ie;\n\ts=protonmail3; t=1767135441; x=1767394641;\n\tbh=da3ZcCzXilwtuhFl54Qyd9gGhQQ5r5KrzUBFL/fOaI8=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=mZr4+fPn+YlGX7WUeujl6mR0Pt7GNAIuYVKJZePL9rLs1aihpsu57hKOk6wn1/0C7\n\tCJxaEt9Kg4ckcBgTEwpVNTdMz00gLCp2SI9XWrEyhpylsHzn6vKEUUC23FUHd7CGqB\n\ttY2svfrkRSajQ0F0BYkGLJkMFeMRfbIYW0Rph2ILJyVSJICnYeBhuu3KGjU7QmBwpO\n\t14/afNLIredB6Pn37TzisHSadLe6X2M31ShAbObJqaqZ96ywonflqlejJSY8xLblt9\n\tNyjCJQrrVOUFolzKUMqmOG/3ZpUnmEl24Imn77PgorMQpIbws36jIZKpo/d3aM4rTB\n\tvyv4WI5fxELsg==","Date":"Tue, 30 Dec 2025 22:57:16 +0000","To":"Robert Mader ,\n\tLaurent Pinchart ","From":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","Message-ID":"<8fa77990-8a18-4836-a5ab-97f8f74145a4@nxsw.ie>","In-Reply-To":"<6da32085-d448-4e6a-9e0a-ec1b3fb66e09@collabora.com>","References":"<20251219211006.104821-1-robert.mader@collabora.com>\n\t<20251223095527.GE9817@pendragon.ideasonboard.com>\n\t<6da32085-d448-4e6a-9e0a-ec1b3fb66e09@collabora.com>","Feedback-ID":"136405006:user:proton","X-Pm-Message-ID":"d03073c527ac1285f37e0837f248fcd5cd534f64","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37454,"web_url":"https://patchwork.libcamera.org/comment/37454/","msgid":"<85344oqr92.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2026-01-02T09:48:57","subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> On 23/12/2025 10:23, Robert Mader wrote:\n>> Indeed, I suppose it raises the broader question of: do we need to \n>> protect users from using the soft ISP?\n>\n> Environment variable.\n\nThere is already a configuration file option for the purpose.\n\n> The question is I think - should it be on by default for i.MX6/7/8 or off ?\n\nIf hardware ISP is supported on some of those platforms then I'd say it\nshould be off by default and it should be documented how to enable it in\ncase hardware ISP doesn't work. It can be overridden in the\nconfiguration on distros targeting specific boards.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80C61BDCC0\n\tfor ;\n\tFri, 2 Jan 2026 09:49:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B17C861FB9;\n\tFri, 2 Jan 2026 10:49:05 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 123646142F\n\tfor ;\n\tFri, 2 Jan 2026 10:49:02 +0100 (CET)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n\t[209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-694-3VJASC7FOWm9MKwmw0yyIw-1; Fri, 02 Jan 2026 04:49:00 -0500","by mail-wm1-f72.google.com with SMTP id\n\t5b1f17b1804b1-477964c22e0so87964215e9.0\n\tfor ;\n\tFri, 02 Jan 2026 01:49:00 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-4324ea82f6asm85635414f8f.27.2026.01.02.01.48.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Jan 2026 01:48:57 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"AlpLFlbP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1767347341;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=06uIqQnh349xJt+Tvket/jiIbAikiRlF231dKyNtPZY=;\n\tb=AlpLFlbPEhlSHKodfUv22puOL8Fm3mCt2lgVZ0QDS1xv4z2zgJmoHFRVb2KlFRtoUYfHqu\n\tEzjSJOhJiiiImKt7CJKm1Fg0iNuZ7e6PjSfwMDEx9dH5SnIWhKQU824AtY+g75ieALw6R/\n\tibdF+YdAdMDsFK//dLdO9T1oumQSoRk=","X-MC-Unique":"3VJASC7FOWm9MKwmw0yyIw-1","X-Mimecast-MFC-AGG-ID":"3VJASC7FOWm9MKwmw0yyIw_1767347339","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767347339; x=1767952139;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=06uIqQnh349xJt+Tvket/jiIbAikiRlF231dKyNtPZY=;\n\tb=Inqc30qlHs96OIYRu3tvxKSAv1ywicW34VvbyzFWk9fJxjdPtd4trQnikbEttYW3L/\n\tj2Z7dbQTnkSCVTxKYzc8QmhjN5xLLYJoQJEg0QfyEx6hvNPLoNT4yzO9xH4B0x8LW/km\n\td7uazKFMdoDosBKf/wMoGmInI9VHnQ3nQbTly7diZR2iv8fmlAkMjk++WkJTpGZoOxq4\n\t/zyLrq8/EZuwVj90PG9ZUIt5HfZtvyLejCuqWBdBzCOcbvCZfVe+ObKPwf3k1dEvNthH\n\t1M2510hwHCiq+Q6M7k3Zwl8xl104Vv87RQTA7w65oETcplTHYb2zMSW3MGzIPFYnJscw\n\tX+Yw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCU9PTtSiB18AfPCteZ2fGI9Dql5Ipx069o6SkwWKOeBWqswbexb3SY0JJRXygaqWMyQTA+gSn9PUmvMbt/bV/o=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwB5v42jnlrUYIR+8sphEaWlw9XI74Yp//vhMomprbk+EAacxuC\n\tUVjCiASc1cv5Uj+k0jk+ewnCRH3XT66Becs9c4c+WB8RRcNUJuFYyK7OM5EKh5YL8B4W63C3gqD\n\tGHR74fU8IWQnyH7pV+XzfMk4TInCsRTtnaNJYDUySSYN6hufCq7Xp7sOrz7UTt8td53Xdg+l46L\n\tNS7JEL/mzXO1yeXpndTM9vlVtVFd/6tk524kdJv2re2MmPQetFnUKCk9F8p5k=","X-Gm-Gg":"AY/fxX4YffWuDabPrOzbJL9fwXdSH45wwtSKmxyrB9LcI8myohGFSVTP114KjTYm4Cv\n\tkTxGngV+7srRHprzyI0w5lGh+ea4RZDj283+VBf7pgiOxAPVIy7B3HYDV9OsWeubyKtLDG9nNDM\n\tdJXzDMN+cDsypKP3RHsOgAdb0RT62FVOaIsnTHKB+CLwiPa1eolSOhxbXoMNRpAninAOAdP29hT\n\tkGcYQUCJTWWZV4HxYHgMX+py3YOsWyALUmv0k3Dz+TVf+zWVc2E6UTim4dtgabUP+LS6SY6+8iT\n\t70XWr6f4/F1W9A8URUpaEh4ChSuI+LYlHN61l/+9gKBrsCqVyeUpFi94Jgo6GabQgMyCZtxKNkB\n\t9HkCBWfc9d1J69aZADIqqYIJT454PBPU3SvRIFiyPI+ootmSxCS8c8SZwZ8kPBuk=","X-Received":["by 2002:a7b:ca4a:0:b0:477:75b4:d2d1 with SMTP id\n\t5b1f17b1804b1-47be29f3835mr390848695e9.15.1767347338999; \n\tFri, 02 Jan 2026 01:48:58 -0800 (PST)","by 2002:a7b:ca4a:0:b0:477:75b4:d2d1 with SMTP id\n\t5b1f17b1804b1-47be29f3835mr390848605e9.15.1767347338530; \n\tFri, 02 Jan 2026 01:48:58 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IFQAWaxmTaw9kbVxSWc1MaNrOSs3uitWBc6CQOLpX/72Pos+lVvGucLutpHII2DrwDA6H+f5A==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"Robert Mader , Laurent Pinchart\n\t, libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","In-Reply-To":"<8fa77990-8a18-4836-a5ab-97f8f74145a4@nxsw.ie> (Bryan\n\tO'Donoghue's message of \"Tue, 30 Dec 2025 22:57:16 +0000\")","References":"<20251219211006.104821-1-robert.mader@collabora.com>\n\t<20251223095527.GE9817@pendragon.ideasonboard.com>\n\t<6da32085-d448-4e6a-9e0a-ec1b3fb66e09@collabora.com>\n\t<8fa77990-8a18-4836-a5ab-97f8f74145a4@nxsw.ie>","Date":"Fri, 02 Jan 2026 10:48:57 +0100","Message-ID":"<85344oqr92.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"jWKMPVt42UUay10iIjkqnTqXdHYIm2TfyHuUl1ijpAQ_1767347339","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37458,"web_url":"https://patchwork.libcamera.org/comment/37458/","msgid":"<23155b69-a1ad-4feb-a730-599d01dcd9a9@nxsw.ie>","date":"2026-01-02T11:20:44","subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","submitter":{"id":226,"url":"https://patchwork.libcamera.org/api/people/226/","name":"Bryan O'Donoghue","email":"bod.linux@nxsw.ie"},"content":"On 02/01/2026 09:48, Milan Zamazal wrote:\n> Bryan O'Donoghue writes:\n> \n>> On 23/12/2025 10:23, Robert Mader wrote:\n>>> Indeed, I suppose it raises the broader question of: do we need to\n>>> protect users from using the soft ISP?\n>>\n>> Environment variable.\n> \n> There is already a configuration file option for the purpose.\n> \n>> The question is I think - should it be on by default for i.MX6/7/8 or off ?\n> \n> If hardware ISP is supported on some of those platforms then I'd say it\n> should be off by default and it should be documented how to enable it in\n> case hardware ISP doesn't work. It can be overridden in the\n> configuration on distros targeting specific boards.\n> \n\nI definitely mean for the !HardISP case here.\n\nOr what I really mean is at least i.MX7 and similar hardware which \ndoesn't have a GPU and does mesa via LLVM pipeline.\n\nIts an \"interesting question\" which would perform better, CPUISP or \nGPUISP/LLVM-pipeline but, I'd expect both to be tortuously slow on this \narm32 single core running @ 400 MHz if memory serves.\n\nI don't think LLVM can magic away the basic facts of the hardware. So \noff by default on i.MX7 Solo at least makes sense to me..\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47E07BDCC0\n\tfor ;\n\tFri, 2 Jan 2026 11:20:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EBB861FB9;\n\tFri, 2 Jan 2026 12:20:51 +0100 (CET)","from mail-4320.protonmail.ch (mail-4320.protonmail.ch\n\t[185.70.43.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD47461F9F\n\tfor ;\n\tFri, 2 Jan 2026 12:20:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxsw.ie header.i=@nxsw.ie header.b=\"mFJmMv62\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxsw.ie;\n\ts=protonmail3; t=1767352848; x=1767612048;\n\tbh=w1LEfcYWath8o1NRNeXIAYBLkTB3UQSHg1PuivvkLUc=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=mFJmMv62IJtmvFTI0jwEsdVe3DEuHrUsxyIYYa/Ai8cnsxPRl4JIqVMv0d45+yMQG\n\tn3OwixeC4Fnq8NDYvoOzPk7X02kqxKWJUsUHtXsEltuYFxZesNL6Zl8QSB73A/KjOv\n\t9zii+ztQ+bNsIMwTU9sjqOHWOace+YECsTrBoZEqcSIe+AQPQqWeIiVO3zs3+zKDsh\n\tDQ5Mhfi92TN5DUHWND/0y57D67cm/oQE6oQrK17J5xH8s0IOn0ySFq6dCiOlVUkmI6\n\td+qcV+qwQeVCGfBS+7ILyBHjKHj1qeeIiFdGb+3hQ/y8MNivQFo/IplllPG7isxUaZ\n\tp2iy0ROhaRPgQ==","Date":"Fri, 02 Jan 2026 11:20:44 +0000","To":"Milan Zamazal ","From":"Bryan O'Donoghue ","Cc":"Robert Mader ,\n\tLaurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","Message-ID":"<23155b69-a1ad-4feb-a730-599d01dcd9a9@nxsw.ie>","In-Reply-To":"<85344oqr92.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","References":"<20251219211006.104821-1-robert.mader@collabora.com>\n\t<20251223095527.GE9817@pendragon.ideasonboard.com>\n\t<6da32085-d448-4e6a-9e0a-ec1b3fb66e09@collabora.com>\n\t<8fa77990-8a18-4836-a5ab-97f8f74145a4@nxsw.ie>\n\t<85344oqr92.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Feedback-ID":"136405006:user:proton","X-Pm-Message-ID":"fb48f468a81bf8bbcc9f86fc00b7f07505ce7b67","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37669,"web_url":"https://patchwork.libcamera.org/comment/37669/","msgid":"","date":"2026-01-15T09:53:55","subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"We shortly talked about this one on the weekly call and figured that it \ncan go in as is - we just need someone to put a tag on. Maybe Bryan, \nMilan, Hans? :)\n\nBest regards\n\nOn 19.12.25 22:10, Robert Mader wrote:\n> Since commit \"libcamera: simple: Make raw streams working\" apps that rely\n> on raw streams - such as Millipixels - can work with the SoftISP being\n> enabled. Thus let's enable the later by default.\n>\n> Tested on a Librem5.\n>\n> Signed-off-by: Robert Mader \n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index b30b0a122..4a0b9f58d 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -257,7 +257,7 @@ namespace {\n> \n> static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"dcmipp\", {}, false },\n> -\t{ \"imx7-csi\", { { \"pxp\", 1 } }, false },\n> +\t{ \"imx7-csi\", { { \"pxp\", 1 } }, true },\n> \t{ \"intel-ipu6\", {}, true },\n> \t{ \"intel-ipu7\", {}, true },\n> \t{ \"j721e-csi2rx\", {}, true },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12DDFBDCBF\n\tfor ;\n\tThu, 15 Jan 2026 09:54:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0993061FC3;\n\tThu, 15 Jan 2026 10:54:06 +0100 (CET)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 397AE61F61\n\tfor ;\n\tThu, 15 Jan 2026 10:54:03 +0100 (CET)","by mx.zohomail.com with SMTPS id 1768470838426873.5996657328062;\n\tThu, 15 Jan 2026 01:53:58 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"B/JG7D+g\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1768470840; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=izYgI99iRWEA4zlDGvtOVNw2zf6kGTfI1SkAJ0hKmZ50jS62mW+eDiskpxdOXAxS743SeEX74Yk63J2v23MYRO1INod/+5YybOlIxv2XdoOXQcxmBesgPloYOIqWLtTP1DH+IB8cHnMJ32jhqmFFv1gZNoZ8aUBD8rg+LqC9Vrs=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1768470840;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=woXaIPgLajX8xTZGpEjyjdS6D1+9VRRSHlcs8Z0p4XM=; \n\tb=XOrdqHmWVRc6n8aHb4uL5LjKc9q/KdGG/QVZkJaEjEJMpaLtjnH12TADXYNgOQWMGpCLBMlqOB7DIRkbGY/YEw9M8DN47X7k+HVRM3WA0VqtDcWQP2SMWy/PNhv1dmklhODJAZIH2TVsBPf5Sv3c0xe9Xpf0BCYnslWeruyz45I=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768470840;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=woXaIPgLajX8xTZGpEjyjdS6D1+9VRRSHlcs8Z0p4XM=;\n\tb=B/JG7D+gxQdU+N7igY6Yk91dgG4on0xAa8NGkNKx+GgmkWViFzn1bn9djoppLXIt\n\teOvLTeVj2EK720zgYriIE/HE/QphAoDKrEpmu5nkMuMRDfjK7csmNsarkjuTJefXyvw\n\tOgMuOVBiRhGhl9aHrq9uN+cUfWn3r31cvWf0EFjQ=","Message-ID":"","Date":"Thu, 15 Jan 2026 10:53:55 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: simple: Enable SoftISP for imx7-csi","To":"libcamera-devel@lists.libcamera.org","References":"<20251219211006.104821-1-robert.mader@collabora.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20251219211006.104821-1-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]