[{"id":37427,"web_url":"https://patchwork.libcamera.org/comment/37427/","msgid":"<85h5tpb4jw.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-17T13:50:43","subject":"Re: [PATCH v9 26/26] libcamera: software_isp: Add a gpuisp todo list","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> List the series of things to do in GPU ISP in perceived order of\n> difficulty.\n>\n> Acked-by: Kieran Bingham \n> Signed-off-by: Bryan O'Donoghue \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/software_isp/gpuisp-todo.txt | 40 ++++++++++++++++++++++\n> 1 file changed, 40 insertions(+)\n> create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt\n>\n> diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt\n> new file mode 100644\n> index 000000000..8930da120\n> --- /dev/null\n> +++ b/src/libcamera/software_isp/gpuisp-todo.txt\n> @@ -0,0 +1,40 @@\n> +List the TODOs in perceived order of ease.\n> +\n> +\n> +Denoising:\n> +\t- WIP\n> +\n> +Dead pixel correction:\n> +\t- WIP\n> +\n> +Lense shading correction:\n> +\t- WIP\n> +\n> +Use dma-buf handle to generate upload texture:\n> +\t- eglCreateImageKHR can be used to generate the upload texture i.e.\n> +\t to feed the bayer data into the GPU.\n> +\n> +processFrame() to run in its own thread:\n> +\t- processFrame() runs in the context of the Debayer::process()\n> +\t thread. Robert Mader suggested and it seems like a good\n> +\t suggestion too to run processFrame() in its own thread.\n> +\n> +Multi-pass shaders:\n> +\t- This needs some rewiring the idea is to have a list\n> +\t of algorithms as is done in cpuisp iterating through the\n> +\t list in a for() loop.\n> +\t- The logic managing the loop has an initial input buffer\n> +\t and the final output buffer.\n> +\t- The higher level logic must then inform each of the\n> +\t algorithms either to generate an internal working buffer\n> +\t or pass the final output buffer to the last shader\n> +\t in the list\n> +\t- This will allow for multi-pass shaders with the final\n> +\t algorithm presenting data not to its internal buffer\n> +\t but to the final output buffer\n> +\n> +24 bit output support:\n> +\t- Need to implement compute shader to do this.\n> +\n> +Lense flare correction:\n> +\t- Not WIP still TBD","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18DCAC3257\n\tfor ;\n\tWed, 17 Dec 2025 13:50:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2BCF61A42;\n\tWed, 17 Dec 2025 14:50:49 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2DE661A35\n\tfor ;\n\tWed, 17 Dec 2025 14:50:48 +0100 (CET)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-507-aRMmw-XXMban0ia7D9OaEA-1; Wed, 17 Dec 2025 08:50:46 -0500","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-430f4609e80so2430238f8f.3\n\tfor ;\n\tWed, 17 Dec 2025 05:50:46 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb ([213.175.46.86])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-4310ada82d5sm5055395f8f.4.2025.12.17.05.50.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 05:50:44 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"hfnf1lgv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1765979447;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=b86M5ZLYWypgRr2CYM/3fDFnKi8mleCNETuZck2RWII=;\n\tb=hfnf1lgvCIxNu8Eug6TONWN7ULUAe0v+KwM10BepgzWt5IJHmvF18nnVcPfQPAvQ6CsTsS\n\tztmLUV5uNT33u4u/Y9jpYIcyrl5xdoUBcy1dlH4T9xyEpj0glEObbScuKkGubZzzt8sPoZ\n\tANfQ1x6zlnFdDbdSetbJ5CY/yBwJ3bI=","X-MC-Unique":"aRMmw-XXMban0ia7D9OaEA-1","X-Mimecast-MFC-AGG-ID":"aRMmw-XXMban0ia7D9OaEA_1765979445","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765979445; x=1766584245;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=b86M5ZLYWypgRr2CYM/3fDFnKi8mleCNETuZck2RWII=;\n\tb=nEif3XWipWuMWvxMA76XLYIQp5x4XzW84+pVn3fHRLa4HGZJJB1hu7juZzupq7Btjl\n\tvsJV7sOsswWuaMW9opQNYxXKa6hbE6L0Z1SrBTpxFnw969LVd5oj14Fz+wWGA2742Xn/\n\tKVji12SX92eyuCpXPzFQYF0MizIJHK+eL+ysgWfBoi8+CMup5VtPNhLkEZDm87YQyJCd\n\t63/9r2n8Rux0Z+G1u5eiyBymgCsqGPO0TS+fq0sg3N9z6zIV6JwGOjE/vxTwoRwB4A6c\n\tBLx1TFcJJCNH7QQ2svfkzlOHSdUtdBV4VFHB1YQveslTQUxeSitgbKdR4iXCSnf80b6c\n\tXqNg==","X-Gm-Message-State":"AOJu0YwbBVruu3C6ubsPkpopVC9he5M7oQvNJ9e7XxOkWiB8p1XPP+UP\n\t9t13tfPvA7gsn259j9ESj/DYwyjuOmyxZ25nV19yhtS+bunLW92QqwbnmTeMAHYDOrdErxiqTbH\n\trIG/EB8L+ULGoVeOfiWqcKF8clPnb/cVvulmlkmpazYLYwL/dxKYUkfCw3NlIxRlODFEpZ6d+b8\n\tw=","X-Gm-Gg":"AY/fxX76yofBM6zRSt/s2qqU/abewFF2CuErr2T9XiIpTnguK/xKofVyfvfUh8Ukfbt\n\t10treT0vDBvi3x/TF5yLCsWr9GhpdJXspCZW33LJaEfapFc5hcnhnlAM5gmCVcMl+/V4jNY8Ves\n\t0ObbSGn9ooq5pi3Le5ZUQZf/iUVXf5tHgqVRxUhR72ynUjCpj8kpd2InhCc3TL5Z+G/wQXgjYOJ\n\tUpwG14eeqaYQTxUjqUvvXD4LsWwOK/oOkP8Z/r9RmZ7sU27og2P88F0QK+3qIwHPnU+P0oPV5t3\n\tTldz8Uezv36LYPE/OC36AvHSWEwoaJFzdBc4HJSWBf+Nze0G5H+LIJbT8ZUuUTdFMKBM8DJpXxY\n\t+iAde46NptYktfOqWf5A09KSJCQ==","X-Received":["by 2002:a05:6000:2405:b0:430:f23f:4bbe with SMTP id\n\tffacd0b85a97d-430f23f4e20mr17389564f8f.24.1765979444988; \n\tWed, 17 Dec 2025 05:50:44 -0800 (PST)","by 2002:a05:6000:2405:b0:430:f23f:4bbe with SMTP id\n\tffacd0b85a97d-430f23f4e20mr17389527f8f.24.1765979444572; \n\tWed, 17 Dec 2025 05:50:44 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IGLnz1NzLm4LlB93ajgrZSIxpsMLtWG6xL5ZncORrHRvtkmDcVDbym1UIwIIRz8GFzJx7X63A==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz, Kieran Bingham\n\t","Subject":"Re: [PATCH v9 26/26] libcamera: software_isp: Add a gpuisp todo list","In-Reply-To":"<20251217100138.82525-27-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 17 Dec 2025 10:01:38 +0000\")","References":"<20251217100138.82525-1-bryan.odonoghue@linaro.org>\n\t<20251217100138.82525-27-bryan.odonoghue@linaro.org>","Date":"Wed, 17 Dec 2025 14:50:43 +0100","Message-ID":"<85h5tpb4jw.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"zaf7IoA5HL02Y2aTHN4Q8aItGPQwfwBEZu5IcdxlIuo_1765979445","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]