[{"id":37400,"web_url":"https://patchwork.libcamera.org/comment/37400/","msgid":"<176583013096.158506.16655326392837048282@ping.linuxembedded.co.uk>","date":"2025-12-15T20:22:10","subject":"Re: [PATCH] ipa: simple: awb: Fix ColourGains reported","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2025-12-15 20:06:14)\n> The AWB gains reported in the metadata are currently scaled against the\n> maximum gain, but in fact the gain itself is already stored as a\n> floating point gain value.\n> \n> Remove the incorrect scaling and report the gains directly.\n> \n> Fixes: a0b97475b1c0 (\"ipa: simple: Report the ColourGains in metadata\")\n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/simple/algorithms/awb.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index cf78e980098b..0080865aa34d 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -55,10 +55,9 @@ void Awb::process(IPAContext &context,\n> const SwIspStats::Histogram &histogram = stats->yHistogram;\n> const uint8_t blackLevel = context.activeState.blc.level;\n> \n> - const float maxGain = 1024.0;\n> const float mdGains[] = {\n> - static_cast(frameContext.gains.red / maxGain),\n> - static_cast(frameContext.gains.blue / maxGain)\n> + static_cast(frameContext.gains.red),\n> + static_cast(frameContext.gains.blue)\n\nLooks like the gains are a double for some reason. I think they could\nprobably be reduced to a float sometime and simplify this - but that's a\nlater patch.\n--\nKieran\n\n> };\n> metadata.set(controls::ColourGains, mdGains);\n> \n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68253C3257\n\tfor ;\n\tMon, 15 Dec 2025 20:22:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6350C619E4;\n\tMon, 15 Dec 2025 21:22:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EEBE615B2\n\tfor ;\n\tMon, 15 Dec 2025 21:22:14 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 20012766\n\tfor ;\n\tMon, 15 Dec 2025 21:22:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FsB/mXXt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765830129;\n\tbh=r3xBuh3gMfpHehT4Zg7TP07l4GGRykq4zb1bw6T74A8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=FsB/mXXtBs1275GtDYtbNxM0PyEJ8nh6nG0PN4hG++0SYSDPCguVUdpEv9nczEwxf\n\tBS9zTQutyRO2g2mP4BIYTzTSzxNF3pQUUw8hNsCtHYg2fuANfDHAQYIH8qMUYyWH2Q\n\t8wT1jtv9MXE2Couw3ObZ3F7Un7p5ScHgg80CzmB0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251215200614.41329-1-kieran.bingham@ideasonboard.com>","References":"<20251215200614.41329-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH] ipa: simple: awb: Fix ColourGains reported","From":"Kieran Bingham ","Cc":"","To":"libcamera devel ","Date":"Mon, 15 Dec 2025 20:22:10 +0000","Message-ID":"<176583013096.158506.16655326392837048282@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37401,"web_url":"https://patchwork.libcamera.org/comment/37401/","msgid":"<85h5trbh8u.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-15T20:52:01","subject":"Re: [PATCH] ipa: simple: awb: Fix ColourGains reported","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Kieran Bingham writes:\n\n> Quoting Kieran Bingham (2025-12-15 20:06:14)\n>> The AWB gains reported in the metadata are currently scaled against the\n>> maximum gain, but in fact the gain itself is already stored as a\n>\n>> floating point gain value.\n>> \n>> Remove the incorrect scaling and report the gains directly.\n>> \n>> Fixes: a0b97475b1c0 (\"ipa: simple: Report the ColourGains in metadata\")\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/ipa/simple/algorithms/awb.cpp | 5 ++---\n>> 1 file changed, 2 insertions(+), 3 deletions(-)\n>> \n>> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n>> index cf78e980098b..0080865aa34d 100644\n>> --- a/src/ipa/simple/algorithms/awb.cpp\n>> +++ b/src/ipa/simple/algorithms/awb.cpp\n>> @@ -55,10 +55,9 @@ void Awb::process(IPAContext &context,\n>> const SwIspStats::Histogram &histogram = stats->yHistogram;\n>> const uint8_t blackLevel = context.activeState.blc.level;\n>> \n>> - const float maxGain = 1024.0;\n>> const float mdGains[] = {\n>> - static_cast(frameContext.gains.red / maxGain),\n>> - static_cast(frameContext.gains.blue / maxGain)\n>> + static_cast(frameContext.gains.red),\n>> + static_cast(frameContext.gains.blue)\n>\n> Looks like the gains are a double for some reason. I think they could\n> probably be reduced to a float sometime and simplify this - but that's a\n> later patch.\n\nIt's done in my simple IPA refactoring patches, so no need to worry\nabout it other than dropping the type casting above. (I'm always\nconfused whether to use double or float for values like these unless\nthere is some very obvious reason; is there any rule of thumb?)\n\nAnyway, for this patch:\n\nReviewed-by: Milan Zamazal \n\n> --\n> Kieran\n>\n>> };\n>> metadata.set(controls::ColourGains, mdGains);\n>> \n>> -- \n>> 2.52.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 869CBBD7D8\n\tfor ;\n\tMon, 15 Dec 2025 20:52:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B728619E4;\n\tMon, 15 Dec 2025 21:52:09 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D59B615B2\n\tfor ;\n\tMon, 15 Dec 2025 21:52:08 +0100 (CET)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n\t[209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-61-r7hhC9WUP3-Yh4l9ImNoAg-1; Mon, 15 Dec 2025 15:52:05 -0500","by mail-wm1-f72.google.com with SMTP id\n\t5b1f17b1804b1-4776079ada3so33120925e9.1\n\tfor ;\n\tMon, 15 Dec 2025 12:52:05 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bd69e6482sm490815e9.10.2025.12.15.12.52.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 15 Dec 2025 12:52:02 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"TTRI6iNu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1765831927;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=/WHMbqe5e2ldQ2bxAitSRbFTsWyIwyKouACC2k8dNPo=;\n\tb=TTRI6iNuEBnaAcFZr6yYBFwLUTVNKElbjRXmCyIt031dNhFmfVnbq+BdOQFJzQjoT6yBWk\n\tBTaOyMmsmeKvZvHj/C3Yv0bZsaTkbXOdis997lTfZzXUO6bB5vpj5az6XSlUg+zOfYeYN4\n\tvXd7xrOpnHJbCrjSC1w7/iGFHDdjgfg=","X-MC-Unique":"r7hhC9WUP3-Yh4l9ImNoAg-1","X-Mimecast-MFC-AGG-ID":"r7hhC9WUP3-Yh4l9ImNoAg_1765831924","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765831924; x=1766436724;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=/WHMbqe5e2ldQ2bxAitSRbFTsWyIwyKouACC2k8dNPo=;\n\tb=cfeUsry7KbuJwmFyy10UVCMYjy/r9d6zvTyXwrQ8MJ4E5S186OX/ZgeLEfd/RK8Amc\n\tNuzYve3nIfkSQbhlWsL5XBx9i+VtpAZ+4cFkpm50YnIpCN5ZwDUOJCl+SNcYMMd6Yijd\n\t17vTGNdqEh2oc7osgArFauRq4oQevtq0fMtCY4YC2batgdnyqn+SWxZKVR+Lgv1u8WWJ\n\tAjhRjGf/is1U4o2dZgo6j5X2DYD0jCQSTmifajCVFYgeIjZCbMMWQXis8iKmYU6X7tGW\n\tdktVGIHlw0BJ7vXJYgYQjeFHw0k6td4svdj7rjNTbdn4fYl7aiR2XTxR28wdkVkOTygv\n\t7FEw==","X-Gm-Message-State":"AOJu0YzubA1eNTTiSHPWE4MU3a6LAdPqxvA9c77tPLinK9jcrrsAgndE\n\tJ+vdg061xw0YvD5SUeN0LF7fTbl9RJw6ffYB7kbAmr4KC/gCMsdbPrFYpoP+vJ6tAAdr773vJtP\n\t9Nw11NhfzpQ82T0VQXGY0B3edJDn/Xqc9rBKJD4yMxhsLOVADua5+hXj/IjMkSWtO/A2nYW2o3f\n\t9dVJbHaGxRgLcbK+NIcmMtcJer6y/quPW9ZkKzHHjxuNixnUb68kiIwyQapM8=","X-Gm-Gg":"AY/fxX5dtvd2bvHdZYCNt5F1qPi0Pugut/Iv7T0UvxA9qeWGcz64tfnPafjR0nQbKAj\n\t8lsa23YN7iSyCUzowXNkorrX63qGXDtXFK2KoS/SI+xlK6JAPdARC9jbTj6OUCtzflWerpWrFhL\n\twlvl4RGVGvOYkzA5KzGbfMcMsMmeMcFWtNK0e10icNH4e5xVGfw1kJf1T2RYsvgdVS69lP1pjJ3\n\tq9lgspkShrm/B4+xrhkDx8ZQw2EK6eQmZyPHg1CQ6MQldU4X751nYyXHdCZ7ww+mzBxqaULAa06\n\tS2yOjk0QvCdQBoyuNzDLkTH+70yN6SMX1RXqTUJ5AVQlk144uJg591PUXX+FmIihf2Zg0RQahm7\n\tWt1vhSCjEsf4ubkFjxrMgUY0jenFYQp6gK2Kl+wsiEVpUiaWpP5EMnd4XQvup4OU=","X-Received":["by 2002:a05:600c:1991:b0:479:3a87:208f with SMTP id\n\t5b1f17b1804b1-47a8f9164d5mr129419145e9.36.1765831923702; \n\tMon, 15 Dec 2025 12:52:03 -0800 (PST)","by 2002:a05:600c:1991:b0:479:3a87:208f with SMTP id\n\t5b1f17b1804b1-47a8f9164d5mr129418985e9.36.1765831923208; \n\tMon, 15 Dec 2025 12:52:03 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IFYeihiRvlt7pcAnrqc+Z/nybz4LXLZuWTmt/b8nMP+krUtyu4dQ7x0+TH9CuOXQl+8owYVOw==","From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH] ipa: simple: awb: Fix ColourGains reported","In-Reply-To":"<176583013096.158506.16655326392837048282@ping.linuxembedded.co.uk>\n\t(Kieran Bingham's message of \"Mon, 15 Dec 2025 20:22:10 +0000\")","References":"<20251215200614.41329-1-kieran.bingham@ideasonboard.com>\n\t<176583013096.158506.16655326392837048282@ping.linuxembedded.co.uk>","Date":"Mon, 15 Dec 2025 21:52:01 +0100","Message-ID":"<85h5trbh8u.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"CXEltax7I_YZsiomkY3-6VbYk49DszMLYAVpfgZaAsI_1765831924","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37404,"web_url":"https://patchwork.libcamera.org/comment/37404/","msgid":"<658858e2-8b76-46be-8c1e-9661bcbdf75a@ideasonboard.com>","date":"2025-12-16T08:52:22","subject":"Re: [PATCH] ipa: simple: awb: Fix ColourGains reported","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 12. 15. 21:06 keltezéssel, Kieran Bingham írta:\n> The AWB gains reported in the metadata are currently scaled against the\n> maximum gain, but in fact the gain itself is already stored as a\n> floating point gain value.\n> \n> Remove the incorrect scaling and report the gains directly.\n> \n> Fixes: a0b97475b1c0 (\"ipa: simple: Report the ColourGains in metadata\")\n> Signed-off-by: Kieran Bingham \n> ---\n\nLooks correct to me.\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/simple/algorithms/awb.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index cf78e980098b..0080865aa34d 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -55,10 +55,9 @@ void Awb::process(IPAContext &context,\n> \tconst SwIspStats::Histogram &histogram = stats->yHistogram;\n> \tconst uint8_t blackLevel = context.activeState.blc.level;\n> \n> -\tconst float maxGain = 1024.0;\n> \tconst float mdGains[] = {\n> -\t\tstatic_cast(frameContext.gains.red / maxGain),\n> -\t\tstatic_cast(frameContext.gains.blue / maxGain)\n> +\t\tstatic_cast(frameContext.gains.red),\n> +\t\tstatic_cast(frameContext.gains.blue)\n> \t};\n> \tmetadata.set(controls::ColourGains, mdGains);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D69A0BD7D8\n\tfor ;\n\tTue, 16 Dec 2025 08:52:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 02114619FF;\n\tTue, 16 Dec 2025 09:52:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBD7461603\n\tfor ;\n\tTue, 16 Dec 2025 09:52:25 +0100 (CET)","from [192.168.33.23] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 38F75581;\n\tTue, 16 Dec 2025 09:52:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R3dIUOF4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765875140;\n\tbh=RCuJq6ltEePLqlpnNnmH71F7g+9AxLPM5E81o1Ug2Xw=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=R3dIUOF4/S8sYAC5To0fShUqzSGFlKVB8r6+LEmL9ooNDVcPapk15FB4mC0lL7A52\n\tL16zIF1oGeQMm0iVG96+6/DnCXemM9IYDxX9nd73ZNK4OM3dFJ9egg4JMawfjb6V0H\n\tk+MSP4QGakcHj+BmuywROr2F1aHMV+PowN3XDPWI=","Message-ID":"<658858e2-8b76-46be-8c1e-9661bcbdf75a@ideasonboard.com>","Date":"Tue, 16 Dec 2025 09:52:22 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ipa: simple: awb: Fix ColourGains reported","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20251215200614.41329-1-kieran.bingham@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251215200614.41329-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]