[{"id":37385,"web_url":"https://patchwork.libcamera.org/comment/37385/","msgid":"<8c57a4f2bd9457884598c3ee04907973e521e357.camel@ndufresne.ca>","date":"2025-12-15T15:00:49","subject":"Re: [PATCH v1 1/1] gstreamer: Add raw support to libcamerasrc\n\tstream-role property","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Hi Julien,\n\nLe lundi 15 décembre 2025 à 15:53 +0100, Julien Vuillaumier a écrit :\n> The current definition of the stream-role property of libcamerasrc\n> element does not allow for the Raw (0) value to be assigned.\n> That property is used to query the pipeline handlers through\n> generateConfiguration(roles) to retrieve the formats exposed to\n> the user. Not being able to specify the raw stream-role, bayer\n> formats are not reported so can not be used for caps negotiation.\n> \n> Adding value stream-role=raw enables usage of bayer GStreamer pipelines\n> like:\n> \n> `gst-launch-1.0 libcamerasrc camera-name= src::stream-role=raw !\n>     video/x-bayer, format=bggr16le ! ...`\n> \n> Signed-off-by: Julien Vuillaumier \n\nAppreciated, patch looks good.\n\nReviewed-by: Nicolas Dufresne \n\n> ---\n>  src/gstreamer/gstlibcamerapad.cpp | 4 ++++\n>  1 file changed, 4 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamerapad.cpp\n> b/src/gstreamer/gstlibcamerapad.cpp\n> index b37c4b340..c1f7f16e8 100644\n> --- a/src/gstreamer/gstlibcamerapad.cpp\n> +++ b/src/gstreamer/gstlibcamerapad.cpp\n> @@ -95,6 +95,10 @@ gst_libcamera_stream_role_get_type()\n>  \tstatic GType type = 0;\n>  \tstatic const GEnumValue values[] = {\n>  \t\t{\n> +\t\t\tstatic_cast(StreamRole::Raw),\n> +\t\t\t\"libcamera::Raw\",\n> +\t\t\t\"raw\",\n> +\t\t}, {\n>  \t\t\tstatic_cast(StreamRole::StillCapture),\n>  \t\t\t\"libcamera::StillCapture\",\n>  \t\t\t\"still-capture\",","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67AD9BD7D8\n\tfor ;\n\tMon, 15 Dec 2025 15:01:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 821AF61980;\n\tMon, 15 Dec 2025 16:01:01 +0100 (CET)","from mail-qk1-x731.google.com (mail-qk1-x731.google.com\n\t[IPv6:2607:f8b0:4864:20::731])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6843615B2\n\tfor ;\n\tMon, 15 Dec 2025 16:00:59 +0100 (CET)","by mail-qk1-x731.google.com with SMTP id\n\taf79cd13be357-8b5ccceb382so395750585a.1\n\tfor ;\n\tMon, 15 Dec 2025 07:00:59 -0800 (PST)","from ?IPv6:2606:6d00:17:7b4b::5ac? ([2606:6d00:17:7b4b::5ac])\n\tby smtp.gmail.com with ESMTPSA id\n\taf79cd13be357-8bab5d4cd34sm1071963085a.47.2025.12.15.07.00.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 15 Dec 2025 07:00:52 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20230601.gappssmtp.com\n\theader.i=@ndufresne-ca.20230601.gappssmtp.com\n\theader.b=\"ZKuZWpf/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1765810858;\n\tx=1766415658; darn=lists.libcamera.org; \n\th=mime-version:user-agent:autocrypt:references:in-reply-to:date:to\n\t:from:subject:message-id:from:to:cc:subject:date:message-id:reply-to; \n\tbh=kSrkoWuEOmLd2J3kUQR+qtN/trmdmTVmsoLOKmCjdTA=;\n\tb=ZKuZWpf/0JskBMjHRYJvmd6XygcrpTKUU3ubd7jRkbI+AA60CDPFnoCiamNvJ+dx0r\n\tgtAJ0CmqxQDV+qRxCrRd27I4yBU/jgqXFeahoCCsw7259tvY+YPaoJbpehiVO41hMVRW\n\t0kyXr4HfSINvyeP2Mbzl/un89JFxozOqLVrjYI9X8wJxJ2o020ts0ALy7EqhirKRfUy+\n\teF6UcEbVnxHCSZqs5B0JVhCsB0IMXgXUKC9UNOh5GzejwVelCJykIBLQOb9u+ilcX0BE\n\tQs0BgK5lbO1svqaolNS8bV0980VmUzN3f2xDe/dhU4mnLKVCjqWikGOQdhHIV1ZgLw6R\n\t+0Yw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765810858; x=1766415658;\n\th=mime-version:user-agent:autocrypt:references:in-reply-to:date:to\n\t:from:subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=kSrkoWuEOmLd2J3kUQR+qtN/trmdmTVmsoLOKmCjdTA=;\n\tb=hd1RD9orlJByYp9rNMJbP1i+TgcEIHQuQgVmvn9oFhShUlryjT6IQf82HwRDSDJU9I\n\tLxUynYPGWbIfD8foLbHh+hScTuuiE6i0EQ8TPYWnInwmKViu3KZTM/qjFJ0z8bEsrKbz\n\tZfsXWVeMT6z+anhD8IhMQ3YJw/y9aOSC8HSYAosY9tnwZi3On+8T8PJVQE7f86AI46dh\n\tt63IeR43gLd+oDHQWR5+jWdP6QqIcgzAUm9kEZ3pNvVSr7wSVCImaxvjKViHGUFrTzuB\n\t3JTKjn6rfmGHVG9lc9Xyi9DTJFdmnWcC/61idBOyy+4WI9a+bUw6gAt6xg7xcNIKEOdl\n\t6svA==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVLGNRliJfFQbeE84PcdAgUoVoTjIeUpbe3y6cHrgsUcZeqF8zJh+D2GjvtW6UEh2FQDTe5TjSkFbjk02pen+k=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yztl6JM3tHL4tHWahQJQktVXJNqZ9psv7hY5pytWgDl0T9c4yYK\n\tco8hiHXpou14PftFFr4maCWMPntF0UyS4dSGDyYAlo2ZpPYswdMTFHp0+/XE/cOF4I0=","X-Gm-Gg":"AY/fxX7s5CSqQA3B6jeImLxVTq1mnLcOUAmku+4VMmQycMyopASNm8NFKtulG8Ddv84\n\tJRqmppFwlxzPoikd/YwC/W0z8qHEzKVgkURhAmfpnocYE9m8imSkGS6ekZ//qcPIc6GRWAym6Jq\n\tlVxalYMa9f/C8PbdZkHMRqUZv3gc4JQmFSsfIS3oX6PN60ArGwZ/CVyv2P8iog6p2CmkyuO8D1C\n\t73/dkMMun0FVgM4AD2XK4nP/c4UvgmQXdeYeQ1GmwNzwfa00tPw5sFa7SSERd5Y56KucCbBhVPa\n\tX2L4z1e2uGCDki02XT1DoifdaGPBZuz18r3IlCyxw9GxA2jUOp1zDc17F1+sibnqsO+10ydpjSL\n\tzxND/H/SJx2bsIjBYP69lA//Nb80VI3z9IfL7YVpJgolupgXazPv7s3alqk2epqBIR5DRKPlS10\n\t00W08M1CEO83j6w9Qc","X-Google-Smtp-Source":"AGHT+IGRDvfcoyBoaEhzUbyTIF/dc454wzLEHMRZRS+S7iLpAteuL91HXTSIA3ITojOiOgIwttMsvw==","X-Received":"by 2002:a05:620a:1a85:b0:8b2:d648:493f with SMTP id\n\taf79cd13be357-8bb3a3947c0mr1561299385a.77.1765810853829; \n\tMon, 15 Dec 2025 07:00:53 -0800 (PST)","Message-ID":"<8c57a4f2bd9457884598c3ee04907973e521e357.camel@ndufresne.ca>","Subject":"Re: [PATCH v1 1/1] gstreamer: Add raw support to libcamerasrc\n\tstream-role property","From":"Nicolas Dufresne ","To":"Julien Vuillaumier , \n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 15 Dec 2025 10:00:49 -0500","In-Reply-To":"<20251215145305.4187195-2-julien.vuillaumier@nxp.com>","References":"<20251215145305.4187195-1-julien.vuillaumier@nxp.com>\n\t<20251215145305.4187195-2-julien.vuillaumier@nxp.com>","Autocrypt":"addr=nicolas@ndufresne.ca; prefer-encrypt=mutual;\n\tkeydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD\n\t/e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA\n\tcCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo\n\tCGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN\n\tabIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z\n\tnJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4\n\tAWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ\n\tsmBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC\n\tAAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF\n\tiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw\n\tECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8\n\tbRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-ofl/FP8D4+Um3LkHz8Ck\"","User-Agent":"Evolution 3.58.2 (3.58.2-1.fc43) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37389,"web_url":"https://patchwork.libcamera.org/comment/37389/","msgid":"","date":"2025-12-15T15:53:03","subject":"Re: [PATCH v1 1/1] gstreamer: Add raw support to libcamerasrc\n\tstream-role property","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Julien\n\nOn Mon, Dec 15, 2025 at 10:00:49AM -0500, Nicolas Dufresne wrote:\n> Hi Julien,\n>\n> Le lundi 15 décembre 2025 à 15:53 +0100, Julien Vuillaumier a écrit :\n> > The current definition of the stream-role property of libcamerasrc\n> > element does not allow for the Raw (0) value to be assigned.\n> > That property is used to query the pipeline handlers through\n> > generateConfiguration(roles) to retrieve the formats exposed to\n> > the user. Not being able to specify the raw stream-role, bayer\n> > formats are not reported so can not be used for caps negotiation.\n> >\n> > Adding value stream-role=raw enables usage of bayer GStreamer pipelines\n> > like:\n> >\n> > `gst-launch-1.0 libcamerasrc camera-name= src::stream-role=raw !\n> >     video/x-bayer, format=bggr16le ! ...`\n> >\n> > Signed-off-by: Julien Vuillaumier \n>\n> Appreciated, patch looks good.\n>\n> Reviewed-by: Nicolas Dufresne \n>\n\nThanks, I still wonder if this was intentionally left out or not..\n\nAnyway, looks sane indeed\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> > ---\n> >  src/gstreamer/gstlibcamerapad.cpp | 4 ++++\n> >  1 file changed, 4 insertions(+)\n> >\n> > diff --git a/src/gstreamer/gstlibcamerapad.cpp\n> > b/src/gstreamer/gstlibcamerapad.cpp\n> > index b37c4b340..c1f7f16e8 100644\n> > --- a/src/gstreamer/gstlibcamerapad.cpp\n> > +++ b/src/gstreamer/gstlibcamerapad.cpp\n> > @@ -95,6 +95,10 @@ gst_libcamera_stream_role_get_type()\n> >  \tstatic GType type = 0;\n> >  \tstatic const GEnumValue values[] = {\n> >  \t\t{\n> > +\t\t\tstatic_cast(StreamRole::Raw),\n> > +\t\t\t\"libcamera::Raw\",\n> > +\t\t\t\"raw\",\n> > +\t\t}, {\n> >  \t\t\tstatic_cast(StreamRole::StillCapture),\n> >  \t\t\t\"libcamera::StillCapture\",\n> >  \t\t\t\"still-capture\",","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09E10C3257\n\tfor ;\n\tMon, 15 Dec 2025 15:53:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6550619E0;\n\tMon, 15 Dec 2025 16:53:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 598A6619D8\n\tfor ;\n\tMon, 15 Dec 2025 16:53:09 +0100 (CET)","from ideasonboard.com (mob-5-90-49-39.net.vodafone.it [5.90.49.39])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61B80EB4;\n\tMon, 15 Dec 2025 16:53:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RMNu2wm2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765813984;\n\tbh=ALCoHDKKNtARy2bmo5pzZ4jSfNSaBWwDJtWpKzbgVb0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RMNu2wm2L6IWzFLe6JZ5mCvJGbr8skutt7tZeMbdO1zY0ANPEK4+J3O7NmFFcIr1J\n\ttJ2VlUDBTxwhPFeeEPOqiP9vOfnAFvciTGHoGOLX7qACjsCa7VFNj8+FZoIBhD/+2V\n\tmFEdZq+3Lm5iKWrJaBjGKaS5zAbLNkJhVZXfM3Wo=","Date":"Mon, 15 Dec 2025 16:53:03 +0100","From":"Jacopo Mondi ","To":"Nicolas Dufresne ","Cc":"Julien Vuillaumier , \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/1] gstreamer: Add raw support to libcamerasrc\n\tstream-role property","Message-ID":"","References":"<20251215145305.4187195-1-julien.vuillaumier@nxp.com>\n\t<20251215145305.4187195-2-julien.vuillaumier@nxp.com>\n\t<8c57a4f2bd9457884598c3ee04907973e521e357.camel@ndufresne.ca>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"xiquvuvflsacal6y\"","Content-Disposition":"inline","In-Reply-To":"<8c57a4f2bd9457884598c3ee04907973e521e357.camel@ndufresne.ca>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]